From: "Lendacky, Thomas" <thomas.lendacky@amd.com>
To: Gerd Hoffmann <kraxel@redhat.com>, devel@edk2.groups.io
Cc: Bob Feng <bob.c.feng@intel.com>,
Yuwei Chen <yuwei.chen@intel.com>,
Erdem Aktas <erdemaktas@google.com>,
Jordan Justen <jordan.l.justen@intel.com>,
Peter Grehan <grehan@freebsd.org>,
Rebecca Cran <rebecca@bsdio.com>,
Liming Gao <gaoliming@byosoft.com.cn>,
Ard Biesheuvel <ardb+tianocore@kernel.org>,
Jiewen Yao <jiewen.yao@intel.com>, Min Xu <min.m.xu@intel.com>,
Brijesh Singh <brijesh.singh@amd.com>,
Oliver Steffen <osteffen@redhat.com>,
Pawel Polawski <ppolawsk@redhat.com>,
James Bottomley <jejb@linux.ibm.com>
Subject: Re: [PATCH 00/14] OvmfPkg: avoid global variables in PEI
Date: Mon, 12 Dec 2022 10:58:17 -0600 [thread overview]
Message-ID: <0b50afd4-cf0c-a8fd-443f-88a0f615a0ed@amd.com> (raw)
In-Reply-To: <20221202131009.3190040-1-kraxel@redhat.com>
On 12/2/22 07:09, Gerd Hoffmann wrote:
> Writing to global variables changes the PEI firmware volume which in
> turn screws up firmware volume measurements. Fix OvmfPkg to avoid that,
> for the most part by using the PlatformInfoHob instead.
Boot tested SEV, SEV-ES and SEV-SNP guests without issues. For the series:
Tested-by: Tom Lendacky <thomas.lendacky@amd.com>
>
> Gerd Hoffmann (14):
> tools_def: remove GCC_IA32_CC_FLAGS/GCC_X64_CC_FLAGS
> tools_def: add -fno-omit-frame-pointer to GCC48_{IA32,X64}_CC_FLAGS
> OvmfPkg/PlatformPei: AmdSev: stop using mPlatformInfoHob
> OvmfPkg/PlatformPei: PeiFv: stop using mPlatformInfoHob
> OvmfPkg/PlatformPei Q35 SMM helpers: stop using mPlatformInfoHob
> OvmfPkg/PlatformPei: PeiMemory: stop using mPlatformInfoHob
> OvmfPkg/PlatformPei: MemTypeInfo: stop using mPlatformInfoHob
> OvmfPkg/PlatformPei: NoExec: stop using mPlatformInfoHob
> OvmfPkg/PlatformPei: Verification: stop using mPlatformInfoHob
> OvmfPkg/PlatformPei: remove mPlatformInfoHob
> OvmfPkg/PlatformPei: remove mFeatureControlValue
> OvmfPkg/DebugLibIoPort: use Rom version for PEI
> OvmfPkg/QemuFwCfgLib: rewrite fw_cfg probe
> OvmfPkg/QemuFwCfgLib: remove mQemuFwCfgSupported +
> mQemuFwCfgDmaSupported
>
> OvmfPkg/AmdSev/AmdSevX64.dsc | 4 +-
> OvmfPkg/Bhyve/BhyveX64.dsc | 4 +-
> OvmfPkg/Microvm/MicrovmX64.dsc | 4 +-
> OvmfPkg/OvmfPkgIa32.dsc | 4 +-
> OvmfPkg/OvmfPkgIa32X64.dsc | 4 +-
> OvmfPkg/OvmfPkgX64.dsc | 4 +-
> .../PlatformRomDebugLibIoPort.inf | 2 +-
> .../Library/QemuFwCfgLib/QemuFwCfgPeiLib.inf | 5 +-
> OvmfPkg/Include/Library/PlatformInitLib.h | 6 +
> OvmfPkg/PlatformPei/Platform.h | 18 +--
> OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgPei.c | 143 ++++++++++--------
> OvmfPkg/PlatformPei/AmdSev.c | 14 +-
> OvmfPkg/PlatformPei/FeatureControl.c | 44 ++++--
> OvmfPkg/PlatformPei/Fv.c | 6 +-
> OvmfPkg/PlatformPei/MemDetect.c | 56 +++----
> OvmfPkg/PlatformPei/MemTypeInfo.c | 4 +-
> OvmfPkg/PlatformPei/Platform.c | 92 ++++++-----
> BaseTools/Conf/tools_def.template | 6 +-
> 18 files changed, 232 insertions(+), 188 deletions(-)
>
next prev parent reply other threads:[~2022-12-12 16:58 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-02 13:09 [PATCH 00/14] OvmfPkg: avoid global variables in PEI Gerd Hoffmann
2022-12-02 13:09 ` [PATCH 01/14] tools_def: remove GCC_IA32_CC_FLAGS/GCC_X64_CC_FLAGS Gerd Hoffmann
2022-12-02 13:09 ` [PATCH 02/14] tools_def: add -fno-omit-frame-pointer to GCC48_{IA32,X64}_CC_FLAGS Gerd Hoffmann
2022-12-02 13:09 ` [PATCH 03/14] OvmfPkg/PlatformPei: AmdSev: stop using mPlatformInfoHob Gerd Hoffmann
2022-12-02 13:09 ` [PATCH 04/14] OvmfPkg/PlatformPei: PeiFv: " Gerd Hoffmann
2022-12-02 13:10 ` [PATCH 05/14] OvmfPkg/PlatformPei Q35 SMM helpers: " Gerd Hoffmann
2022-12-02 13:10 ` [PATCH 06/14] OvmfPkg/PlatformPei: PeiMemory: " Gerd Hoffmann
2022-12-02 13:10 ` [PATCH 07/14] OvmfPkg/PlatformPei: MemTypeInfo: " Gerd Hoffmann
2022-12-02 13:10 ` [PATCH 08/14] OvmfPkg/PlatformPei: NoExec: " Gerd Hoffmann
2022-12-02 13:10 ` [PATCH 09/14] OvmfPkg/PlatformPei: Verification: " Gerd Hoffmann
2022-12-02 13:10 ` [PATCH 10/14] OvmfPkg/PlatformPei: remove mPlatformInfoHob Gerd Hoffmann
2022-12-02 13:10 ` [PATCH 11/14] OvmfPkg/PlatformPei: remove mFeatureControlValue Gerd Hoffmann
2022-12-02 13:10 ` [PATCH 12/14] OvmfPkg/DebugLibIoPort: use Rom version for PEI Gerd Hoffmann
2022-12-02 13:10 ` [PATCH 13/14] OvmfPkg/QemuFwCfgLib: rewrite fw_cfg probe Gerd Hoffmann
2022-12-02 13:10 ` [PATCH 14/14] OvmfPkg/QemuFwCfgLib: remove mQemuFwCfgSupported + mQemuFwCfgDmaSupported Gerd Hoffmann
2022-12-12 16:58 ` Lendacky, Thomas [this message]
2022-12-14 17:26 ` [PATCH 00/14] OvmfPkg: avoid global variables in PEI Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0b50afd4-cf0c-a8fd-443f-88a0f615a0ed@amd.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox