From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (NAM10-BN7-obe.outbound.protection.outlook.com [40.107.92.86]) by mx.groups.io with SMTP id smtpd.web11.48940.1670864303044746199 for ; Mon, 12 Dec 2022 08:58:23 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@amd.com header.s=selector1 header.b=y8LoB6Ok; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: amd.com, ip: 40.107.92.86, mailfrom: thomas.lendacky@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=esfENBa7UFTOSELX3ShtDibpiwIHWc3nb36wu1U5ryNlYzGW62ipcS2Q3qF0REy0STVKSMpjlPqzu+0lTVLlWOKhjSd6C+wcRtJo/xiPvEo2dtpCTdvehFgyccGiWZ1J/yWsKSGru1R3DEwApSudizYFDKrQW5Y5801abwG86N6mze1X2EGcinDPkEWJHhtyA5HNmUskmDHr1+tzDFmKEywQtTfyeJHxrWQa52uAzYxYLi8GPdq21KoYl5w4gVGzjjgViGjEDy8q0ObwO/npTyfScwqRh+aqIlF+nuOBPSM3KTfqlKWoiS+4Tn9wcXr35Ee75QuOiJkKZWs92msFiA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KE2P2MgTEci9iS91KoGsWw2xVILmJR/3ga3o+SWCZ84=; b=FHFlN5t+nyuMjzIqX+X+JmbvRAcezZckloXXblIUNv8UGh4uA09i3Tt7Ge23/tvm0JVoChfMvoIMr5iAfjEiBz129Udme43VkDKqZPR5E6MljEusTTaTEbIZojAnEZOzItIm4LlTXau9GCvlFJj8zweRraASDa3zz627YnnpVNYda9GO2bxOcL4xCT1wyf5k3KNvHwC4QnrJCWkh+jbvKIxWm8rBpqYf0JS39Zqz1la8VMwExIu4t9vHA8EKtMswnqSbSy9ZStvcQABQWK9JI6oiq4luo9vEzOZxClUV6qOurFG3fdyF39v/5nQHZgjokpGuNVVgxu9USRtCRtcoQg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KE2P2MgTEci9iS91KoGsWw2xVILmJR/3ga3o+SWCZ84=; b=y8LoB6OkKYqGOfe72N+GCTW+KVNiMF5NRmHH8QSGQO2V871bGk6Q3ks4qTVB0KnDdrZJcHLPqt63NUC0SHKweT5B90rmwSJUk6VjsxM/yTFdHt5CJ2nm7k7TX6wl+/eu4JMy0cOuzuBLwblz9ty/MRdpIaMyi8fWKpZwvxQQCYQ= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from DM4PR12MB5229.namprd12.prod.outlook.com (2603:10b6:5:398::12) by PH7PR12MB6540.namprd12.prod.outlook.com (2603:10b6:510:213::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5880.19; Mon, 12 Dec 2022 16:58:20 +0000 Received: from DM4PR12MB5229.namprd12.prod.outlook.com ([fe80::8200:4042:8db4:63d7]) by DM4PR12MB5229.namprd12.prod.outlook.com ([fe80::8200:4042:8db4:63d7%4]) with mapi id 15.20.5880.019; Mon, 12 Dec 2022 16:58:20 +0000 Message-ID: <0b50afd4-cf0c-a8fd-443f-88a0f615a0ed@amd.com> Date: Mon, 12 Dec 2022 10:58:17 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH 00/14] OvmfPkg: avoid global variables in PEI To: Gerd Hoffmann , devel@edk2.groups.io Cc: Bob Feng , Yuwei Chen , Erdem Aktas , Jordan Justen , Peter Grehan , Rebecca Cran , Liming Gao , Ard Biesheuvel , Jiewen Yao , Min Xu , Brijesh Singh , Oliver Steffen , Pawel Polawski , James Bottomley References: <20221202131009.3190040-1-kraxel@redhat.com> From: "Lendacky, Thomas" In-Reply-To: <20221202131009.3190040-1-kraxel@redhat.com> X-ClientProxiedBy: CH2PR10CA0014.namprd10.prod.outlook.com (2603:10b6:610:4c::24) To DM4PR12MB5229.namprd12.prod.outlook.com (2603:10b6:5:398::12) Return-Path: Thomas.Lendacky@amd.com MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM4PR12MB5229:EE_|PH7PR12MB6540:EE_ X-MS-Office365-Filtering-Correlation-Id: f7e22b5e-da3b-4142-6c08-08dadc62122a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: h4KcrDlv/JAVRnoR9XkEvUJiSRXvS9XsYnMW/coW0q6gkoJaD71NusUsy6dia59DgwSSX/3NzH5gOjRIqluSkM9OUnqBLk/kLisQvvBSc3x1ad1CP+uwys46V7GYjrDLCpdpRGmonuJbxW3QiYb7abt41FnrfpDM07Gzm19t1jWapAR92J+SoxF1d4bpzYQp9LhUtucQ8hLcYx4FF2kHhNhMw+s5K+YRTd2l6jsGYKIs0NTP1DGTiDeDL65rp+6nnBK92HqvtshzkjPhb4ouLontHJMu9UJrieXshPGKWdykAG68UfgLMyMXEviqqhyZo1V5JcqN4sLLAHTTTHPMO9xmf4EtRH6WnNbfcOnGgGYUeNTCTnOD0yEiL7YeDGby98Bl8lBW3D6SiBRvfVpcdrXa1xlAk3Xeb4vWZLfLIkFi18rNtvGYk1nyVivI3HCVqocE8e0CapZg1nn9/bW2mUexe/8mTfNuiCo9ZeDoXw0/ARhSbQcFpydEciUHhY6ZqqZ3Ph0YRAWfixdnp9q31weh5usWX9IIwE6ti1s7ctChO65EYOR3gCx0GzhehO4GNW3ppv42ZvlhvbjdyQSyx6e50qa+/maDhpqD7yDAlGbNpxjuHaSu43zb9xTkGnHUMJTx0Qzz0zas0iVnl21QvbRg6t3AL9sKdPbscO9Wso3uyK41YqUMcKn7MPNrfFcLBSnH5t5uUpZEfAiP7IloYNUr/jZJFf4B97PCOhV3ZLY= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM4PR12MB5229.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(39860400002)(366004)(136003)(346002)(376002)(451199015)(31686004)(66476007)(2906002)(86362001)(54906003)(31696002)(83380400001)(2616005)(36756003)(5660300002)(4326008)(8936002)(7416002)(38100700002)(19627235002)(66556008)(316002)(8676002)(66946007)(41300700001)(6486002)(53546011)(186003)(6506007)(6512007)(478600001)(26005)(6666004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SXRLbWgrbkphT29LL3p0SVQ3R1RYYytMVHluRzVweXVXalpEMWdtb3luTVBh?= =?utf-8?B?K0pNTzVsTzZXeWliTGJuR0swSXRFeDZpdnFQQnBzYk80dHdRVG1mczlMU1RL?= =?utf-8?B?YzFXNVczbWdpbTdWdVViK2lpb05MenNMYVdlTzVtc0tqWGJ6VzhhK2l3R0dP?= =?utf-8?B?TFRBQnJtTE5VZDZmZzRGcm5XdkU2TVZpKzJiZFRYbDBjSEJKUXpWTk4zLzBm?= =?utf-8?B?a2x1U1BWNk5WUXhrejBhd3YvbnlJL1VjN0ZCa25OajJpcWpBaysxYmtOaTNn?= =?utf-8?B?NGVWYk5sTzRzTzU3UUpOZnl6azdlazF0aURXTnNzMTE3YXFwZEx0di9HY2RW?= =?utf-8?B?T1RPU05jMlB5TUw2SUVHd1lpZzhrcDRpNEFhK2M1RUtTYnppN29jbkJudHdF?= =?utf-8?B?RUovVGRRVHdIZWpTdDdTbnF2MytaSXAxV05PQVE5VGFTOWNzazNEQXVrbGlG?= =?utf-8?B?VFo4U1dCamNqQmVXUzNOQzZuMlIwNzl1ZFIyb0wzd0NyRUI3dW1PNjhzSVF3?= =?utf-8?B?R1NtMDc4QzBoTHM1L1l6Y01UcFNMZTVoOUo3SzIrOFVIS1UrUXJFR1p4dEZB?= =?utf-8?B?ZGt5TlNjSUhzWmdBd2tNYnFWYnFtczRlVlJ6RnNTaDRUNHY0ZW9vTEpVUUlL?= =?utf-8?B?TmpVTENrZklIVWdRaU1lY1FZLzJBVS9xZVlFM3JFa0s4K3JpL3ZrNnJORnNR?= =?utf-8?B?UlRRY29VeGsxbS9iQlZucnBWSmdIV3NkbjFKOXBiN0IvbEs3MmFtaFRieERv?= =?utf-8?B?Y1Jhd2YzeVh1eWZ4bDFpUVRHVnhSeEIzc21BekJvSXhHRWNxbFpCQ08rUmlV?= =?utf-8?B?WFJtTEphSFNxZzdHNm1rSGN6Mjd4aDlxNmt6R1pGeWo3VGJGZXNxdkcvRzh5?= =?utf-8?B?Ri9NTXRmZW9qV2NVcU9nRnkyN05GOVhVTTJiUlVSNnJzcW0vT0VaMkNxMWIv?= =?utf-8?B?ME5CN1R2MkpPYkhYbDR6cXJHUlBLUXY2dUp2MDdTL1dQOW5WUE8rM3lRZU1W?= =?utf-8?B?ODJ4ZjVvQzh6SWpvYTQwdnJRN1hzTkNQZCtyV3JPUkExYnhobmdHWWphUWxh?= =?utf-8?B?alhHS3V1T3gvSis0UVZMYVNwQVVJTnUzRjlqMk1YajBBVlJmVE9RbnZ6bHA0?= =?utf-8?B?dUFtUlRsTHNLcjA2NDdOM1Z3RzArbWRqeEJKRDhxUWtwMVY3Y2owVmV6dWhh?= =?utf-8?B?YVN3S1JYMDhlaXZHNVlxQ2toM09YZ1JSTDRQOFpYbEt6Um50WCtubmJEa1Vl?= =?utf-8?B?SFVBTFkzWU9zY1ZWNkRha1RlWjAvQTRvQmVDSHhraHhBdWZyK3EzQktYUkR3?= =?utf-8?B?clU3M2hqQXg4M2RtS1JCZWJON2ZKTnYrRlBvYzdaM1NDMVZsSS9tNE9sTGZQ?= =?utf-8?B?cVVrTU8wdFV4UXNlQTYwbDFadXFvU2lmNzgxckFneUdUcXpLbHFaSCt5MXpn?= =?utf-8?B?K0tqSlBvcCtYaklJbEFJbUZjT2N2MlRWSG9vK2hhMUF2Z3ZTOXRTZ1NYdUxu?= =?utf-8?B?U28zWjZvSWM3T1NQVDF6Mmx5eXNaWjEySER3ZWpqR2hLV1NyNFdWU3djeDli?= =?utf-8?B?TDVoZGE4bjlNQmlJdlBZTm8yVGpSR3U1S2toaStvRUJlSkE3QlRvaitoak4y?= =?utf-8?B?KzZ0TUR1S2JOMDJVcVZvSmkyeEhIMGt4NDZ4WllLbkoxQnN6NG5mYlBuUnhz?= =?utf-8?B?eCtmZ1psNGJiTHRUeWVRTlZlam9FeWszYk5xVjRNdlhVWlQvbnBQQ0ZzOHli?= =?utf-8?B?UUpScUVNMHhRTm02bllabG1wVUlRM3A1OWpmV2F4VFl6elhOc3RQN1dOeHd4?= =?utf-8?B?NCtVRWxtUnI1dUdYSDVwbDIrYkhCMUpERldHQkJkdi9PZzZHQ3hvNXR5U3Bt?= =?utf-8?B?WFJ3d0UydmgrSDhWT21JcFZHWGJkb1FUKzJ0S2V0eEo2TU5CcXI4Z0U0MWpT?= =?utf-8?B?UjlIRy9BYjk1dW5iU0lNbWJ3UCszRFZqVmVMNVJQWDdKQU0wWDgwc1ZLdmZu?= =?utf-8?B?cXR2RkNSSS92WnpyaUlQTDdWbUZ4YnBObUpIRkJxNEhMZU9nK2R5Z3hTa1E4?= =?utf-8?B?Y1lQNXovRERELzU2ejlBYnc5V05IMEtVWE1wSS9WSGdNNEVqaXkvZXlFUDc2?= =?utf-8?Q?lez7i19OJT0Dr9cgB+9cEj3wh?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: f7e22b5e-da3b-4142-6c08-08dadc62122a X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5229.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Dec 2022 16:58:20.1489 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: YZb0fZJaeHAbENW+6QnddnQ8xU4ksOzuStt/d0ExTHmYDhEQf7UpxG9LitqJCGjVcMzy0+vppOdaRAShQ5ZMqQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB6540 Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 12/2/22 07:09, Gerd Hoffmann wrote: > Writing to global variables changes the PEI firmware volume which in > turn screws up firmware volume measurements. Fix OvmfPkg to avoid that, > for the most part by using the PlatformInfoHob instead. Boot tested SEV, SEV-ES and SEV-SNP guests without issues. For the series: Tested-by: Tom Lendacky > > Gerd Hoffmann (14): > tools_def: remove GCC_IA32_CC_FLAGS/GCC_X64_CC_FLAGS > tools_def: add -fno-omit-frame-pointer to GCC48_{IA32,X64}_CC_FLAGS > OvmfPkg/PlatformPei: AmdSev: stop using mPlatformInfoHob > OvmfPkg/PlatformPei: PeiFv: stop using mPlatformInfoHob > OvmfPkg/PlatformPei Q35 SMM helpers: stop using mPlatformInfoHob > OvmfPkg/PlatformPei: PeiMemory: stop using mPlatformInfoHob > OvmfPkg/PlatformPei: MemTypeInfo: stop using mPlatformInfoHob > OvmfPkg/PlatformPei: NoExec: stop using mPlatformInfoHob > OvmfPkg/PlatformPei: Verification: stop using mPlatformInfoHob > OvmfPkg/PlatformPei: remove mPlatformInfoHob > OvmfPkg/PlatformPei: remove mFeatureControlValue > OvmfPkg/DebugLibIoPort: use Rom version for PEI > OvmfPkg/QemuFwCfgLib: rewrite fw_cfg probe > OvmfPkg/QemuFwCfgLib: remove mQemuFwCfgSupported + > mQemuFwCfgDmaSupported > > OvmfPkg/AmdSev/AmdSevX64.dsc | 4 +- > OvmfPkg/Bhyve/BhyveX64.dsc | 4 +- > OvmfPkg/Microvm/MicrovmX64.dsc | 4 +- > OvmfPkg/OvmfPkgIa32.dsc | 4 +- > OvmfPkg/OvmfPkgIa32X64.dsc | 4 +- > OvmfPkg/OvmfPkgX64.dsc | 4 +- > .../PlatformRomDebugLibIoPort.inf | 2 +- > .../Library/QemuFwCfgLib/QemuFwCfgPeiLib.inf | 5 +- > OvmfPkg/Include/Library/PlatformInitLib.h | 6 + > OvmfPkg/PlatformPei/Platform.h | 18 +-- > OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgPei.c | 143 ++++++++++-------- > OvmfPkg/PlatformPei/AmdSev.c | 14 +- > OvmfPkg/PlatformPei/FeatureControl.c | 44 ++++-- > OvmfPkg/PlatformPei/Fv.c | 6 +- > OvmfPkg/PlatformPei/MemDetect.c | 56 +++---- > OvmfPkg/PlatformPei/MemTypeInfo.c | 4 +- > OvmfPkg/PlatformPei/Platform.c | 92 ++++++----- > BaseTools/Conf/tools_def.template | 6 +- > 18 files changed, 232 insertions(+), 188 deletions(-) >