From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (NAM12-MW2-obe.outbound.protection.outlook.com [40.107.244.70]) by mx.groups.io with SMTP id smtpd.web11.56458.1680273320074764409 for ; Fri, 31 Mar 2023 07:35:20 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@amd.com header.s=selector1 header.b=bbrhkP7x; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: amd.com, ip: 40.107.244.70, mailfrom: thomas.lendacky@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GE4bU5KRyKM9d/lbxzn7LGBAhRCtjzTkc21qpGfQq5ZcAwIue8oY+AXfSD+KDpbdoG31N/l4fauswqqOF1PeYvhSMktepwXK1n0RmWVpkRIPm8GL40oouGKiStkhdPZb1sUVutT2q6bVW0C1qXMBgTqxZ2NszvQxl2uzuhIuq9piivIumqzotvFqTt4aKNRaQwhRgvdsSFhg7FOEHYijFg487WdO6Ky2OkF5Bd0/zLD0zmGOYcdMmM0PKrdd2oMeS/OsNqi3TEv6dPQdm4k4ykZjZ/tYvLFZMjJgO+gX9mEL4cNgADhhrwrQ8GHsUPX88NbDQa/3CqgJUufRceQ+wQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=U/8i5sstHRLHZaBkcCJ1EEH4DLH93zVR8/yHFdMw7fc=; b=h5c4XK+3S5WqE7wsoyxUA353ofqSidpu1EVnUJqIL3bKOJJEphoPv5cDzAzVezQsT+GCPw+565G1Z55nPx1d6jZyo8ZrtK7XwYLcJeRTByQVk4KxOgAq8bCf7is/uRGCoenir6RMBjCPlzodBHzohBZVspkwrjMouGCA5abVGZAkZohh+a36JNAy6MPjYH5LBZn2fd3qXn7XTJhwWuNBsvVW/NCP3dggoj01DggkVQUjiFOX1ufj9twpseMMv3hdMvjFDMkxu+IODgMdzAPGwOuWwPg79Bv9nbbthTgI47QhVhcnhBD3MyUln5l6anx36UDLgJ4lr5FBji0kbkg38g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=U/8i5sstHRLHZaBkcCJ1EEH4DLH93zVR8/yHFdMw7fc=; b=bbrhkP7xO+FD+JYT8oVVB7RqxdbpNB5Cg64lY5C9SQhdX0IdDzKON6GsiuHD2p92ju78TnR94VCxnKyD7GXeBaR+oH5hfQ+/SxxGzmEfWFNfFS3TGy44NXoFUc7VKwhSS5ym7brGdGIAkoPsyb/c5lRVzwFUq25iMpCScJabWIQ= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from DM4PR12MB5229.namprd12.prod.outlook.com (2603:10b6:5:398::12) by DM4PR12MB8497.namprd12.prod.outlook.com (2603:10b6:8:180::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6254.24; Fri, 31 Mar 2023 14:35:18 +0000 Received: from DM4PR12MB5229.namprd12.prod.outlook.com ([fe80::5b56:bf13:70be:ea60]) by DM4PR12MB5229.namprd12.prod.outlook.com ([fe80::5b56:bf13:70be:ea60%5]) with mapi id 15.20.6254.022; Fri, 31 Mar 2023 14:35:18 +0000 Message-ID: <0b8cbd21-9c80-26cf-8934-c4df9158441d@amd.com> Date: Fri, 31 Mar 2023 09:35:16 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [edk2-devel] [Patch V2 0/8] Create page table by CpuPageTableLib in DxeIpl To: "Tan, Dun" , "devel@edk2.groups.io" Cc: "Ni, Ray" References: <17517763F19F09A0.27612@groups.io> From: "Lendacky, Thomas" In-Reply-To: X-ClientProxiedBy: SA9PR13CA0095.namprd13.prod.outlook.com (2603:10b6:806:24::10) To DM4PR12MB5229.namprd12.prod.outlook.com (2603:10b6:5:398::12) Return-Path: Thomas.Lendacky@amd.com MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM4PR12MB5229:EE_|DM4PR12MB8497:EE_ X-MS-Office365-Filtering-Correlation-Id: 15bc0268-8fc3-4e09-8dfe-08db31f5261c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: vfymbyIBsJKKOg+ArpsB2vARTwtW4z8VjSsNExtQJu9dDQAg+pk0bO3AsWo81oxfTZs6mcud6aqp73HHus+FWFfHM5eyX5ZPphLeJ0g2PMRjcPYwVFGn7nFF9QmF7iBdSr2MIbj9ht0lH8G0gAaD6aOsG2pmHecAiO0fkPFREmCoWp2yE0Xn47cQUOjGjyHx3Mle50jI0o/xDjhOlJisSBOj/LP9Og3qHL12eHBhVrj3uh+oyo61AkvUzUZUNfup9Y3B6wgLIKDhSI8KsfmW82nknTA53b+mzoutKVycsiyntZP6QTQ/Lsxm1nFWAxCJG1qNV14UGzAZI+tzv4WimpIYEOXvtMUnH/8gIOzc1oQ2s3qs711zjnEjkMlpm3fJUzkviksI2+Ahgeqxplyr8xlwGAh6pxxtxjlx88FQ+OW+XxotZsjVAVVkiVQqFH6pad6pWpYV6/bnIQL/ZGotwnQTi/rhaswL5nXpI9+LMwkxSgNFETFZfJMFYHxWAcPDxUffp3QkulXx8Mbp3KJ7oOtHKYCbmlyDxAzymmQcIKtvzhWhvwCLyT+0YnTWjLb7zjk+0G6juVIzyMvIqmAzYR+bfayTMmRzleOggRp3q/UzNqRzeE7yqaS8vE1zQvTk X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM4PR12MB5229.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(376002)(346002)(39860400002)(136003)(366004)(396003)(451199021)(31696002)(6486002)(966005)(86362001)(2616005)(66899021)(36756003)(186003)(26005)(6512007)(6506007)(53546011)(4326008)(316002)(8676002)(66946007)(66556008)(478600001)(66476007)(19627235002)(31686004)(2906002)(38100700002)(110136005)(5660300002)(8936002)(41300700001)(83380400001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WG90SHRrYVpqaCtmWm9EV21nY0RPQTlVUFNvMHBrbE01c2I2bkNLRzN1T0c0?= =?utf-8?B?OVNkRUxic2ZZWlF6VzFrYXY0MmdlK3RWSlprVUE5ckRJdDdKMmUrUWlaRXNJ?= =?utf-8?B?RFlKS1FPS2ZXVmtrTk5hOEhocU1vYjBUcUM3endoRlg4YUJ3ZUdnZ3JjcXhG?= =?utf-8?B?aVpNeVNaeUk5T1dybHgvK2tCdEFOU0ttejRzdzkvbG1Zdnd6QTFHc3NsOXpH?= =?utf-8?B?VE00c2J3cURST2F0bjNON1IrNG1JckVGUjdPajZwRVp6WFdwWEVIM1RnKzgr?= =?utf-8?B?OWx3Wmd5MldPeDQ2Q0xTczIzRU9pR3liYllwdjAwN2o3UUZuaGdHeHJqY1cw?= =?utf-8?B?d2loZE9pb21abjNOSTdPdGsxaGZocFhwUi9DYWVYbGJ5TGRJaTVROVhKYis2?= =?utf-8?B?dkJlaEpPTHpnWTZTWnorZWZta21INE5EMFJOeXBUUEo1OFMxZGx3dTZtWFhD?= =?utf-8?B?aEZVaXptZmNoS1VOYTNjcVNsM0syaFhEdGNoQ3hDMWFqMnJ1cmlLVkxMMG85?= =?utf-8?B?czQ5bStvTlJ5eGxQVnFjelo1OWQ0eU5hM3VMRmtNVFNGbmxnb0p1Tzl5Rk1E?= =?utf-8?B?NmFmenpTb2NiM2kzVjlqclc2L2dtSE1PQlhSSktmQ01WWXgyRDRGbU9uTHdL?= =?utf-8?B?UHFDdjZtSEl4Mms1ekdnQmg0aVJ6WWcvUStBRVorWStvWFdQYW9ncXA1K3ZI?= =?utf-8?B?bTFkSXZlb3MvRTNzWVZwWjJXdmx5Yzl1M0RrUnlHWUNESzk0SkhmMFV5V3RT?= =?utf-8?B?V05EUUZFUklhRjBXV2tyUWlhenJCOFQvTTBoVWRibjhTdnVaek9kZ2pLNFdF?= =?utf-8?B?eVpJSlJGbTNaeDhoN1lBb1ozb2dnSC9aVnM2RUdLYUJiaDJaMWtSNFlnQ2dk?= =?utf-8?B?NmthWmFpUlJnNDd5ZlgrU01hVGhyRGZETlAxWUtVRTVDcHRDSU1Ha3lDVVkx?= =?utf-8?B?QXNhZmZxLzMza1ZNaklGM292YVE1bFQ3SEZJWmE4MXJES0k3bGd5NXBoYkRs?= =?utf-8?B?RU43cVRyS0NnNlNpZUNVRXMwMS9lSzhwSEptNlV2QnpzZ1djUUV6b3BSVmg2?= =?utf-8?B?dDVrTGZmTmltQ0kxZWowYkZDM1gvRXdUYUM3WkRrWExFRitKWnRlQkt6L3pR?= =?utf-8?B?REs5V1laREdyWGhQckJLbXN5VDBmYTJJQ3pIcHJ0OHdFcmhJeXVBNFU5V3Bo?= =?utf-8?B?TGM2aFhMUkZ1TFFyaXREbGg4RHM2OUN2QVJSQm1IQUdmUlBxTlVnQzA5R3k0?= =?utf-8?B?eGEwVGpBTS9GVkdDRXFiRE1hdngzK2tkdTFFNE0vL3Q3eXdsbGRtZHRZaDZ5?= =?utf-8?B?QXJuZExmTlNueVdYUEpHQ3FhUTJrVVBOZ2hiTXpoSThORjNlT2IxZlI5TGha?= =?utf-8?B?dDJ5OVlWQnhmOEUrc2pmL3U0bjJPK0ZhRm9tY2k1dVN2OUcra0JZZGhwUEtL?= =?utf-8?B?d2JZQzBsbDhpOWtNYjYzdEV3U3VORjNGSWZGNVcvU3JHcC9xTUk0WFpBTU9O?= =?utf-8?B?Slp5OXp4ZFd6SWZ2RGR3MStuZGpLeTBaTXBHNVRDQzZjcVU1WVpMSkcyNzUv?= =?utf-8?B?bFRNQTZrUmJ1WjJiU2NsSFNqMWlVbnpuLzZtNS9PTktsV005c2hrRU5Sa29Q?= =?utf-8?B?S2JQb1BnbnNjWStRQkJTaS9RSE8vaU9YNzJPWGhNRUNaQkNpY0w5OFFrQWpr?= =?utf-8?B?b0p5VjBpeWZuR011YzdDOSs0Uks1cEU4Um5raE1ZbEx5MElkWGFsbG5RbzlG?= =?utf-8?B?Q3AydUFXelV1MU9RSWRqdVVqWXBTVERKUGw2Q1NqREg0VTFPUXlBY3Qwcjlp?= =?utf-8?B?RXFaVUxIU0RrM3hvOE1uVTRObGdQYnQxOHFlUzJEcVFTQ2FJVWIyMm8rdURX?= =?utf-8?B?UXpUNnd5OUdBTmFIekRnUForb3gzVU1ZcURWNmpoVGZUL3lUV3VwdDNkRUNZ?= =?utf-8?B?eXg1U096Skw4a3hVWUExd3BuQ1BrWWhURFFSSENvWE1kdHcwMWlVOVNQd3Vh?= =?utf-8?B?eUJiRjYyQlgxVHk1S0dUZTJaL0NzVEorV2N4Zmt3dFNzUWdXMkJld2pTN3Ez?= =?utf-8?B?UHM3WExScjMxTk5VcVRkWmcyUnBLVUhadzZhSit5Nzc3Tlh3U3Q5LzYxOWJD?= =?utf-8?Q?hO7k2N/7YeXpXxjpoNz6ClnWI?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 15bc0268-8fc3-4e09-8dfe-08db31f5261c X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5229.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Mar 2023 14:35:18.0926 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: aRJOoqO92QMj0cYPwli8yqTH5WbKvhMeqBJcN/J5McOaiz9AfHCc6x+gPUZptkZkeH0TWE3DQAnDtC9KhpZjnQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB8497 Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 3/31/23 04:41, Tan, Dun wrote: > Hi Tom, > > Reccentlly I sent this patch set to change DxeIpl code to use CpuPageTableLib to create page table. I have done some test on Intel CPU to make sure that the page table created by DxeIpl before the change is the same as the page table created by DxeIpl after the change. But there was a remaining case that I didn't cover. The case is that PcdPteMemoryEncryptionAddressOrMask, PcdGhcbBase and PcdGhcbSize are not zero(when memory encryption is enabled on AMD processors supporting the SEV feature). > So could you please help do a test on AMD processor to make sure that the SEV feature still works good with this pacth set? Yes, I can test it. Thanks, Tom > > Thanks, > Dun > > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of duntan > Sent: Friday, March 31, 2023 5:34 PM > To: devel@edk2.groups.io > Subject: [edk2-devel] [Patch V2 0/8] Create page table by CpuPageTableLib in DxeIpl > > In this V2 patch set: > 1.Remove the unneeded patch for ArmVirtPkg 2.In this patch 'Create page table by CpuPageTableLib', change the input parameter name from Is32BitPageTable to Is64BitPageTable and add a line of "MapAttribute.Bits.Present = 0" before set a range to non-present. > 3.In this patch 'Refinement to the code to set PageTable as RO', add a line of "MapAttribute.Bits.ReadWrite = 0" before set a range to ReadOnly. > > Dun Tan (8): > EmulatorPkg: Add CpuPageTableLib required by DxeIpl in DSC > IntelFsp2Pkg: Add CpuPageTableLib required by DxeIpl in DSC > MdeModulePkg: Add CpuPageTableLib required by DxeIpl in DSC > OvmfPkg: Add CpuPageTableLib required by DxeIpl in DSC file > MdeModulePkg: Add UefiCpuPkg.dec to pass DependencyCheck > MdeModulePkg/DxeIpl: Create page table by CpuPageTableLib > MdeModulePkg/DxeIpl: Remove duplicated code to enable NX > MdeModulePkg/DxeIpl: Refinement to the code to set PageTable as RO > > EmulatorPkg/EmulatorPkg.dsc | 3 ++- > IntelFsp2Pkg/Tools/Tests/QemuFspPkg.dsc | 3 ++- > MdeModulePkg/Core/DxeIplPeim/DxeIpl.h | 3 ++- > MdeModulePkg/Core/DxeIplPeim/DxeIpl.inf | 4 +++- > MdeModulePkg/Core/DxeIplPeim/Ia32/DxeLoadFunc.c | 112 ++++------------------------------------------------------------------------------------------------------------ > MdeModulePkg/Core/DxeIplPeim/X64/DxeLoadFunc.c | 5 +++-- > MdeModulePkg/Core/DxeIplPeim/X64/VirtualMemory.c | 711 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------ > MdeModulePkg/Core/DxeIplPeim/X64/VirtualMemory.h | 182 ++++++++++---------------------------------------------------------------------------------------------------------------------------------------------------------------------------- > MdeModulePkg/MdeModulePkg.ci.yaml | 5 +++-- > MdeModulePkg/MdeModulePkg.dsc | 3 ++- > OvmfPkg/AmdSev/AmdSevX64.dsc | 2 +- > OvmfPkg/Bhyve/BhyveX64.dsc | 3 ++- > OvmfPkg/CloudHv/CloudHvX64.dsc | 2 +- > OvmfPkg/Microvm/MicrovmX64.dsc | 2 +- > OvmfPkg/OvmfPkgIa32.dsc | 3 ++- > OvmfPkg/OvmfPkgIa32X64.dsc | 2 +- > OvmfPkg/OvmfPkgX64.dsc | 2 +- > OvmfPkg/OvmfXen.dsc | 2 +- > 18 files changed, 200 insertions(+), 849 deletions(-) > > -- > 2.31.1.windows.1 > > > > > >