From: "Isaac Oram" <isaac.w.oram@intel.com>
To: devel@edk2.groups.io
Cc: Isaac Oram <isaac.w.oram@intel.com>,
Sai Chaganty <rangasai.v.chaganty@intel.com>,
Nate DeSimone <nathaniel.l.desimone@intel.com>
Subject: [edk2-devel][edk2-platforms][PATCH V1 2/2] PlatformPayloadFeaturePkg/Build: Use MinPlatform PCD include
Date: Wed, 7 Sep 2022 20:48:49 -0700 [thread overview]
Message-ID: <0bc5d3b1e661578428910b1d60faa115b19a500d.1662608678.git.isaac.w.oram@intel.com> (raw)
In-Reply-To: <cover.1662608678.git.isaac.w.oram@intel.com>
Fix build issue from removed PCD and use MinPlatformFeaturesPcd.dsc.inc.
Cc: Sai Chaganty <rangasai.v.chaganty@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Signed-off-by: Isaac Oram <isaac.w.oram@intel.com>
---
.../PlatformPayloadFeaturePkg.dsc | 13 +++++--------
1 file changed, 5 insertions(+), 8 deletions(-)
diff --git a/Features/Intel/PlatformPayloadFeaturePkg/PlatformPayloadFeaturePkg.dsc b/Features/Intel/PlatformPayloadFeaturePkg/PlatformPayloadFeaturePkg.dsc
index 1b79e0039b..e36e5d6e1e 100644
--- a/Features/Intel/PlatformPayloadFeaturePkg/PlatformPayloadFeaturePkg.dsc
+++ b/Features/Intel/PlatformPayloadFeaturePkg/PlatformPayloadFeaturePkg.dsc
@@ -48,16 +48,13 @@
#
################################################################################
-#
-# Since there are no 32b libraries or components in this package, these PCD are specified for 64b only
-#
-[PcdsFeatureFlag]
#
- # PCD needed for MinPlatform build includes
+ # MinPlatform common include for required feature PCD
+ # These PCD must be set before the core include files, CoreCommonLib,
+ # CorePeiLib, and CoreDxeLib.
+ # Optional MinPlatformPkg features should be enabled after this
#
- gMinPlatformPkgTokenSpaceGuid.PcdSmiHandlerProfileEnable |FALSE
- gMinPlatformPkgTokenSpaceGuid.PcdUefiSecureBootEnable |FALSE
- gMinPlatformPkgTokenSpaceGuid.PcdPerformanceEnable |FALSE
+ !include MinPlatformPkg/Include/Dsc/MinPlatformFeaturesPcd.dsc.inc
[PcdsPatchableInModule]
gEfiMdePkgTokenSpaceGuid.PcdReportStatusCodePropertyMask|0x7
--
2.36.1.windows.1
prev parent reply other threads:[~2022-09-08 3:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-08 3:48 [edk2-devel][edk2-platforms][PATCH V1 0/2] Fix build issues Isaac Oram
2022-09-08 3:48 ` [edk2-devel][edk2-platforms][PATCH V1 1/2] MinPlatformPkg/Include: Add PEI DevicePathLib instance Isaac Oram
2022-09-08 3:48 ` Isaac Oram [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0bc5d3b1e661578428910b1d60faa115b19a500d.1662608678.git.isaac.w.oram@intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox