From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id DB3E894179C for ; Thu, 2 May 2024 15:14:13 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=itlALNgmD3sPzgz6p7Y/zWbD3bXdhbVSeZrbxqw3E/k=; c=relaxed/simple; d=groups.io; h=DKIM-Filter:Message-ID:Date:MIME-Version:User-Agent:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240206; t=1714662852; v=1; b=3eCIlICd0IsAY13QYG2s4yxHT7EcxVKFuisf1+qVkHn7KKU8t/YimYWcxIetaaoM0p89UV5w 4LhWx441jKjOmbse176BtnxAibHwOnAoGlUy9i/n17xxMDu24JG+f5ikJhdT8dCiZYlqySIz9p6 JC2ihdd7uSrMpIB5itL7+LaoWDjmWn5vXU/D2Unp4MiKahXHqnFcldpoqKfPjyIqHaufO3zZCgI mnlBAggPv4lGzRL/akTd1YElrCzTcK/mkouW7DD1Y+mfbYVphQ4CQ8VZoi45YyWmUqteyKNJ6ai N6Fghq8M1lBvKydNStGDupb8Zjygvu+cORbEupzdmLsKA== X-Received: by 127.0.0.2 with SMTP id d3c3YY7687511xNIzKrWDPLS; Thu, 02 May 2024 08:14:12 -0700 X-Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web11.16301.1714662851642600698 for ; Thu, 02 May 2024 08:14:11 -0700 X-Received: from [10.6.0.181] (unknown [20.39.63.0]) by linux.microsoft.com (Postfix) with ESMTPSA id 95B96206B4F2; Thu, 2 May 2024 08:14:10 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 95B96206B4F2 Message-ID: <0bd6b8ca-e621-481d-8123-5d5f32053134@linux.microsoft.com> Date: Thu, 2 May 2024 08:14:09 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] Proposal to switch TianoCore Code Review from email to GitHub Pull Requests on 5-24-2024 To: devel@edk2.groups.io, ardb@kernel.org, michael.d.kinney@intel.com Cc: "rfc@edk2.groups.io" , Leif Lindholm , "Andrew Fish (afish@apple.com)" References: From: "Michael Kubacki" In-Reply-To: Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Thu, 02 May 2024 08:14:11 -0700 Resent-From: mikuback@linux.microsoft.com Reply-To: devel@edk2.groups.io,mikuback@linux.microsoft.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: mIkCSCJJvrRyFpXpggqDvYimx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=3eCIlICd; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=linux.microsoft.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io On 5/2/2024 5:37 AM, Ard Biesheuvel wrote: > On Wed, 1 May 2024 at 19:44, Michael D Kinney > wrote: >> >> Hello, >> >> I would like to propose that TianoCore move all code review from email >> based code reviews to GitHub Pull Requests based code reviews. >> >> The proposed date to switch would be immediately after the next stable >> tag which is currently scheduled for May 24, 2024. >> >=20 > +1 >=20 > Some kind of off-github reflector similar to rebecca's public inbox > [0] would be appreciated to at least be able to keep track of > different versions of a series exactly as they were submitted. One of > the things that annoys me about doing GitHub reviews is dealing with > PRs where the underlying branches gets updated through a force-push > and there is no way to find out what changed, and whether the existing > review comments are still in sync. >=20 > Would it be possible to require a separate PR for each revision of a > series, lock the underlying branch, and archive it for future > reference (if desired?) >=20 In order for this to be as intuitive and effective as possible, I=20 suggest we stick with conventional usage. A single PR allows: 1. A single place to track all of the changes to the contribution=20 including force pushes. 2. Clean (less cluttered) PR history where each unique contribution is=20 represented by a single PR. 3. References to the PR such as comments, other PRs, and GitHub issues=20 to automatically be reflected on the PR. This allows work related to the=20 PR such as tracking issue items, future bug fix PRs, etc. to be easily=20 found from the original PR. The consistent PR number is important as it allows data queries that=20 many other tools and GitHub workflows use to operate as expected. For=20 example, many scripts and applications use the GitHub REST API [0]=20 and/or GitHub GraphQL API [1] to query and present PR information. Logic=20 would be complicated everywhere sorting through PRs that are dead ends=20 to find if a PR is finally the last in a series, etc. Many off-the-shelf=20 tools would produce incorrect results. In addition, many tools and existing processes depend on a single PR=20 link to track the status of a code change. Whether in public bug=20 tracking tools or internal tools. That would produce stale links constantly= . It is possible to see force pushed diffs in a PR. For example, in this=20 PR [2], I force pushed several times. You can simply click=20 "force-pushed" or "Compare" on each force push to get a diff of the=20 force pushed changes. On a simple rebase, as is the case in the last=20 force push, the diff is empty and it reports the contents as identical. With this it is possible to easily see branch (and its commit details)=20 and checkout a specific push state using its respective commit hash. [0] https://docs.github.com/en/rest?apiVersion=3D2022-11-28 [1] https://docs.github.com/en/graphql/overview [2] https://github.com/tianocore/edk2/pull/4835 > [0] https://openfw.io/edk2-devel/ >=20 >=20 >=20 >=20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#118522): https://edk2.groups.io/g/devel/message/118522 Mute This Topic: https://groups.io/mt/105847510/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-