From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (NAM12-MW2-obe.outbound.protection.outlook.com [40.107.244.96]) by mx.groups.io with SMTP id smtpd.web10.51768.1681147509800900677 for ; Mon, 10 Apr 2023 10:25:10 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="no key for verify" header.i=@amperemail.onmicrosoft.com header.s=selector1-amperemail-onmicrosoft-com header.b=U66OnBHM; spf=pass (domain: os.amperecomputing.com, ip: 40.107.244.96, mailfrom: tinhnguyen@os.amperecomputing.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KDHOWbPy9qViivaWVoyHtyeNeuYm4Y0or4NMcEfxUqwECMvyhXFAxl3XQ9C3uUNRqF1waoNYGJw6kDBKwXtBLdKG8NJEMo+Yyr1aOkkegoiibeN91NoBUm77zJ6Uy98RcFocGNQkE72JHcMyUYujM3yyXkK+cbaFcD1CRNNCmkfXkzdgt6HuGfAoarpgFsNOfs0smiLH25gpdGnBzHZJoSWv0ntuChldxFZ4sKxhKkthXRtqu8tfr8kbWQPZ9jRQNs5/k3aQpzdI+3w0ZlRiUCBw1k/4kGl+QIrux863uka2RR3ABMp+hk2iRDXQDLcfZfdftWYcFWE2l8wFsIqqBw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cGLT6BY7BNSG+OkR+0/oteaCAYFBlktBF7r2oVPxuAc=; b=Mx7MSz/fotiE1hkUOQf4W/uKjY/QBGXM+ZfmwK1WPNbLQp1XEs6Kyy/P+NzLk3Y12IbmKc+8FeqZKN+cJpmdI+rCro1USHZJE9mSiHT+1nXmDN/rfDBfykPWNstIrpP3cmSfDBIQ+aOq+XVlxad2TMFG6DsdzWvCuZlHzw6jt4u9UW6RvOcbpZfWVyfPRH6KDlrrbP9/AECTkhA0LyzO8Kl5ZXQMOt45jksCRUFczyOSNNR2Gt23hOW7MhiwgPY+esI/Yne8107P3ERsIMy+W5Q2nAI0hnN1DK398Y/9q5dSJI649q27VFovrK0/pXKFsRIbYsF/a3ONjUenCe0kgA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=os.amperecomputing.com; dmarc=pass action=none header.from=amperemail.onmicrosoft.com; dkim=pass header.d=amperemail.onmicrosoft.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amperemail.onmicrosoft.com; s=selector1-amperemail-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cGLT6BY7BNSG+OkR+0/oteaCAYFBlktBF7r2oVPxuAc=; b=U66OnBHMb7luLCkvgfebFaPjitWeXGy+wmOBebJAHUFSsFfGpSSFlRgHprPgG6aOxJuwcrMd7nx3XG39vqb3ZBY0Wo630hhiuWMnURGLLoptHqGTOjcAiASvJCAyCbkmznX0lQf52NlHuqXaHYZ5WCIkEPRaVHBEPJFndcYDGVo= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amperemail.onmicrosoft.com; Received: from DM5PR0102MB3336.prod.exchangelabs.com (2603:10b6:4:9f::11) by PH0PR01MB6554.prod.exchangelabs.com (2603:10b6:510:7b::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.25; Mon, 10 Apr 2023 17:25:07 +0000 Received: from DM5PR0102MB3336.prod.exchangelabs.com ([fe80::812c:e04f:eb2d:c1e]) by DM5PR0102MB3336.prod.exchangelabs.com ([fe80::812c:e04f:eb2d:c1e%6]) with mapi id 15.20.6298.021; Mon, 10 Apr 2023 17:25:07 +0000 Message-ID: <0be90c10-0784-7e77-1c98-1bafba38987a@amperemail.onmicrosoft.com> Date: Tue, 11 Apr 2023 00:25:00 +0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [edk2-devel] [edk2-platforms][PATCH 03/14] ManageabilityPkg: Fix Uncrustify errors To: devel@edk2.groups.io, abner.chang@amd.com Cc: Isaac Oram , Abdul Lateef Attar , Nickle Wang , Igor Kulchytskyy References: <20230403150459.925-1-abner.chang@amd.com> <20230403150459.925-4-abner.chang@amd.com> From: "Tinh Nguyen" In-Reply-To: <20230403150459.925-4-abner.chang@amd.com> X-ClientProxiedBy: SI2PR02CA0047.apcprd02.prod.outlook.com (2603:1096:4:196::14) To DM5PR0102MB3336.prod.exchangelabs.com (2603:10b6:4:9f::11) Return-Path: tinhnguyen@os.amperecomputing.com MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM5PR0102MB3336:EE_|PH0PR01MB6554:EE_ X-MS-Office365-Filtering-Correlation-Id: c797f768-e12e-44a5-4ff4-08db39e88772 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 2dHZMWS6z4EzFaXy1CXDXShDUaKCRyHrQZLN7QNG3Au27O27I+yN6xXFKhqVbiNHJnCXdY/JynWD0Ugdkt8kS7VEoh54mik+k+6Bkm4jidKiqL0TpcgjdGBAMcQCLpR4hSTvkXbJ9YtN6VQY9nNktprscC092azL7YeidOndaEaVg3HthjrKa3x6jjuJvj1ab70KeysY9ph4+YD7OF7qamiWcvIYMZKwNB14c4eRaLg9ZwkRY4TEaCxUalzYrng8ojFiwlVgGA71T9X9WTailn19o3c7agVP2pKjJ7TeL9XgjyRJazi4r4UAlmFqm4vG6hJW660b4D7HDEA224KMa2XPu9F1o+G32PntGOGwnD4oPvMBMo3dnrs0UYXU0f6OGPjzTXZ9rjwg8CcDfZxHUu7wQtCIfgLY2s+kwZwVlTOHdg0UcurQCW3IKh5JKMRj5vwl3/UFm3PmvbkTGp+XjIRK/1tBu5qYscTPizGb80ITi+7LBDQsVtnWOuGfAqyxae9FVnBKeTRhHqkdmqMatgy7Pla3O72hl9AKTnBNZrV4cr3WI5M6vR7OhVk3LbO02LMwzjCtiC1tbpWKrfD/ceEc4bGy9Ug8QDmih08FKEus27RefviFIJd3QRejqk9xJcCtXJinRxZfdCpxUNMm5Q== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM5PR0102MB3336.prod.exchangelabs.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(376002)(136003)(39850400004)(346002)(396003)(366004)(451199021)(42882007)(2616005)(83380400001)(54906003)(6666004)(186003)(478600001)(6486002)(26005)(6506007)(53546011)(6512007)(30864003)(2906002)(5660300002)(38100700002)(83170400001)(4326008)(41300700001)(66556008)(66476007)(66946007)(8936002)(31696002)(8676002)(316002)(31686004)(43740500002)(44824005);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dVB5SHlRdlU1L0gxSjlDbkFzTzVPSmYxVFNDQkhJWFFWenR6aDFuSXk1cmRS?= =?utf-8?B?MlRiYTloamdrQkJXYjR5bXF4UG9aYzZlTVA1OURSbUQwdjlQZ0xja3d2MmxK?= =?utf-8?B?K1R3d05YQnl2dEo3WEhYbXVIWDVyN1FjbWZobnUyTkRiSDZzY1BtVHQ4Z3lV?= =?utf-8?B?bEs0WGM0Qk8rdGRBRDRweUtNRlZrL05WenBnOUJMRzNHNmd5dHdpVWo4bGRw?= =?utf-8?B?MWpKY0FMT1d0VHJpa3E0VmRGSzV4NFRlK1NybldEVXBvdjYxdHBmKzJUc2tX?= =?utf-8?B?WFVJYnRsZ0RUbWRZbXpWWUhmUXZqeThBUEc0NU1OaVoya1R0eTVZajR6Umxt?= =?utf-8?B?VUppUHlrVkM1a1B4LzhNS0ZJRzFVYjE1cEMxZlhuTHJoQWI1TGdGU0R1RTVH?= =?utf-8?B?eEtydkpKc3ljL2pVdWJCUkl6WkZxOXZvRE1RVHhVNHBXN3VQSStKd2MwZzFw?= =?utf-8?B?bG5SOVBOTStBanU2dUxnT05ORFJseGx1aldYK0R2YW9KRnVKQUhDV2NvcGRa?= =?utf-8?B?b1ZobGdzMi92b3dtbXBZSzhKVS9PNDkzZGsxTldvMGdHS0VWMmtRRThncnRJ?= =?utf-8?B?V0NpRjNwUThTUHZUdzFCTjBHUVVJRi9UK1NyMEwrL2lFenIwWTVyaEpsOWNZ?= =?utf-8?B?VUVuek9kUFJjOXRoSkwycmo4ejN0Z3pKUkRpL2JKWjFvMGJWUHlZbjkxS1du?= =?utf-8?B?NDlaMXVNR2Z1aXR3cllrMWJxYnVtQkc5MzNuSmsra2hybmtIczB6RkpCRnNV?= =?utf-8?B?Z1h5a1ZYMWhsY05XcGRQMXNXZzllZit1TkNieXVZbjRvVFhNbmpIaGM4eDVz?= =?utf-8?B?OWlUbVdyTnBOZDJNWnZtRUdUY1ZNODNuOEhkdWxoTmp6YnJmb0ZRNmxWZEZD?= =?utf-8?B?T0xWZVZTL3B4eG5NSVJaRTJjU0x6eWlRSGJpOFZDcTdtMDM2aTFuMnpJVXB5?= =?utf-8?B?ZGNjbHdpVnhkTkdzT0Y4Sm04cXhoWTR4MmY0NlBYOTNld09tbTJtVXUxYzNl?= =?utf-8?B?TzJwaDVKRmM5QjhOS2ZkZzNyS1ZhRC9HOGJjRXM3dkRoQ1VTRXBQTWlheGpD?= =?utf-8?B?QmNIdUMwKytWRTJDMWhXK2FwQ3dTK3RMb0VYZnQxNktBdExpdURvc2ZJbFl6?= =?utf-8?B?YmUrbGRmQjlBejNaV2ZWUnU1UDhDZWQxZ04zaENTck1PVTVXbFFRbHpwT0k5?= =?utf-8?B?MDhtdG9DSUdVMUt4NUFRTnNqRFJ3NlY0dXgzVkdvK1NUbGp1ZGVXTHg3V2FH?= =?utf-8?B?SS9oNnlOOGVGaVJjN0MybE1VZlpmRVFqdzdVSE12dEFoWW94bGUya3hwNkJa?= =?utf-8?B?QUlqWXlYZFVUYnVnMCtCR0JidE9QMTNOUDFzTkZjVEh4TE0ycVl1WUJIcmJq?= =?utf-8?B?LzRYdnhWQXJ3dlFJYVorOTBKdUpHekoxQXc1bllsUGRER2xNR0kxeHVZOGxt?= =?utf-8?B?RW9iTVZ1UHdOUnNaQmRIK1BvZU1zdk5kU2Y4L2dLYXBqcGlTYWNMV0xIZmFY?= =?utf-8?B?Tm10SzVtcC9tbkQ1M1NuZ1d0aVhONlNwa3BXRGVGNXdDbjFyZHdacEVCd2kx?= =?utf-8?B?V0lVemV4S2loaWU1SVdBanlzcHZ0cmNvdzlvS0ZVa0xhUW5OUklTUWEyNFVo?= =?utf-8?B?WE45RytaTmxadjExR1JyUjVXbWl4Z1BUS0lNZmtmWHkySzl3ZW9yS0pDdGlK?= =?utf-8?B?cmx2TWI5S0hUa3MxcTcvU0tNM1hnY0xoZ3loVWYvckl5cVRiUSsvcGVORm5n?= =?utf-8?B?MFdWa2NqMGFXZEZva2Y5NnQxRnBPdjJ1TERMMUFxK3pYUGVaeGV4ek04ZitP?= =?utf-8?B?dERpM1BKQjk4ZHNYK3E4dW9FNnpYMnc2NnBob3cvZnV2dUcrb0NHdzFHcUJT?= =?utf-8?B?VnVxd0ZDVVd4aWFSVGFPRnVzYlJSRTJDdGdrd0k5dTd5K1ZtZmpTekFlZitz?= =?utf-8?B?YURHOTQxc0NBaGx4RUNMQXJRL1Bla0RGbkZyYzlmRE5CVk1mOGNLYlFDenFS?= =?utf-8?B?RW9ramxaKzB2K3dQVU9TZFJsSVVQMVVoWmdBWlRMR3FTbTRNNWJpZytsQWd6?= =?utf-8?B?ZVVsRFNBUkJDUHoxYTZhb2xxNTN0VnpHUldRb0VnZnFxMDJPS2pvUGRzS1Ri?= =?utf-8?B?TjdWT0Raeml1Mzhic2pvL1o5bjdhN3hMMVI4b1ZCQ01sc080S0dEWjFoZlpS?= =?utf-8?Q?bL3aLdSr59m6zcDGxdVZvKk=3D?= X-OriginatorOrg: amperemail.onmicrosoft.com X-MS-Exchange-CrossTenant-Network-Message-Id: c797f768-e12e-44a5-4ff4-08db39e88772 X-MS-Exchange-CrossTenant-AuthSource: DM5PR0102MB3336.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Apr 2023 17:25:07.5189 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: OTAc+5SNKB8zly4nNqogvuZWQn+P3eh4Yfo0NNbeCyBxiP3R2HhEY4Lt86H1LMaEffiJcLWzmypn+qJkt3wha5SsYCs7P4Y734SkRm2yPmM3Z+skECNgER1Rlpdns2N/ X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR01MB6554 Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Abner, I checked and found that some files were not formatted with uncrustify. Please run it for the whole package. You can append this commit to the of the series. On 4/3/2023 10:04 PM, Chang, Abner via groups.io wrote: > From: Abner Chang > > Fix Uncrustify errors of IPMI protocol > and KCS manageability transport library. > > Signed-off-by: Abner Chang > Cc: Isaac Oram > Cc: Abdul Lateef Attar > Cc: Nickle Wang > Cc: Igor Kulchytskyy > --- > .../Library/ManageabilityTransportLib.h | 8 ++-- > .../IpmiProtocol/Pei/IpmiPpiInternal.h | 10 ++--- > .../Dxe/ManageabilityTransportKcs.c | 6 ++- > .../Universal/IpmiProtocol/Dxe/IpmiProtocol.c | 4 +- > .../Universal/IpmiProtocol/Pei/IpmiPpi.c | 40 ++++++++++--------- > .../Universal/IpmiProtocol/Smm/IpmiProtocol.c | 7 ++-- > 6 files changed, 41 insertions(+), 34 deletions(-) > > diff --git a/Features/ManageabilityPkg/Include/Library/ManageabilityTransportLib.h b/Features/ManageabilityPkg/Include/Library/ManageabilityTransportLib.h > index ad6cd1a464..d86d0d87d5 100644 > --- a/Features/ManageabilityPkg/Include/Library/ManageabilityTransportLib.h > +++ b/Features/ManageabilityPkg/Include/Library/ManageabilityTransportLib.h > @@ -74,13 +74,13 @@ typedef UINT32 MANAGEABILITY_TRANSPORT_CAPABILITY; > /// Bit 0 > #define MANAGEABILITY_TRANSPORT_CAPABILITY_MULTIPLE_TRANSFER_TOKENS 0x00000001 > /// Bit 1 > -#define MANAGEABILITY_TRANSPORT_CAPABILITY_ASYNCHRONOUS_TRANSFER 0x00000002 > +#define MANAGEABILITY_TRANSPORT_CAPABILITY_ASYNCHRONOUS_TRANSFER 0x00000002 > /// Bit 2 - Reserved > /// Bit 7:3 - Transport interface maximum payload size, which is (2 ^ bit[7:3] - 1) > /// bit[7:3] means no maximum payload. > -#define MANAGEABILITY_TRANSPORT_CAPABILITY_MAXIMUM_PAYLOAD_MASK 0x000000f8 > -#define MANAGEABILITY_TRANSPORT_CAPABILITY_MAXIMUM_PAYLOAD_BIT_POSITION 3 > - #define MANAGEABILITY_TRANSPORT_CAPABILITY_MAXIMUM_PAYLOAD_NOT_AVAILABLE 0x00 > +#define MANAGEABILITY_TRANSPORT_CAPABILITY_MAXIMUM_PAYLOAD_MASK 0x000000f8 > +#define MANAGEABILITY_TRANSPORT_CAPABILITY_MAXIMUM_PAYLOAD_BIT_POSITION 3 > +#define MANAGEABILITY_TRANSPORT_CAPABILITY_MAXIMUM_PAYLOAD_NOT_AVAILABLE 0x00 > /// Bit 8:31 - Reserved > > /// > diff --git a/Features/ManageabilityPkg/Universal/IpmiProtocol/Pei/IpmiPpiInternal.h b/Features/ManageabilityPkg/Universal/IpmiProtocol/Pei/IpmiPpiInternal.h > index 7b6ab0f529..4b6bdc97a9 100644 > --- a/Features/ManageabilityPkg/Universal/IpmiProtocol/Pei/IpmiPpiInternal.h > +++ b/Features/ManageabilityPkg/Universal/IpmiProtocol/Pei/IpmiPpiInternal.h > @@ -17,11 +17,11 @@ > #define MANAGEABILITY_IPMI_PPI_INTERNAL_FROM_LINK(a) CR (a, PEI_IPMI_PPI_INTERNAL, PeiIpmiPpi, MANAGEABILITY_IPMI_PPI_INTERNAL_SIGNATURE) > > typedef struct { > - UINT32 Signature; > - MANAGEABILITY_TRANSPORT_TOKEN *TransportToken; > - MANAGEABILITY_TRANSPORT_CAPABILITY TransportCapability; > - UINT32 TransportMaximumPayload; > - PEI_IPMI_PPI PeiIpmiPpi; > + UINT32 Signature; > + MANAGEABILITY_TRANSPORT_TOKEN *TransportToken; > + MANAGEABILITY_TRANSPORT_CAPABILITY TransportCapability; > + UINT32 TransportMaximumPayload; > + PEI_IPMI_PPI PeiIpmiPpi; > } PEI_IPMI_PPI_INTERNAL; > > #endif // MANAGEABILITY_IPMI_PPI_INTERNAL_H_ > diff --git a/Features/ManageabilityPkg/Library/ManageabilityTransportKcsLib/Dxe/ManageabilityTransportKcs.c b/Features/ManageabilityPkg/Library/ManageabilityTransportKcsLib/Dxe/ManageabilityTransportKcs.c > index 25d6e49886..91d3517bdb 100644 > --- a/Features/ManageabilityPkg/Library/ManageabilityTransportKcsLib/Dxe/ManageabilityTransportKcs.c > +++ b/Features/ManageabilityPkg/Library/ManageabilityTransportKcsLib/Dxe/ManageabilityTransportKcs.c > @@ -221,7 +221,7 @@ KcsTransportTransmitReceive ( > EFI_STATUS Status; > MANAGEABILITY_IPMI_TRANSPORT_HEADER *TransmitHeader; > > - if (TransportToken == NULL || TransferToken == NULL) { > + if ((TransportToken == NULL) || (TransferToken == NULL)) { > DEBUG ((DEBUG_ERROR, "%a: Invalid transport token or transfer token.\n", __FUNCTION__)); > return; > } > @@ -298,6 +298,7 @@ AcquireTransportSession ( > DEBUG ((DEBUG_ERROR, "%a: Fail to allocate memory for MANAGEABILITY_TRANSPORT_KCS\n", __FUNCTION__)); > return EFI_OUT_OF_RESOURCES; > } > + > KcsTransportToken->Token.Transport = AllocateZeroPool (sizeof (MANAGEABILITY_TRANSPORT)); > if (KcsTransportToken->Token.Transport == NULL) { > FreePool (KcsTransportToken); > @@ -346,9 +347,10 @@ GetTransportCapability ( > OUT MANAGEABILITY_TRANSPORT_CAPABILITY *TransportCapability > ) > { > - if (TransportToken == NULL || TransportCapability == NULL) { > + if ((TransportToken == NULL) || (TransportCapability == NULL)) { > return EFI_INVALID_PARAMETER; > } > + > *TransportCapability = 0; > return EFI_SUCCESS; > } > diff --git a/Features/ManageabilityPkg/Universal/IpmiProtocol/Dxe/IpmiProtocol.c b/Features/ManageabilityPkg/Universal/IpmiProtocol/Dxe/IpmiProtocol.c > index c30132419d..40587a07af 100644 > --- a/Features/ManageabilityPkg/Universal/IpmiProtocol/Dxe/IpmiProtocol.c > +++ b/Features/ManageabilityPkg/Universal/IpmiProtocol/Dxe/IpmiProtocol.c > @@ -100,12 +100,14 @@ DxeIpmiEntry ( > DEBUG ((DEBUG_ERROR, "%a: Failed to acquire transport interface for IPMI protocol - %r\n", __FUNCTION__, Status)); > return Status; > } > + > Status = GetTransportCapability (mTransportToken, &TransportCapability); > if (EFI_ERROR (Status)) { > DEBUG ((DEBUG_ERROR, "%a: Failed to GetTransportCapability().\n", __FUNCTION__)); > return Status; > } > - TransportMaximumPayload = MANAGEABILITY_TRANSPORT_PAYLOAD_SIZE_FROM_CAPABILITY(TransportCapability); > + > + TransportMaximumPayload = MANAGEABILITY_TRANSPORT_PAYLOAD_SIZE_FROM_CAPABILITY (TransportCapability); > if (TransportMaximumPayload == (1 << MANAGEABILITY_TRANSPORT_CAPABILITY_MAXIMUM_PAYLOAD_NOT_AVAILABLE)) { > DEBUG ((DEBUG_INFO, "%a: Transport interface maximum payload is undefined.\n", __FUNCTION__)); > } else { > diff --git a/Features/ManageabilityPkg/Universal/IpmiProtocol/Pei/IpmiPpi.c b/Features/ManageabilityPkg/Universal/IpmiProtocol/Pei/IpmiPpi.c > index 0dda6d2d47..0a914e513c 100644 > --- a/Features/ManageabilityPkg/Universal/IpmiProtocol/Pei/IpmiPpi.c > +++ b/Features/ManageabilityPkg/Universal/IpmiProtocol/Pei/IpmiPpi.c > @@ -51,19 +51,19 @@ PeiIpmiSubmitCommand ( > IN OUT UINT32 *ResponseDataSize > ) > { > - EFI_STATUS Status; > - PEI_IPMI_PPI_INTERNAL *PeiIpmiPpiinternal; > - > - PeiIpmiPpiinternal = MANAGEABILITY_IPMI_PPI_INTERNAL_FROM_LINK(This); > - Status = CommonIpmiSubmitCommand ( > - PeiIpmiPpiinternal->TransportToken, > - NetFunction, > - Command, > - RequestData, > - RequestDataSize, > - ResponseData, > - ResponseDataSize > - ); > + EFI_STATUS Status; > + PEI_IPMI_PPI_INTERNAL *PeiIpmiPpiinternal; > + > + PeiIpmiPpiinternal = MANAGEABILITY_IPMI_PPI_INTERNAL_FROM_LINK (This); > + Status = CommonIpmiSubmitCommand ( > + PeiIpmiPpiinternal->TransportToken, > + NetFunction, > + Command, > + RequestData, > + RequestDataSize, > + ResponseData, > + ResponseDataSize > + ); > return Status; > } > > @@ -90,18 +90,19 @@ PeiIpmiEntry ( > MANAGEABILITY_TRANSPORT_ADDITIONAL_STATUS TransportAdditionalStatus; > MANAGEABILITY_TRANSPORT_HARDWARE_INFORMATION HardwareInformation; > > - PeiIpmiPpiinternal = (PEI_IPMI_PPI_INTERNAL *)AllocateZeroPool (sizeof(PEI_IPMI_PPI_INTERNAL)); > + PeiIpmiPpiinternal = (PEI_IPMI_PPI_INTERNAL *)AllocateZeroPool (sizeof (PEI_IPMI_PPI_INTERNAL)); > if (PeiIpmiPpiinternal == NULL) { > DEBUG ((DEBUG_ERROR, "%a: Not enough memory for PEI_IPMI_PPI_INTERNAL.\n", __FUNCTION__)); > return EFI_OUT_OF_RESOURCES; > } > - PpiDescriptor = (EFI_PEI_PPI_DESCRIPTOR *)AllocateZeroPool (sizeof(EFI_PEI_PPI_DESCRIPTOR)); > + > + PpiDescriptor = (EFI_PEI_PPI_DESCRIPTOR *)AllocateZeroPool (sizeof (EFI_PEI_PPI_DESCRIPTOR)); > if (PpiDescriptor == NULL) { > DEBUG ((DEBUG_ERROR, "%a: Not enough memory for EFI_PEI_PPI_DESCRIPTOR.\n", __FUNCTION__)); > return EFI_OUT_OF_RESOURCES; > } > > - PeiIpmiPpiinternal->Signature = MANAGEABILITY_IPMI_PPI_INTERNAL_SIGNATURE; > + PeiIpmiPpiinternal->Signature = MANAGEABILITY_IPMI_PPI_INTERNAL_SIGNATURE; > PeiIpmiPpiinternal->PeiIpmiPpi.IpmiSubmitCommand = PeiIpmiSubmitCommand; > > PpiDescriptor->Flags = EFI_PEI_PPI_DESCRIPTOR_PPI | EFI_PEI_PPI_DESCRIPTOR_TERMINATE_LIST; > @@ -116,18 +117,19 @@ PeiIpmiEntry ( > DEBUG ((DEBUG_ERROR, "%a: Failed to acquire transport interface for IPMI protocol - %r\n", __FUNCTION__, Status)); > return Status; > } > + > Status = GetTransportCapability (PeiIpmiPpiinternal->TransportToken, &PeiIpmiPpiinternal->TransportCapability); > if (EFI_ERROR (Status)) { > DEBUG ((DEBUG_ERROR, "%a: Failed to GetTransportCapability().\n", __FUNCTION__)); > return Status; > } > > - PeiIpmiPpiinternal->TransportMaximumPayload = MANAGEABILITY_TRANSPORT_PAYLOAD_SIZE_FROM_CAPABILITY(PeiIpmiPpiinternal->TransportCapability); > + PeiIpmiPpiinternal->TransportMaximumPayload = MANAGEABILITY_TRANSPORT_PAYLOAD_SIZE_FROM_CAPABILITY (PeiIpmiPpiinternal->TransportCapability); > if (PeiIpmiPpiinternal->TransportMaximumPayload == (1 << MANAGEABILITY_TRANSPORT_CAPABILITY_MAXIMUM_PAYLOAD_NOT_AVAILABLE)) { > - DEBUG((DEBUG_INFO, "%a: Transport interface maximum payload is undefined.\n", __FUNCTION__)); > + DEBUG ((DEBUG_INFO, "%a: Transport interface maximum payload is undefined.\n", __FUNCTION__)); > } else { > PeiIpmiPpiinternal->TransportMaximumPayload -= 1; > - DEBUG((DEBUG_INFO, "%a: Transport interface for IPMI protocol has maximum payload 0x%x.\n", __FUNCTION__, PeiIpmiPpiinternal->TransportMaximumPayload)); > + DEBUG ((DEBUG_INFO, "%a: Transport interface for IPMI protocol has maximum payload 0x%x.\n", __FUNCTION__, PeiIpmiPpiinternal->TransportMaximumPayload)); > } > > TransportName = HelperManageabilitySpecName (PeiIpmiPpiinternal->TransportToken->Transport->ManageabilityTransportSpecification); > diff --git a/Features/ManageabilityPkg/Universal/IpmiProtocol/Smm/IpmiProtocol.c b/Features/ManageabilityPkg/Universal/IpmiProtocol/Smm/IpmiProtocol.c > index 86dee2fa24..41b9a10453 100644 > --- a/Features/ManageabilityPkg/Universal/IpmiProtocol/Smm/IpmiProtocol.c > +++ b/Features/ManageabilityPkg/Universal/IpmiProtocol/Smm/IpmiProtocol.c > @@ -107,12 +107,13 @@ SmmIpmiEntry ( > DEBUG ((DEBUG_ERROR, "%a: Failed to GetTransportCapability().\n", __FUNCTION__)); > return Status; > } > - TransportMaximumPayload = MANAGEABILITY_TRANSPORT_PAYLOAD_SIZE_FROM_CAPABILITY(TransportCapability); > + > + TransportMaximumPayload = MANAGEABILITY_TRANSPORT_PAYLOAD_SIZE_FROM_CAPABILITY (TransportCapability); > if (TransportMaximumPayload == (1 << MANAGEABILITY_TRANSPORT_CAPABILITY_MAXIMUM_PAYLOAD_NOT_AVAILABLE)) { > - DEBUG((DEBUG_INFO, "%a: Transport interface maximum payload is undefined.\n", __FUNCTION__)); > + DEBUG ((DEBUG_INFO, "%a: Transport interface maximum payload is undefined.\n", __FUNCTION__)); > } else { > TransportMaximumPayload -= 1; > - DEBUG((DEBUG_INFO, "%a: Transport interface for IPMI protocol has maximum payload 0x%x.\n", __FUNCTION__, TransportMaximumPayload)); > + DEBUG ((DEBUG_INFO, "%a: Transport interface for IPMI protocol has maximum payload 0x%x.\n", __FUNCTION__, TransportMaximumPayload)); > } > > mTransportName = HelperManageabilitySpecName (mTransportToken->Transport->ManageabilityTransportSpecification);