Re: [edk2-devel] [PATCH 3/3] UefiCpuPkg/PiSmmCpuDxeSmm: Remove trailing white space in SmmMp.h

["Laszlo Ersek" <lersek@redhat.com>]

On 07/30/19 10:37, Zhang, Shenglei wrote:
> Cc: Eric Dong <eric.dong@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
> ---
>  UefiCpuPkg/PiSmmCpuDxeSmm/SmmMp.h | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/SmmMp.h b/UefiCpuPkg/PiSmmCpuDxeSmm/SmmMp.h
> index e0d823a4b1c6..b95ed8c6f836 100644
> --- a/UefiCpuPkg/PiSmmCpuDxeSmm/SmmMp.h
> +++ b/UefiCpuPkg/PiSmmCpuDxeSmm/SmmMp.h
> @@ -24,7 +24,6 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
>    @retval EFI_SUCCESS             The number of processors was retrieved successfully
>    @retval EFI_INVALID_PARAMETER   NumberOfProcessors is NULL
>  **/
> -
>  EFI_STATUS
>  EFIAPI
>  SmmMpGetNumberOfProcessors (
> 

The patch looks good, but I wonder if we should call this empty line "trailing". It is not at the end of the file, and not at the end of a line. Perhaps:

  UefiCpuPkg/PiSmmCpuDxeSmm: keep function comment and declaration adjacent

(73 characters).

Anyway, I don't feel too strongly about this. Either way:

Reviewed-by: Laszlo Ersek <lersek@redhat.com>

Thanks
Laszlo