From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: redhat.com, ip: 209.132.183.28, mailfrom: lersek@redhat.com) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by groups.io with SMTP; Tue, 30 Jul 2019 07:11:29 -0700 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 42253307D915; Tue, 30 Jul 2019 14:11:29 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (unknown [10.36.118.39]) by smtp.corp.redhat.com (Postfix) with ESMTP id 40D005D971; Tue, 30 Jul 2019 14:11:28 +0000 (UTC) Subject: Re: [edk2-devel] [PATCH 3/3] UefiCpuPkg/PiSmmCpuDxeSmm: Remove trailing white space in SmmMp.h To: devel@edk2.groups.io, shenglei.zhang@intel.com Cc: Eric Dong , Ray Ni References: <20190730083732.1564-1-shenglei.zhang@intel.com> <20190730083732.1564-4-shenglei.zhang@intel.com> From: "Laszlo Ersek" Message-ID: <0c21ebab-374f-d53d-e477-f830ea278222@redhat.com> Date: Tue, 30 Jul 2019 16:11:27 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190730083732.1564-4-shenglei.zhang@intel.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.48]); Tue, 30 Jul 2019 14:11:29 +0000 (UTC) Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 07/30/19 10:37, Zhang, Shenglei wrote: > Cc: Eric Dong > Cc: Ray Ni > Cc: Laszlo Ersek > Signed-off-by: Shenglei Zhang > --- > UefiCpuPkg/PiSmmCpuDxeSmm/SmmMp.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/SmmMp.h b/UefiCpuPkg/PiSmmCpuDxeSmm/SmmMp.h > index e0d823a4b1c6..b95ed8c6f836 100644 > --- a/UefiCpuPkg/PiSmmCpuDxeSmm/SmmMp.h > +++ b/UefiCpuPkg/PiSmmCpuDxeSmm/SmmMp.h > @@ -24,7 +24,6 @@ SPDX-License-Identifier: BSD-2-Clause-Patent > @retval EFI_SUCCESS The number of processors was retrieved successfully > @retval EFI_INVALID_PARAMETER NumberOfProcessors is NULL > **/ > - > EFI_STATUS > EFIAPI > SmmMpGetNumberOfProcessors ( > The patch looks good, but I wonder if we should call this empty line "trailing". It is not at the end of the file, and not at the end of a line. Perhaps: UefiCpuPkg/PiSmmCpuDxeSmm: keep function comment and declaration adjacent (73 characters). Anyway, I don't feel too strongly about this. Either way: Reviewed-by: Laszlo Ersek Thanks Laszlo