From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182])
 by mx.groups.io with SMTP id smtpd.web11.120560.1680659502187021279
 for <devel@edk2.groups.io>;
 Tue, 04 Apr 2023 18:51:42 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@linux.microsoft.com header.s=default header.b=jrsy+aIy;
 spf=pass (domain: linux.microsoft.com, ip: 13.77.154.182, mailfrom: mikuback@linux.microsoft.com)
Received: from [192.168.4.22] (unknown [47.201.8.94])
	by linux.microsoft.com (Postfix) with ESMTPSA id D69C2210DEA5;
	Tue,  4 Apr 2023 18:51:40 -0700 (PDT)
DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com D69C2210DEA5
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;
	s=default; t=1680659501;
	bh=bJfC1X7tKSsL9Z8mCoV149P45cc5dmY9an3LmKODnfg=;
	h=Date:Subject:To:Cc:References:From:In-Reply-To:From;
	b=jrsy+aIyeIZP6NBR+viX2yeJxzjhF2zVZ+4AWy6yO1ln2n3SQ5Lrcmqay6Ja3j+iP
	 Af3vXZnbYIKd4UoyHNmuNBPx41P6h1pPepm8B8r2k8OBUeIzqP3Xg6XHZQrbhJFxpD
	 D4ZBZNFVZZxKQ6iYSV/K8Zs4ZQV4GS5GDVmHJc14=
Message-ID: <0c2474fa-7345-5040-421e-d06365f795fe@linux.microsoft.com>
Date: Tue, 4 Apr 2023 21:51:39 -0400
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.9.1
Subject: Re: [Patch v2 02/12] .pytool/CISettings.py: Add subhook submodule
To: Michael D Kinney <michael.d.kinney@intel.com>, devel@edk2.groups.io
Cc: Chris Johnson <chris.n.johnson@intel.com>,
 Sean Brogan <sean.brogan@microsoft.com>,
 Liming Gao <gaoliming@byosoft.com.cn>
References: <20230404182220.688-1-michael.d.kinney@intel.com>
 <20230404182220.688-3-michael.d.kinney@intel.com>
From: "Michael Kubacki" <mikuback@linux.microsoft.com>
In-Reply-To: <20230404182220.688-3-michael.d.kinney@intel.com>
Content-Language: en-US
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Reviewed-by: Michael Kubacki <michael.kubacki@microsoft.com>

On 4/4/2023 2:22 PM, Michael D Kinney wrote:
> From: Chris Johnson <chris.n.johnson@intel.com>
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4389
> 
> Add submodule for https://github.com/Zeex/subhook
> 
> This submodule is required to hook internal functions
> when using gmock.
> 
> Cc: Sean Brogan <sean.brogan@microsoft.com>
> Cc: Michael Kubacki <mikuback@linux.microsoft.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Signed-off-by: Chris Johnson <chris.n.johnson@intel.com>
> ---
>   .pytool/CISettings.py | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/.pytool/CISettings.py b/.pytool/CISettings.py
> index d87c8e838e61..e3f44add5834 100644
> --- a/.pytool/CISettings.py
> +++ b/.pytool/CISettings.py
> @@ -193,6 +193,8 @@ class Settings(CiBuildSettingsManager, UpdateSettingsManager, SetupSettingsManag
>               "BaseTools/Source/C/BrotliCompress/brotli", False))
>           rs.append(RequiredSubmodule(
>               "RedfishPkg/Library/JsonLib/jansson", False))
> +        rs.append(RequiredSubmodule(
> +            "UnitTestFrameworkPkg/Library/SubhookLib/subhook", False))
>           return rs
>   
>       def GetName(self):