From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.120]) by mx.groups.io with SMTP id smtpd.web10.2358.1587629115618793930 for ; Thu, 23 Apr 2020 01:05:15 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=BxOlTRIz; spf=pass (domain: redhat.com, ip: 207.211.31.120, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1587629114; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=h28/JJwz2KT6j1/s+YToNoigTv7Vw0DDAJx1BVQKUYY=; b=BxOlTRIzxd0u0/HYX5xC6Vq0KYVgIalYXHtfiv5M2ArNpVnhDzn0NEwD4ucfkXthAxA19Y n0wPyKdbvQvftl5Iu6kiYCOtCU+wDfsRKXIbm1uoNIIK3lBJEDsk3AVgq/2yc+OM8vFabY 1wZTbWoVS9KjIrmwm87SCTbwLmU5H8E= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-199-oxYVgLNwNq6FbpdD68DjOQ-1; Thu, 23 Apr 2020 04:05:10 -0400 X-MC-Unique: oxYVgLNwNq6FbpdD68DjOQ-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 2CC7113FB; Thu, 23 Apr 2020 08:05:09 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-114-95.ams2.redhat.com [10.36.114.95]) by smtp.corp.redhat.com (Postfix) with ESMTP id 55883385; Thu, 23 Apr 2020 08:05:07 +0000 (UTC) Subject: Re: [edk2-devel] [PATCH v3 3/6] OvmfPkg: Add VBE2 mode info structure to LegacyVgaBios.h To: devel@edk2.groups.io, rebecca@bsdio.com Cc: Jordan Justen , Ard Biesheuvel , Leif Lindholm , Michael Kinney , Andrew Fish , Peter Grehan References: <20200421030955.114850-1-rebecca@bsdio.com> <20200421030955.114850-4-rebecca@bsdio.com> From: "Laszlo Ersek" Message-ID: <0c309e68-7db6-3ea9-096e-ceaf2ac207b6@redhat.com> Date: Thu, 23 Apr 2020 10:05:06 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20200421030955.114850-4-rebecca@bsdio.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit On 04/21/20 05:09, Rebecca Cran wrote: > bhyve uses the older VESA BIOS Extensions 2.0, so add the mode info > structure to IndustryStandard/LegacyVgaBios.h > > Signed-off-by: Rebecca Cran > Acked-by: Laszlo Ersek > --- > .../Include/IndustryStandard/LegacyVgaBios.h | 38 +++++++++++++++++++ > 1 file changed, 38 insertions(+) Looks good, thanks; my A-b stands. Laszlo > diff --git a/OvmfPkg/Include/IndustryStandard/LegacyVgaBios.h b/OvmfPkg/Include/IndustryStandard/LegacyVgaBios.h > index 317dac3a56..38360a68b2 100644 > --- a/OvmfPkg/Include/IndustryStandard/LegacyVgaBios.h > +++ b/OvmfPkg/Include/IndustryStandard/LegacyVgaBios.h > @@ -86,6 +86,44 @@ typedef struct { > UINT32 MaxPixelClockHz; > UINT8 Reserved[190]; > } VBE_MODE_INFO; > + > +typedef struct { > + UINT16 ModeAttr; > + UINT8 WindowAAttr; > + UINT8 WindowBAttr; > + UINT16 WindowGranularityKB; > + UINT16 WindowSizeKB; > + UINT16 WindowAStartSegment; > + UINT16 WindowBStartSegment; > + UINT32 WindowPositioningAddress; > + UINT16 BytesPerScanLine; > + > + UINT16 Width; > + UINT16 Height; > + UINT8 CharCellWidth; > + UINT8 CharCellHeight; > + UINT8 NumPlanes; > + UINT8 BitsPerPixel; > + UINT8 NumBanks; > + UINT8 MemoryModel; > + UINT8 BankSizeKB; > + UINT8 NumImagePagesLessOne; > + UINT8 Vbe3; > + > + UINT8 RedMaskSize; > + UINT8 RedMaskPos; > + UINT8 GreenMaskSize; > + UINT8 GreenMaskPos; > + UINT8 BlueMaskSize; > + UINT8 BlueMaskPos; > + UINT8 ReservedMaskSize; > + UINT8 ReservedMaskPos; > + UINT8 DirectColorModeInfo; > + > + UINT32 LfbAddress; > + UINT32 OffScreenAddress; > + UINT16 OffScreenSizeKB; > +} VBE2_MODE_INFO; > #pragma pack () > > #endif >