From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 11513940F93 for ; Fri, 13 Oct 2023 02:20:48 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=scZ73KWqqhJHVGdkiRlZChuk+QTOBHjQOTIkTbsPo+w=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:Message-ID:Date:User-Agent:Subject:To:Cc:References:From:In-Reply-To:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1697163647; v=1; b=DETlfSeZ5/Rpr6XzLntO5KjIuKkC+fYzcUMkB5RvuSE/4ngLifGUe8K9FY521dBE/Ql6rh0W pMV5PqSQZC5i5uGQe+ouBhgLqhdsdmNwCbezK6IPAdyUAn1p4YV341EsDSR79/Gd/bvVzNVCh9I QWD0ZxvQCeqvoINPuROF471s= X-Received: by 127.0.0.2 with SMTP id WvbQYY7687511xXPhF8pNkpS; Thu, 12 Oct 2023 19:20:47 -0700 X-Received: from NAM10-BN7-obe.outbound.protection.outlook.com (NAM10-BN7-obe.outbound.protection.outlook.com [40.107.92.114]) by mx.groups.io with SMTP id smtpd.web10.30276.1697163646735269906 for ; Thu, 12 Oct 2023 19:20:47 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ze38xAfO7f8lwd8Qcr0jhbuGOW5RK09H8S3DyTaPfbXHv48FclP2v7lldIPLfX6qg2R0bKyexUmsJbGw2OW3ozygFnGk1e9tCpXb60bcPT6li2K71p/TbdHfhixRiPfKRNVm//SM6wyiLGZQdD82chCASFnh54rA79+JAuBWH+kvVezOdBxAs7b2dVvnTlY8paaUEtGiuD0cQoTenhcAY/jR4qaSar8poZmS3uO96nsI/DbNWdFgPnnrSQNADs120IDH1lV5BAew6P0LaUOn2cWeIx68AB7SSKyrHdPbgQw7yvaAbA5CSjG5iuaf+Z47ha15EA8bkyqPrk7SWB8kwQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=h0brA4Cqu1LWTkBfmmOSroQhRX5mmc8kDbWUiMfnvPg=; b=iWsSXYI6Savz32WlS6Qw635Cn+3l8CSxmx9qn8GuLIoY7dSDVoYRY8RIsU4Be3qz2WoWM7JbSZOSw6lptb/sVimtLIfcWty+kbM7cU3aqSUAwJnWK7noOXhTIGs2yauvd43Y/1TfTRC49oa1g0jPMwHI3e7b02JDNE2DK2ncM12k6qz+/XoYHRne9z998KTRxSLqAk3p1KGa1sE1IQXUql21400Srng11XzqmrEg6sQUVEtVFiFphdSQp1SEzTz0c6TMr6C9c7MNjoVy2w9GafGI3hRkRywTBt2AQDrvUHwO04FpAd1NFHEGVeXF09fZ9tSpru6U5HxtXBqI+aTrFQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=os.amperecomputing.com; dmarc=pass action=none header.from=os.amperecomputing.com; dkim=pass header.d=os.amperecomputing.com; arc=none X-Received: from PH0PR01MB7287.prod.exchangelabs.com (2603:10b6:510:10a::21) by SA1PR01MB7312.prod.exchangelabs.com (2603:10b6:806:1f7::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6863.44; Fri, 13 Oct 2023 02:20:42 +0000 X-Received: from PH0PR01MB7287.prod.exchangelabs.com ([fe80::2237:1801:e15c:e8b7]) by PH0PR01MB7287.prod.exchangelabs.com ([fe80::2237:1801:e15c:e8b7%6]) with mapi id 15.20.6863.043; Fri, 13 Oct 2023 02:20:42 +0000 Message-ID: <0c983e60-e094-d1b1-fb20-aecd533a822e@os.amperecomputing.com> Date: Fri, 13 Oct 2023 09:20:34 +0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [edk2-devel] [edk2-platforms PATCH 12/19] AmpereAltraPkg/Ac01PcieLib: fix compilation error To: Laszlo Ersek , edk2-devel-groups-io Cc: Chuong Tran , Leif Lindholm , Rebecca Cran References: <687bbaf5-3c2b-6d27-44a5-d19541ce97bd@redhat.com> <20231012090950.108577-1-lersek@redhat.com> <20231012090950.108577-13-lersek@redhat.com> From: "Nhi Pham via groups.io" In-Reply-To: <20231012090950.108577-13-lersek@redhat.com> X-ClientProxiedBy: SG2PR01CA0149.apcprd01.prod.exchangelabs.com (2603:1096:4:8f::29) To PH0PR01MB7287.prod.exchangelabs.com (2603:10b6:510:10a::21) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR01MB7287:EE_|SA1PR01MB7312:EE_ X-MS-Office365-Filtering-Correlation-Id: b4700808-c120-4cf1-67ab-08dbcb92ff8c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Message-Info: Cj0DWWvKE74Ib1FgzOB8hmP+UMppUUJ7fon66FzzQLQEFFwZ+WWDksDHFz2FHMMQxozck1tC9DU6CuLJWu0Km1PgpEXhi2a3b5Iwmn2KJSEmzl0bWoWm+r5RZOOBgecFwtH6IwTDq62ES+cl4g7PZDXM4ojuoRRt0COG7wLmVTNGPNZoT+Z0v54/mWJI/x/1+rg1txQ8nuielqzmHGXXpkNTKFUqd50HpntNIT8UC2j7E7wwFf13tvoFxCW2fguqYfPlynsMRB665yEuFS6DNKbKuK1SpKu3wAJ3CXBaDiHgbVFLIXTqV5vRp6V5MqSndBQXgCh0IsbM8kcDacA9XMGbxhhnUcSyHh1O+n0seJXCy91kwMmF8xWJhXNeTvGZqxCV5MpnleNQ4LWDNwkfRk+OduC0ggl4li7WkQQu1h9JekjOmO6EVXFIdiV6X/0rdcWwwePZVZaprTpuzJWtZSDGFASlwwZzYnxO5Eq7oodOui/TG0FVkTioX8ccZuyGbAtAEvCkw/Qu4xVfEkhbKcUdPhHIZUXcKjijUv4oqMNzSRAOMATcu4g4AmeB7PVOzoKMH4CyejdgSeDFli8s+S70alYJUl0T/RGM92W0BslVNCUuIEd1TyrKm7ep0RpuwRUbA4FMQUSWAB3dud027w== X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Rk1jWFdnZXh2M3VlcDdGNjRudXF2QWMwdGlVTlFnOVRXY0RRbURZR1VOOGYz?= =?utf-8?B?OGQvYUgyNTdtRzdDSFZ1bWVxVTB5b3ZuK1RwZTJlbDVNR215VUxHSDg5dG0z?= =?utf-8?B?anFqUG1rVDg1OTR4NHU3YVFLVDl2VnJSWVRwSndMNkhFVHNZM1VUWkxvejgw?= =?utf-8?B?VFY4UXB4VEVRSFFiVmVQYXFoc2plRkgyeWU5Q2hQS2pFUFE4MStjQk5JNUEz?= =?utf-8?B?OGlmNW9Ucmh5V3l5VTJzeE1mNU9SeDhYZU9OeTRmbmpVQmJzRHE4ZTloZkRR?= =?utf-8?B?bWR2NU8wUHdLZEU1OGxTVk5VdUVTMGoxcEFpOXJzK1Q5WUsrVVB0QkVuaGZ6?= =?utf-8?B?MmQ4U2YrMDJScmhpOGpBR1dZdXR1QUtlQnVNZzZQUTdiOVl2VXNJRHJXSzhI?= =?utf-8?B?akp3TFpGZUZPbUVGWnpMd2xHTE5PWVBjd3RKZnNrTmtlQ2R2eHVsSit0bTBQ?= =?utf-8?B?bzFadk5weG1sdTM5TUg0aTUzYU5MOXlIWmUwQUhwT1E3SEhUNWJMNUMvcVcw?= =?utf-8?B?aVAzT1FMYXN1cllGRHltZERLRDI2d21iUldkK2d6SzhXTFhZZldxSWNLMVkx?= =?utf-8?B?RjFLYWNEMFE1RUI0LzZwSHpxWCtDRXRwVmJmdVVXZFkxT0VpV1NEWSticDVt?= =?utf-8?B?dVJ2dUdYeFlBbkZMMmsvOGUzYVU1b1IxOXJMR3Erb3RlS25xK25OdGdEOWVq?= =?utf-8?B?cVJwV0ZSRG9HRnVTY1lpMjh1TXJLUFp0Z2VJZW1JQkJicXpPTzNuU0lqSlJE?= =?utf-8?B?ajdHS3JZTmU2cHdZRGRDUGY3c2svZG1Fc0hvV0ZEYnEzOUcyWE9NTVBYMXJ0?= =?utf-8?B?WUtsNWMzQjdXcmYzMkdJc1NJakx4a29ob3Q0NUNEMmh2ZXNSdVFvblQ2K3JC?= =?utf-8?B?TkZ2VlZNS0FOQmFYakN2R3BJelZqL0lFODgzZzh2V3dZRXpOYk4zUjRHeHk1?= =?utf-8?B?ZnZuS25qNlBmMmp6VFZXTXU2eHlMeXQzZ29BZEF0VUZDUTBRQ1NmdTR5TEhs?= =?utf-8?B?dVZuRGZoT0hwRGlGRFVXWllRTW8yc1k5VDZFcmZ6VEY5ekxHL0dhdnR4ZjBQ?= =?utf-8?B?V3haKytzNVhmWExPd3QwSUYzSXR5M0hpUVU5TFRrRnRlenlzSmZOK3VLbmZJ?= =?utf-8?B?N3doOWh5T0Y1NytIUk02WWtXQmk4bWR6TUE0bDBUMms1Tll4b0J0VDEyaFoz?= =?utf-8?B?TEkzeWMrL2syVmc4YndjTUpWbnBISVZhMmJ0Vk9iWkdST0dzNzh4Z2tLTDI4?= =?utf-8?B?UlBleWsvOFR1a05IL1puY3U0ZHJ0WVB3TlZCYXk0eVVvNmdnK3c4OXMwamNq?= =?utf-8?B?UjN3RkxLU1E5aWxmV09hNFE1eDNoTWlWYk5QY1VqWCtPblhUTXcwTkc4U1Er?= =?utf-8?B?N0cvSkhLOEJieXVOT21zRk1GN3BRSWRITXI4N29FVTJJREVuWkY5MUlhOEF1?= =?utf-8?B?dUgvaEY5WTNNR0hleFk5dXFiRUIxY1U1cS9NTnhjbmY5MUZVWmdGOERHL2E1?= =?utf-8?B?ZmQrWG5JRGdsNi94cWxOU1VuUms1aFhRWkNmd1FTUHZDVVBkU0NGRWhNNHBo?= =?utf-8?B?ajZEZW1FMXlwQWFEcjE5ZkxhSy9SblcwRmhaeUtTVzJkT1oxb2dDT3pvbjJZ?= =?utf-8?B?QUhsczR6Wm5tR3NadkN5alBVTVRvZTBucEl3K3d3U01MZDVjMUg1cjd2cU5s?= =?utf-8?B?WmIwQms0QTBCc2JhbHdyKzVrUVdua05oTks2U3dPMHBhblZ2Vm5mcWthcmpp?= =?utf-8?B?UFRIWmduKzFKbWw2anVnYnpkQUNxdHBUdTNqWFZxVlFTS1FWTDljenRQRnZa?= =?utf-8?B?ZFdaUWxFc2RNMks3VkxrMXA3dDZjTXBrb29lY1RUdXB1dUdrNTlKQ1U5QXlz?= =?utf-8?B?K29PQXBzMGh1QjNvRXBxU3krVUN5VjhTS3hQcVBXOXBZMksrL3FzZTZSRW0x?= =?utf-8?B?TXRDTm1Ta01qV3JYV2lud1dTcVh5bEE4dFpZdlROYXVCTTgwUnoyRWVQNmNY?= =?utf-8?B?UlFhUU9PR3A0TGxwUEFwUnVEVGxTK21OQnN0SkhzR1VWdDR2SHd5KytCTlFG?= =?utf-8?B?QlNFQ25ydFZNcGVnR2tqbm94UFlrVXJFYW01NzZOemo5YTh0cTlTQ0N3NGhE?= =?utf-8?B?VkR5Rnp3dE1NWDhwejFjeGl1dm5Sa0tRRGlFVTF5YWl0cVl0ODcvdmxYbW81?= =?utf-8?B?akE9PQ==?= X-OriginatorOrg: os.amperecomputing.com X-MS-Exchange-CrossTenant-Network-Message-Id: b4700808-c120-4cf1-67ab-08dbcb92ff8c X-MS-Exchange-CrossTenant-AuthSource: PH0PR01MB7287.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Oct 2023 02:20:42.0044 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: n9b4NCYEptnkVTdWHP2aUcPk7qyWCpfijzkPn9u7qso4TsWnzjxbSQLxTljPISZLK84pDwVYmBkMqUvfYRa/OG0eVT6CRwje0EOEXE9hj3E= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR01MB7312 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,nhi@os.amperecomputing.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: YpRt7jReuK7ai4WOD2rxlTzgx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=DETlfSeZ; dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Thanks for fixing it. Reviewed-by: Nhi Pham Regards, Nhi On 10/12/2023 4:09 PM, Laszlo Ersek wrote: > Commit 380b4b40c60d ("AmpereAltraPkg: Update Ampere specific platform PCI= e > core", 2023-03-29) removed the DEBUG macro call from > Ac01PcieCoreUpdateLink() that was the only reader of "Val". Since then, > Val has only been set, but never read. This triggers > "-Werror=3Dunused-but-set-variable". >=20 > Found when trying to build "Jade.dsc". >=20 > Keep the MmioRead32() call, so that the PCIe config space sees the same > behavior as before, but explicitly throw away the result. >=20 > Cc: Chuong Tran > Cc: Leif Lindholm > Cc: Nhi Pham > Cc: Rebecca Cran > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4564 > Signed-off-by: Laszlo Ersek > --- > Silicon/Ampere/AmpereAltraPkg/Library/Ac01PcieLib/PcieCore.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) >=20 > diff --git a/Silicon/Ampere/AmpereAltraPkg/Library/Ac01PcieLib/PcieCore.c= b/Silicon/Ampere/AmpereAltraPkg/Library/Ac01PcieLib/PcieCore.c > index 3c1fe5e35ca2..fa00c1e36999 100644 > --- a/Silicon/Ampere/AmpereAltraPkg/Library/Ac01PcieLib/PcieCore.c > +++ b/Silicon/Ampere/AmpereAltraPkg/Library/Ac01PcieLib/PcieCore.c > @@ -1747,7 +1747,6 @@ Ac01PcieCoreUpdateLink ( > PHYSICAL_ADDRESS CfgBase; > UINT8 PcieIndex; > UINT32 Index; > - UINT32 Val; > =20 > *IsNextRoundNeeded =3D FALSE; > *FailedPcieCount =3D 0; > @@ -1767,7 +1766,7 @@ Ac01PcieCoreUpdateLink ( > if (Pcie->Active && !Pcie->LinkUp) { > if (PcieLinkUpCheck (Pcie)) { > Pcie->LinkUp =3D TRUE; > - Val =3D MmioRead32 (CfgBase + PCIE_CAPABILITY_BASE + LINK_CONTRO= L_LINK_STATUS_REG); > + (VOID)MmioRead32 (CfgBase + PCIE_CAPABILITY_BASE + LINK_CONTROL_= LINK_STATUS_REG); > =20 > // Doing link checking and recovery if needed > Ac01PcieCoreQoSLinkCheckRecovery (RootComplex, PcieIndex); >=20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#109579): https://edk2.groups.io/g/devel/message/109579 Mute This Topic: https://groups.io/mt/101914660/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-