From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 5C61C21E87982 for ; Thu, 14 Sep 2017 01:19:17 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id B2FB080F75; Thu, 14 Sep 2017 08:22:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com B2FB080F75 Authentication-Results: ext-mx03.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx03.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=lersek@redhat.com Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-83.rdu2.redhat.com [10.10.120.83]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1178B619B8; Thu, 14 Sep 2017 08:22:13 +0000 (UTC) To: "Wang, Jian J" , "Justen, Jordan L" , "edk2-devel@lists.01.org" Cc: "Yao, Jiewen" , "Dong, Eric" , "Zeng, Star" , "Kinney, Michael D" , "Wolman, Ayellet" References: <20170913092507.12504-1-jian.j.wang@intel.com> <20170913092507.12504-2-jian.j.wang@intel.com> <150532368984.21662.15999032054940467421@jljusten-skl> <150537082712.13282.5148509677492264196@jljusten-skl> From: Laszlo Ersek Message-ID: <0ce6399f-5147-b48a-6729-d1768bf1e11b@redhat.com> Date: Thu, 14 Sep 2017 10:22:13 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Thu, 14 Sep 2017 08:22:15 +0000 (UTC) Subject: Re: [PATCH 1/4] MdeModulePkg/Core: Implement NULL pointer detection in EDK-II Core. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Sep 2017 08:19:17 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 09/14/17 08:51, Wang, Jian J wrote: > It's a tab character in old version. It may look like the same if > your tab width is to a certain number. In my editor, it looks > unaligned. Sometimes I just can't resist the temptation to fix the > tab:) I'll restore it to avoid irrelevant changes in next patch > update. It is perfectly fine (and even recommended, IMO) to fix up such warts whenever someone comes across them, but all such fixes should be separated out to their own dedicated patches. Thanks Laszlo