From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by mx.groups.io with SMTP id smtpd.web08.10051.1666275622829052079 for ; Thu, 20 Oct 2022 07:20:23 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=FhhcVTIp; spf=permerror, err=parse error for token &{10 18 %{ir}.%{v}.%{d}.spf.has.pphosted.com}: invalid domain name (domain: quicinc.com, ip: 205.220.180.131, mailfrom: quic_rcran@quicinc.com) Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 29KEJFa7022713; Thu, 20 Oct 2022 14:20:19 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=message-id : date : mime-version : from : subject : to : references : in-reply-to : content-type : content-transfer-encoding; s=qcppdkim1; bh=5ujsYsFlwPS2EwbOznXHp5xI+CIDNBLRx7nQkhy/v9Y=; b=FhhcVTIpkikihjFwyRx6vDwyU5RdBKDsVwJ9pF0/0DGkuvsh4LQtINLLpC2lNWZyED+y QvHDwESxdI5+lebX5odGBFIxEpQypXZclKlyhOljCZhWwqXiYUeWFoLh3GGWIcVyu/Af YKsEttTy1dTrJTXqrL3GgcuQOLiv210YfAANqIflFB0DGEGj0AXiKwW2gwci30Tc0BKH DNWqpOA4Bfn0dN5EZO5Vc2RMeJLfl8ukrEICKu44kg0qh/XF7yvIkPWO5PWtTuw0KUnR DL67Mvz9P5o/Z0DZpLWkRtS0Q4CuM0eBgDMn12w3StzBQsG+obuVXmtwsjfBiX04P4WD xQ== Received: from nasanppmta05.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3kb245gqrr-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 20 Oct 2022 14:20:19 +0000 Received: from pps.filterd (NASANPPMTA05.qualcomm.com [127.0.0.1]) by NASANPPMTA05.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTP id 29KEKISp023738; Thu, 20 Oct 2022 14:20:18 GMT Received: from pps.reinject (localhost [127.0.0.1]) by NASANPPMTA05.qualcomm.com (PPS) with ESMTPS id 3kb74409qg-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 20 Oct 2022 14:20:18 +0000 Received: from NASANPPMTA05.qualcomm.com (NASANPPMTA05.qualcomm.com [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 29KEKIJt023733; Thu, 20 Oct 2022 14:20:18 GMT Received: from nasanex01b.na.qualcomm.com (nasanex01b.na.qualcomm.com [10.46.141.250]) by NASANPPMTA05.qualcomm.com (PPS) with ESMTPS id 29KEKI5o023732 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 20 Oct 2022 14:20:18 +0000 Received: from [10.110.49.88] (10.80.80.8) by nasanex01b.na.qualcomm.com (10.46.141.250) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.29; Thu, 20 Oct 2022 07:20:17 -0700 Message-ID: <0cf2c0b2-3144-aad7-b9e3-15c5904a082d@quicinc.com> Date: Thu, 20 Oct 2022 08:20:16 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.3 From: "Rebecca Cran" Subject: Re: [PATCH v3 0/1] ArmPlatformPkg/PrePeiCore: Print the firmware version early in boot To: , Oliver Steffen , "Gerd Hoffmann" , Ard Biesheuvel , Sami Mujawar , Leif Lindholm References: <20221011205952.357499-1-rebecca@quicinc.com> In-Reply-To: <20221011205952.357499-1-rebecca@quicinc.com> X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nasanex01b.na.qualcomm.com (10.46.141.250) X-QCInternal: smtphost X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: 5SDzlDbJzQ1GXOy1K55eGZcWsCby6lRx X-Proofpoint-GUID: 5SDzlDbJzQ1GXOy1K55eGZcWsCby6lRx X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2022-10-20_05,2022-10-20_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 clxscore=1015 lowpriorityscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=897 adultscore=0 priorityscore=1501 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2209130000 definitions=main-2210200085 Content-Language: en-US Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit Could I get some reviews on this please? On 10/11/22 14:59, Rebecca Cran wrote: > Changes from v2 to v3: > > Fixed indentation that was causing Uncrustify to fail. > > Rebecca Cran (1): > ArmPlatformPkg/PrePeiCore: Print the firmware version early in boot > > ArmPlatformPkg/PrePeiCore/PrePeiCoreMPCore.inf | 3 +++ > ArmPlatformPkg/PrePeiCore/PrePeiCoreUniCore.inf | 3 +++ > ArmPlatformPkg/PrePeiCore/PrePeiCore.c | 14 ++++++++++++++ > 3 files changed, 20 insertions(+) >