Re: [edk2-devel] [PATCH V2] BaseTools:Added arch output to build report

["Philippe Mathieu-Daudé" <philmd@redhat.com>]

Hi Fan,

On 7/25/19 5:04 AM, Fan, ZhijuX wrote:
> From: Matthew Carlson <macarl@microsoft.com>
> 
> BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=2016
> 
> Added arch output to build report so it's easy to tell
> which arch is being generated. Useful when multiple versions
> of a single module is being emitted for multiple archs.
> 
> This patch is going to Added arch output

Your patch seems fine, but I don't understand what you mean in the
previous sentence, can you clarify please?

> 
> Cc: Bob Feng <bob.c.feng@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Signed-off-by: Zhiju.Fan <zhijux.fan@intel.com>
> ---
>  BaseTools/Source/Python/build/BuildReport.py | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/BaseTools/Source/Python/build/BuildReport.py b/BaseTools/Source/Python/build/BuildReport.py
> index a3eb3b2383..b4189240e1 100644
> --- a/BaseTools/Source/Python/build/BuildReport.py
> +++ b/BaseTools/Source/Python/build/BuildReport.py
> @@ -558,6 +558,7 @@ class ModuleReport(object):
>      def __init__(self, M, ReportType):
>          self.ModuleName = M.Module.BaseName
>          self.ModuleInfPath = M.MetaFile.File
> +        self.ModuleArch = M.Arch
>          self.FileGuid = M.Guid
>          self.Size = 0
>          self.BuildTimeStamp = None
> @@ -668,6 +669,7 @@ class ModuleReport(object):
>  
>          FileWrite(File, "Module Summary")
>          FileWrite(File, "Module Name:          %s" % self.ModuleName)
> +        FileWrite(File, "Module Arch:          %s" % self.ModuleArch)
>          FileWrite(File, "Module INF Path:      %s" % self.ModuleInfPath)
>          FileWrite(File, "File GUID:            %s" % self.FileGuid)
>          if self.Size:
>