From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: redhat.com, ip: 209.85.221.68, mailfrom: philmd@redhat.com) Received: from mail-wr1-f68.google.com (mail-wr1-f68.google.com [209.85.221.68]) by groups.io with SMTP; Thu, 25 Jul 2019 04:01:45 -0700 Received: by mail-wr1-f68.google.com with SMTP id g17so50300258wrr.5 for ; Thu, 25 Jul 2019 04:01:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=3hRJzgRBF8Om5eE6mqeppaJDq7GKQ8U2G0VDMykgd2I=; b=EOKF6WHXYk7/TtqDk3gWJWGRYifQJxlijKvgcgK69lmfGb6HBQ5U5ynzOJtQIUD5rJ jJM3QbSSuNjMI6djd/Qq9eeaYStkAayKOSYYGq7ZJlNAHYxaAZhVSPjelpqP1KrbWlej 0SWa0yn5Lm6rsK/4mCQKeAWSx4bdHfCPklGOT6Uom6BAB+JfLrDmVkWfZx+Z2d+1ZInh aidyaaNc4NMqv54PZOGwMYqQpjW2A2XJHXixlFetLe/MHteGsyplOD+BFlMEWFbgIeIT kMUXwTjunBpnzhIMVCZ9muKVLz6tvVEhwy1GDLPW6UabPQRQNUmHsBKKYR64hTIDS0IY xOjw== X-Gm-Message-State: APjAAAWkmLxxM3QBRltEPT6UmxsuA1cQLuLuQK/368kiUgaxbDfib0A3 4hq1nHzDCFdBBj223guV4GBrKg== X-Google-Smtp-Source: APXvYqwNECgVj9oMLj5unFsPhD4yrhLfW4RKTB4IOuyOcDVZxpb6KnFfcVVC+iDXVXb1SK66xoI8eg== X-Received: by 2002:a5d:6190:: with SMTP id j16mr83564wru.49.1564052504152; Thu, 25 Jul 2019 04:01:44 -0700 (PDT) Return-Path: Received: from [192.168.1.37] (190.red-81-40-121.staticip.rima-tde.net. [81.40.121.190]) by smtp.gmail.com with ESMTPSA id 91sm101498181wrp.3.2019.07.25.04.01.43 (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Thu, 25 Jul 2019 04:01:43 -0700 (PDT) Subject: Re: [edk2-devel] [PATCH V2] BaseTools:Added arch output to build report To: devel@edk2.groups.io, zhijux.fan@intel.com Cc: Matthew Carlson , Bob Feng , Liming Gao References: <20190725030432.18124-1-zhijux.fan@intel.com> From: =?UTF-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= Openpgp: id=89C1E78F601EE86C867495CBA2A3FD6EDEADC0DE; url=http://pgp.mit.edu/pks/lookup?op=get&search=0xA2A3FD6EDEADC0DE Message-ID: <0cf8d6be-ef65-1168-7dd9-4b82bc9a2a4d@redhat.com> Date: Thu, 25 Jul 2019 13:01:42 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: <20190725030432.18124-1-zhijux.fan@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Hi Fan, On 7/25/19 5:04 AM, Fan, ZhijuX wrote: > From: Matthew Carlson > > BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=2016 > > Added arch output to build report so it's easy to tell > which arch is being generated. Useful when multiple versions > of a single module is being emitted for multiple archs. > > This patch is going to Added arch output Your patch seems fine, but I don't understand what you mean in the previous sentence, can you clarify please? > > Cc: Bob Feng > Cc: Liming Gao > Signed-off-by: Zhiju.Fan > --- > BaseTools/Source/Python/build/BuildReport.py | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/BaseTools/Source/Python/build/BuildReport.py b/BaseTools/Source/Python/build/BuildReport.py > index a3eb3b2383..b4189240e1 100644 > --- a/BaseTools/Source/Python/build/BuildReport.py > +++ b/BaseTools/Source/Python/build/BuildReport.py > @@ -558,6 +558,7 @@ class ModuleReport(object): > def __init__(self, M, ReportType): > self.ModuleName = M.Module.BaseName > self.ModuleInfPath = M.MetaFile.File > + self.ModuleArch = M.Arch > self.FileGuid = M.Guid > self.Size = 0 > self.BuildTimeStamp = None > @@ -668,6 +669,7 @@ class ModuleReport(object): > > FileWrite(File, "Module Summary") > FileWrite(File, "Module Name: %s" % self.ModuleName) > + FileWrite(File, "Module Arch: %s" % self.ModuleArch) > FileWrite(File, "Module INF Path: %s" % self.ModuleInfPath) > FileWrite(File, "File GUID: %s" % self.FileGuid) > if self.Size: >