Re: [edk2-devel] [PATCH v2 20/30] OvmfPkg/LoongArchVirt: Add serial port library

["Chao Li" <lichao@loongson.cn>]

[-- Attachment #1: Type: text/plain, Size: 1162 bytes --]

Hi Gerd,

These two libraries is not only copy code, the way of obtain the serial 
base address is different from ARM, and the early serial port output 
also different from ARM, so these two libraries are LoongArch specific.


Thanks,
Chao
在 2023/11/7 17:47, Gerd Hoffmann 写道:
> On Mon, Nov 06, 2023 at 11:29:45AM +0800, Chao Li wrote:
>> Add two libraries named Fdt16550SerialPortHookLib and
>> EarlyFdtSerialPortLib16550, requested by LoongArch virtual
>> machine.
> Moving libs from ArmVirtPkg to OvmfPkg (so non-arm archs can use the
> libs too) is perfectly fine.  I think this should be done here instead
> of copying the code.
>
> I suspect the same applies to some of the following patches in this
> series (looked at the subject lines only so far though).
>
> take care,
>    Gerd
>
>
>
> 
>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#110833): https://edk2.groups.io/g/devel/message/110833
Mute This Topic: https://groups.io/mt/102413885/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



[-- Attachment #2: Type: text/html, Size: 2381 bytes --]