From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 111E4740038 for ; Tue, 7 Nov 2023 10:12:37 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=x6m+v8kO8fS5iNW0ubDk/m0xyTM2xUjdWOyLRbeed6s=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:User-Agent:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type; s=20140610; t=1699351956; v=1; b=muNi+ssShREnVLfyu8reds5jMYD1SrclsOl2xnr20WaIjty+Eoh1L8gid+pZoQy5CtgDE1rX 0+InI1rkx0iE1qeE1oMeOa5ZZ2lsyzah9+jKF2M6rJqzTV6J8tK0lOd5Ic/JqT9hXNDwEfP/0Iq BF80+842xuHII3PWAJUZXQvs= X-Received: by 127.0.0.2 with SMTP id CsSoYY7687511x8Pb3hVtwJe; Tue, 07 Nov 2023 02:12:36 -0800 X-Received: from mail.loongson.cn (mail.loongson.cn [114.242.206.163]) by mx.groups.io with SMTP id smtpd.web11.7065.1699351955379182658 for ; Tue, 07 Nov 2023 02:12:35 -0800 X-Received: from loongson.cn (unknown [10.40.24.149]) by gateway (Coremail) with SMTP id _____8BxyeqQDUplgKQ3AA--.34112S3; Tue, 07 Nov 2023 18:12:33 +0800 (CST) X-Received: from [10.40.24.149] (unknown [10.40.24.149]) by localhost.localdomain (Coremail) with SMTP id AQAAf8BxrdyPDUplkQU7AA--.62655S3; Tue, 07 Nov 2023 18:12:32 +0800 (CST) Message-ID: <0d008dd7-2622-4d8b-9ad6-d0381d797e47@loongson.cn> Date: Tue, 7 Nov 2023 18:12:31 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] [PATCH v2 20/30] OvmfPkg/LoongArchVirt: Add serial port library To: devel@edk2.groups.io, kraxel@redhat.com Cc: Ard Biesheuvel , Jiewen Yao , Jordan Justen , Xianglai Li References: <20231106032521.2251143-1-lichao@loongson.cn> <20231106032945.2285855-1-lichao@loongson.cn> From: "Chao Li" In-Reply-To: X-CM-TRANSID: AQAAf8BxrdyPDUplkQU7AA--.62655S3 X-CM-SenderInfo: xolfxt3r6o00pqjv00gofq/1tbiAQAICGVJnqlTbAAAsl X-Coremail-Antispam: 1Uk129KBj9xXoWruF45Kr4xur1DCr18KF4xZrc_yoWkZwb_Wr yDZF9rGr4DJFsFgw4qqryYgFZa9anxAr12q392qrsYyrW0ya1DZay3Jw1jgr1fJ3sxAr15 Gr93Kw1UZrnY9osvyTuYvTs0mTUanT9S1TB71UUUUUJqnTZGkaVYY2UrUUUUj1kv1TuYvT s0mT0YCTnIWjDUYxn0WfASr-VFAUDa7-sFnT9fnUUIcSsGvfJTRUUUbVAYFVCjjxCrM7AC 8VAFwI0_Jr0_Gr1l1xkIjI8I6I8E6xAIw20EY4v20xvaj40_Wr0E3s1l1IIY67AEw4v_Jr 0_Jr4l8cAvFVAK0II2c7xJM28CjxkF64kEwVA0rcxSw2x7M28EF7xvwVC0I7IYx2IY67AK xVWDJVCq3wA2z4x0Y4vE2Ix0cI8IcVCY1x0267AKxVW8Jr0_Cr1UM28EF7xvwVC2z280aV AFwI0_Gr1j6F4UJwA2z4x0Y4vEx4A2jsIEc7CjxVAFwI0_Gr1j6F4UJwAaw2AFwI0_Jrv_ JF1le2I262IYc4CY6c8Ij28IcVAaY2xG8wAqjxCEc2xF0cIa020Ex4CE44I27wAv7VC0I7 IYx2IY67AKxVWUAVWUtwAv7VC2z280aVAFwI0_Gr0_Cr1lOx8S6xCaFVCjc4AY6r1j6r4U M4x0Y48IcVAKI48JMx8GjcxK6IxK0xIIj40E5I8CrwCF04k20xvY0x0EwIxGrwCFx2IqxV CFs4IE7xkEbVWUJVW8JwCFI7km07C267AKxVWUXVWUAwC20s026c02F40E14v26r106r1r MI8I3I0E7480Y4vE14v26r106r1rMI8E67AF67kF1VAFwI0_JF0_Jw1lIxkGc2Ij64vIr4 1lIxAIcVC0I7IYx2IY67AKxVWUCVW8JwCI42IY6xIIjxv20xvEc7CjxVAFwI0_Jr0_Gr1l IxAIcVCF04k26cxKx2IYs7xG6r1j6r1xMIIF0xvEx4A2jsIE14v26r4j6F4UMIIF0xvEx4 A2jsIEc7CjxVAFwI0_Gr0_Gr1UYxBIdaVFxhVjvjDU0xZFpf9x07jjD73UUUUU= Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,lichao@loongson.cn List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 0ypwSfT8puKc6ZCggvZzOa3Px7686176AA= Content-Type: multipart/alternative; boundary="------------bOgwyYkiaMnObykCH3vtrlWQ" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=muNi+ssS; dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io --------------bOgwyYkiaMnObykCH3vtrlWQ Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi Gerd, These two libraries is not only copy code, the way of obtain the serial base address is different from ARM, and the early serial port output also different from ARM, so these two libraries are LoongArch specific. Thanks, Chao 在 2023/11/7 17:47, Gerd Hoffmann 写道: > On Mon, Nov 06, 2023 at 11:29:45AM +0800, Chao Li wrote: >> Add two libraries named Fdt16550SerialPortHookLib and >> EarlyFdtSerialPortLib16550, requested by LoongArch virtual >> machine. > Moving libs from ArmVirtPkg to OvmfPkg (so non-arm archs can use the > libs too) is perfectly fine. I think this should be done here instead > of copying the code. > > I suspect the same applies to some of the following patches in this > series (looked at the subject lines only so far though). > > take care, > Gerd > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#110833): https://edk2.groups.io/g/devel/message/110833 Mute This Topic: https://groups.io/mt/102413885/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=- --------------bOgwyYkiaMnObykCH3vtrlWQ Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 8bit

Hi Gerd,

These two libraries is not only copy code, the way of obtain the serial base address is different from ARM, and the early serial port output also different from ARM, so these two libraries are LoongArch specific.


Thanks,
Chao
在 2023/11/7 17:47, Gerd Hoffmann 写道:
On Mon, Nov 06, 2023 at 11:29:45AM +0800, Chao Li wrote:

Add two libraries named Fdt16550SerialPortHookLib and
EarlyFdtSerialPortLib16550, requested by LoongArch virtual
machine.

Moving libs from ArmVirtPkg to OvmfPkg (so non-arm archs can use the
libs too) is perfectly fine.  I think this should be done here instead
of copying the code.

I suspect the same applies to some of the following patches in this
series (looked at the subject lines only so far though).

take care,
  Gerd
_._,_._,_
Groups.io Links:

You receive all messages sent to this group.

View/Reply Online (#110833) | | Mute This Topic | New Topic
Your Subscription | Contact Group Owner | Unsubscribe [rebecca@openfw.io]

_._,_._,_
--------------bOgwyYkiaMnObykCH3vtrlWQ--