From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR02-VE1-obe.outbound.protection.outlook.com (EUR02-VE1-obe.outbound.protection.outlook.com [40.107.2.44]) by mx.groups.io with SMTP id smtpd.web08.7460.1651134299902279482 for ; Thu, 28 Apr 2022 01:25:00 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=ObWtdJw9; spf=pass (domain: arm.com, ip: 40.107.2.44, mailfrom: edward.pickup@arm.com) ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=c0rz0onhmV6zRe8kBpsev2BTQtFmXInXHjPitMJWF56L9kWh4vPfBg21yYq+IJJmG0XTPvDl2TY1ufWTe/fKzldaE/8vccF59oTBUU/gkvU4x2XLtIE/2ZohEYnZa3tglNcya2Ifw0BDOuRGsG6kL/XLJcm+L3kXXD3wkLdVNPWvoGZ+c2rjLYV9IJEa6jwWMFtY3snL30jDA+WHk1ARQGWXt+WCYsPOAZY72hFxXOVlT2/q/kV9/LehhXD3DpcvpWq3jVXNwE/0kgMrJIuLXxKmxP09NIH1pGuFdCa7iOFVblPjaKTefXt49COx3h9s+XFQtSJO4tkc9/tgtsc+Gg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=N3vYB3dV6lfsgia5PdqCKnDzDGEMl4FaQN8Agm9LIxA=; b=cDVVrmysEDnsiyAFaeUVW9ni+qAKDmMoaqUMaC0Nufmz4QlcILO0bGdiolXMn3cgK4hb9vizOBfZ3Zb3oD1cdwTI9sKSMmS2er6LQ2kexcMtwzr2oYUUSgNiZ0+zTdDfHi0ichfAQKioCbeVLl7LGTX8pPFeELPfqxsLu5BulnwMFGzt3pxM/d3IhG0AUcLg5ujpV7YvqRpd2CCyMKSuHcjJuUTh49UVYo1D/HWmTPo4INoK1zq4gkaLrfB89n8AcNUinhEHVfjisstiX9lgG72hyUVrho7U1CbSpCCm3oMG1kyxwSGKvHfhUhPXxrRs6Gs0n3T9q+bqsDCNDgKRiA== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=N3vYB3dV6lfsgia5PdqCKnDzDGEMl4FaQN8Agm9LIxA=; b=ObWtdJw9Lz7ksDTTTAZugIcqpUBgmHH9scMwAbxUuDSBT7Q1gM2dO28TJS4MsSlpz2o1Kku2JZP3DaBmVdS5dklkHjgFnoNXCd5kHAbrQAcRLPDprRSrEcX6MKrNNzaFfRFVO8FF9Tk/7sGZtqr60CqYsYSAc/aaOzSpnEeBKiw= Received: from DU2PR04CA0247.eurprd04.prod.outlook.com (2603:10a6:10:28e::12) by AM5PR0802MB2402.eurprd08.prod.outlook.com (2603:10a6:203:a1::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.12; Thu, 28 Apr 2022 08:24:52 +0000 Received: from DB5EUR03FT018.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:28e:cafe::72) by DU2PR04CA0247.outlook.office365.com (2603:10a6:10:28e::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.14 via Frontend Transport; Thu, 28 Apr 2022 08:24:52 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT018.mail.protection.outlook.com (10.152.20.69) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.12 via Frontend Transport; Thu, 28 Apr 2022 08:24:52 +0000 Received: ("Tessian outbound ac9bb5dd84f6:v118"); Thu, 28 Apr 2022 08:24:52 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 498c26792b81ef23 X-CR-MTA-TID: 64aa7808 Received: from fa268a644901.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id F0DB5502-68B0-4CCA-B03D-C67D83B81260.1; Thu, 28 Apr 2022 08:24:41 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id fa268a644901.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 28 Apr 2022 08:24:41 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=m40yXkehX/H9cWizwL2/VUSAt2Vm8WFqHgBc4Q5zmqArTkmYN6kESbOw3JVb6XYVs4hBpeu8IvIgfelgvs09flByPU3XoWkBgV9+8HzLIkkIM5fqRwaZxlL6g9HQkVuEsK/OuV9Z45qZHXnli/pvTFspCPz5wE0K2KKrIHz8N2jXp2xwAIIz9VRY+VHdup2u6XV3C/t3F6nJM1+ZTD7uNp1wohbGW3ymXU5QIRCtL8WRUyRmgPm1GRhNb/bobs7AAwFMjdATJq8Wg8J+/HDimfZalI9kcgB4LhB2s36HHP9RZtX0XgNog/U7UZLpfdCIo/u3BSdCVQMZQVThZtemCw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=N3vYB3dV6lfsgia5PdqCKnDzDGEMl4FaQN8Agm9LIxA=; b=AjAyGaR8fPwk8D3b5TL9PnptxSmaF7BZJV6mEcOi5CTwjFP+BihgZNs07CF79eJCrF8abQ+Y1RYVx9X5g9xGXuPE+lVPtVPcuUEuIjEgaTtGamzIHluykwIOPLsy2AeB3gXNjYUSRiJCeUP7Gd88lqaeT/oFtsJNBd/kSovEII04giqH20oMhQc1XDqiubkxI+G5NOnpJwgy0zVK5iZa1mlGllxXTwnG5O9xjcgJC/NNtccn5u3OWxSexQ5FSIWxip7ompbIKXHDOOsWlK+l+HwVS4bqrU1PQqBwXCiLXuSdd1N77h0aKAutVujEnnBRYAvZCJsOyL75Gun0RwTqTQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=N3vYB3dV6lfsgia5PdqCKnDzDGEMl4FaQN8Agm9LIxA=; b=ObWtdJw9Lz7ksDTTTAZugIcqpUBgmHH9scMwAbxUuDSBT7Q1gM2dO28TJS4MsSlpz2o1Kku2JZP3DaBmVdS5dklkHjgFnoNXCd5kHAbrQAcRLPDprRSrEcX6MKrNNzaFfRFVO8FF9Tk/7sGZtqr60CqYsYSAc/aaOzSpnEeBKiw= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from DB8PR08MB4153.eurprd08.prod.outlook.com (2603:10a6:10:a2::10) by DB9PR08MB6523.eurprd08.prod.outlook.com (2603:10a6:10:256::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.12; Thu, 28 Apr 2022 08:24:39 +0000 Received: from DB8PR08MB4153.eurprd08.prod.outlook.com ([fe80::6515:f2dc:241c:a61b]) by DB8PR08MB4153.eurprd08.prod.outlook.com ([fe80::6515:f2dc:241c:a61b%7]) with mapi id 15.20.5186.021; Thu, 28 Apr 2022 08:24:39 +0000 Message-ID: <0d0d9a8c-f90f-1e04-a759-d2b9be89eecc@arm.com> Date: Thu, 28 Apr 2022 09:24:38 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH edk2-platforms v1 1/1] Platform/ARM: FVP: set IORT RC address limit for FVP RevC To: Ard Biesheuvel Cc: edk2-devel-groups-io , Sami Mujawar , Ard Biesheuvel , Thomas Abraham , nd References: <20220427085935.17236-1-edward.pickup@arm.com> From: "Edward Pickup" In-Reply-To: X-ClientProxiedBy: LO4P265CA0070.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2af::10) To DB8PR08MB4153.eurprd08.prod.outlook.com (2603:10a6:10:a2::10) MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: be4eacee-7945-4ba2-0207-08da28f091ac X-MS-TrafficTypeDiagnostic: DB9PR08MB6523:EE_|DB5EUR03FT018:EE_|AM5PR0802MB2402:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: TSbxCOH8KJxIkGPNHiA9RiC0yIuUtaZyFpEWBvPeTKS1b5FIJ/HPFFWeSr0yvv2EYgUhkHUgefVNooF1PKMn+SdOKML0D4ZOnGX9qgApuW2IxX67a5HTL4bbc+dE40uOWw0QsCFw3dqbocM2KRrFLgsflRfxwBLS2HLEzO0clOf3UUrRGip+o7E8PTh56Bo2t+ui83kIXGD/o12JAb+ffjSwTuVoM07DNMPPbUHnbeRzsQxGBzu0O/BetX0aqXxuJxW8LASpzJnKQJnc2GU/eSXIZbb7QYoBrn9JZWnUvq6/xIrppMChVPDoILGi4Q9CpOPkC9TnHUKXgwUvLF3rrjDUy6iPqhqkymDCOHBjDcsIND1hgCeJiBpxCmC+xCU2w0fFIM8KQZvntoXb1wgscD8luAsW/vwseZ13dnap7KONNWvhpHqHIrmhCUiKRMi5Ar/oBf9oCiF+qwitGroPMPTtLLF6qXfo84qjWviIdE9mmUBIvHSm0qTyNWuX5hozy8Z5Y6AjDB6ZKq3Ln8W8XKFDCMhuv5lNo43yxJIXd98C/4cxqwyH7vsc1ogU0jygpCw6pIy/vciauLBENB5TaWW08+eLzUQDYEquMrcDvRgstK6EWxB0IG+Kxab23KoP6eguv8jYQ7cUk9Kd7q+hyaek/sW9IVuGl8xtma8Vyqj8Ky5i0KGOhdEQHCFK7wywu0eLwrnB7+5oWGCE8zszUIxifvEuPNJfYkvYp5MW8B5ZbqtMbIgllSnOKORuzJ5U2PzASEanp1rpLw/Qc1cqgtOaSt5AMjOCoMZXaIK8sx9fv8f6h86l94tq0cv9wxn1 X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB8PR08MB4153.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(6506007)(966005)(53546011)(6486002)(508600001)(31696002)(26005)(6512007)(54906003)(38100700002)(36756003)(316002)(6916009)(8936002)(83380400001)(2616005)(186003)(31686004)(2906002)(4326008)(8676002)(66556008)(86362001)(44832011)(66946007)(5660300002)(66476007)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB6523 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Return-Path: Edward.Pickup@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT018.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 18e46254-f9b7-4a46-2d8d-08da28f0898a X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: wINEDfgfxGMj/6wDHPS5wmE3iMCBujZ/u99Y8UDmmsGYQZIUeUJd0TLGfktw6VwLxAzrS6PltsLrXy0rDJiTn4xKlH79MzYd5PTwWINmZx3GE4ZYuP2W+IWx2MvH+YWW3q6WByuCc4PFwTeP+qNT7PUwjFnlFkj2FfF5bWVVrLm1Izx9GgnaiXqIRvBZJf1Bsx3T+mc24BYVp7li0RgRhJESpDQ+uw3iHqsAaSgFEf/rZrGfMGHcD3lYu5DmpNvM9HwRCppWrnuOu3qGqSWcJX/2UvCE2CrBpnVGpi9iFwepAsODUUYjcLGp9HSA/8ZnkAbbQ97UrTjRhoR3lio8gYp/veFzGVnEuB0qEaXUE1t2FcIBE3QSmu90JwzikD3V7OzBpg9/NP4jmZuoAj6CmImZp5+mAROQ+078cIi7JZznXeDQ3uND68jM0Eyz5WX7jBQFFNBCYKNxdBiCP1Mq6xo3TfrHLL/YIYKBtF1BYSNQF2tBkfYEWq7opJoteDGbo3ojS2MhyvVdaRBTEiXf5wBws5f+5GUra3yekLNW3aMN/kqYniE6n5j0wrDbyUqhuNq5iAeF/FZMyujnW3FkOsMIZntbgD/FnZL8hy5ofoewQOdndy3CVbGRYmDv7lnm+xnudXu3OftzPJ220jGBHE//DslkmwWRZTsowXlAefu0CfVy9LGGTD6UN2lRUDeLcChikLZj8qvuYpgICN6KhwI3tuoQrKQJYXYX8/25qIQeaeZLYCS0yTxsDBTPcqlZbFSjPWzieNFiP18+ujmBIW3Bc0ZPdjgQ+aHT+EB9ztM= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(40470700004)(46966006)(36840700001)(2906002)(44832011)(5660300002)(36756003)(36860700001)(70206006)(186003)(316002)(83380400001)(8676002)(6862004)(4326008)(8936002)(70586007)(54906003)(31686004)(86362001)(2616005)(336012)(47076005)(966005)(6486002)(31696002)(40460700003)(82310400005)(508600001)(81166007)(356005)(26005)(53546011)(6512007)(6506007)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Apr 2022 08:24:52.7421 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: be4eacee-7945-4ba2-0207-08da28f091ac X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DB5EUR03FT018.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0802MB2402 Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hello Collin, thank you for your comments On 27/04/2022 12:36, Ard Biesheuvel wrote: > Hello Edward, > > Thanks for the patch. > > On Wed, 27 Apr 2022 at 10:59, Edward Pickup wrote: >> When booting Linux on FVP RevC, Linux reports the following error: >> >> ACPI: IORT: [Firmware Bug]: Root complex missing memory address limit >> >> This issue is due to the RC Address Limit not being configured in the >> configuration manager for the platform. >> >> The default model parameter is configured to 32, so set this in the >> configuration manager, fixing the error. >> > Why is 32 a suitable value? I would not expect emulated IP to have > such a limitation. > After some internal discussions there was a miscommunication here. There is not a limit here, and the correct value should be 64. I will prepare a v2 patch with this change and send it out later today. >> Signed-off-by: Edward Pickup >> --- >> >> The changes can be seen at https://github.com/edpickup/edk2-platforms/tree/1700_fix_IORT_RC_Addr_Limit_v1 >> >> Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c | 4 +++- >> 1 file changed, 3 insertions(+), 1 deletion(-) >> >> diff --git a/Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c b/Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c >> index 776dec999eb1ef47910835987fa4dae1b69c52fd..560937d7a3addee729148fd6deab2eb82fced9e2 100644 >> --- a/Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c >> +++ b/Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c >> @@ -312,7 +312,9 @@ EDKII_PLATFORM_REPOSITORY_INFO VExpressPlatRepositoryInfo = { >> // ATS attributes >> EFI_ACPI_IORT_ROOT_COMPLEX_ATS_UNSUPPORTED, >> // PCI segment number >> - 0 >> + 0, >> + // Memory Address Size Limit >> + 32 >> }, >> >> // Array of Device ID mappings >> -- >> Guid("CE165669-3EF3-493F-B85D-6190EE5B9759") >> >> IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.