[PATCH edk2-platforms v1 1/1] Platform/ARM: FVP: set IORT RC address limit for FVP RevC

[PATCH edk2-platforms v1 1/1] Platform/ARM: FVP: set IORT RC address limit for FVP RevC

[Edward Pickup]

When booting Linux on FVP RevC, Linux reports the following error:

ACPI: IORT: [Firmware Bug]: Root complex missing memory address limit

This issue is due to the RC Address Limit not being configured in the
configuration manager for the platform.

The default model parameter is configured to 32, so set this in the
configuration manager, fixing the error.

Signed-off-by: Edward Pickup <edward.pickup@arm.com>
---

The changes can be seen at https://github.com/edpickup/edk2-platforms/tree/1700_fix_IORT_RC_Addr_Limit_v1

 Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c b/Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c
index 776dec999eb1ef47910835987fa4dae1b69c52fd..560937d7a3addee729148fd6deab2eb82fced9e2 100644
--- a/Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c
+++ b/Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c
@@ -312,7 +312,9 @@ EDKII_PLATFORM_REPOSITORY_INFO VExpressPlatRepositoryInfo = {
     // ATS attributes
     EFI_ACPI_IORT_ROOT_COMPLEX_ATS_UNSUPPORTED,
     // PCI segment number
-    0
+    0,
+    // Memory Address Size Limit
+    32
   },

   // Array of Device ID mappings
--
Guid("CE165669-3EF3-493F-B85D-6190EE5B9759")

IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.

Re: [PATCH edk2-platforms v1 1/1] Platform/ARM: FVP: set IORT RC address limit for FVP RevC

[Ard Biesheuvel]

Hello Edward,

Thanks for the patch.

On Wed, 27 Apr 2022 at 10:59, Edward Pickup <edward.pickup@arm.com> wrote:
>
> When booting Linux on FVP RevC, Linux reports the following error:
>
> ACPI: IORT: [Firmware Bug]: Root complex missing memory address limit
>
> This issue is due to the RC Address Limit not being configured in the
> configuration manager for the platform.
>
> The default model parameter is configured to 32, so set this in the
> configuration manager, fixing the error.
>

Why is 32 a suitable value? I would not expect emulated IP to have
such a limitation.


> Signed-off-by: Edward Pickup <edward.pickup@arm.com>
> ---
>
> The changes can be seen at https://github.com/edpickup/edk2-platforms/tree/1700_fix_IORT_RC_Addr_Limit_v1
>
>  Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c b/Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c
> index 776dec999eb1ef47910835987fa4dae1b69c52fd..560937d7a3addee729148fd6deab2eb82fced9e2 100644
> --- a/Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c
> +++ b/Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c
> @@ -312,7 +312,9 @@ EDKII_PLATFORM_REPOSITORY_INFO VExpressPlatRepositoryInfo = {
>      // ATS attributes
>      EFI_ACPI_IORT_ROOT_COMPLEX_ATS_UNSUPPORTED,
>      // PCI segment number
> -    0
> +    0,
> +    // Memory Address Size Limit
> +    32
>    },
>
>    // Array of Device ID mappings
> --
> Guid("CE165669-3EF3-493F-B85D-6190EE5B9759")
>
> IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.

Re: [PATCH edk2-platforms v1 1/1] Platform/ARM: FVP: set IORT RC address limit for FVP RevC

[Edward Pickup]

Hello Collin, thank you for your comments

On 27/04/2022 12:36, Ard Biesheuvel wrote:
> Hello Edward,
>
> Thanks for the patch.
>
> On Wed, 27 Apr 2022 at 10:59, Edward Pickup <edward.pickup@arm.com> wrote:
>> When booting Linux on FVP RevC, Linux reports the following error:
>>
>> ACPI: IORT: [Firmware Bug]: Root complex missing memory address limit
>>
>> This issue is due to the RC Address Limit not being configured in the
>> configuration manager for the platform.
>>
>> The default model parameter is configured to 32, so set this in the
>> configuration manager, fixing the error.
>>
> Why is 32 a suitable value? I would not expect emulated IP to have
> such a limitation.
>
After some internal discussions there was a miscommunication here. There 
is not a limit here, and the correct value should be 64. I will prepare 
a v2 patch with this change and send it out later today.
>> Signed-off-by: Edward Pickup <edward.pickup@arm.com>
>> ---
>>
>> The changes can be seen at https://github.com/edpickup/edk2-platforms/tree/1700_fix_IORT_RC_Addr_Limit_v1
>>
>>   Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c | 4 +++-
>>   1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c b/Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c
>> index 776dec999eb1ef47910835987fa4dae1b69c52fd..560937d7a3addee729148fd6deab2eb82fced9e2 100644
>> --- a/Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c
>> +++ b/Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c
>> @@ -312,7 +312,9 @@ EDKII_PLATFORM_REPOSITORY_INFO VExpressPlatRepositoryInfo = {
>>       // ATS attributes
>>       EFI_ACPI_IORT_ROOT_COMPLEX_ATS_UNSUPPORTED,
>>       // PCI segment number
>> -    0
>> +    0,
>> +    // Memory Address Size Limit
>> +    32
>>     },
>>
>>     // Array of Device ID mappings
>> --
>> Guid("CE165669-3EF3-493F-B85D-6190EE5B9759")
>>
>> IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.