From: "PierreGondois" <pierre.gondois@arm.com>
To: Sami Mujawar <sami.mujawar@arm.com>, devel@edk2.groups.io
Cc: ardb+tianocore@kernel.org, quic_llindhol@quicinc.com,
Matteo.Carlini@arm.com, Akanksha.Jain2@arm.com,
Ben.Adderson@arm.com, gaoliming@byosoft.com.cn,
jeremy.linton@arm.com, thomas.abraham@arm.com,
Chandni.Cherukuri@arm.com, nhi@os.amperecomputing.com,
vunguyen@os.amperecomputing.com, thang@os.amperecomputing.com,
chuong@os.amperecomputing.com, xiepeng@phytium.com.cn,
jialing@phytium.com.cn, shuyiqi@phytium.com.cn, nd@arm.com
Subject: Re: [PATCH edk2-platforms v3 00/12] Fix build breaks and update IORT revision macro
Date: Wed, 13 Jul 2022 15:18:38 +0200 [thread overview]
Message-ID: <0d1690bd-2893-6595-e214-409bed94e613@arm.com> (raw)
In-Reply-To: <20220712144047.3080-1-sami.mujawar@arm.com>
Hi Sami,
I think
Silicon/NXP/NxpQoriqLs.dsc.inc
also requires the VariableFlashInfoLib library. Otherwise:
Reviewed-by: Pierre Gondois <pierre.gondois@arm.com>
On 7/12/22 16:40, Sami Mujawar wrote:
> This v3 patch series renames the EFI_ACPI_IO_REMAPPING_TABLE_REV0
> macro to EFI_ACPI_IO_REMAPPING_TABLE_REVISION_00 based on the
> feedback received. It also includes an additional patch that fixes
> the build break in CelloBoard due to missing VariablePolicyHelperLib
> dependency.
>
> The v2 patch series fixes the build break in Ampere/Jade and
> Pythium/FT2000-4 due to missing VariableFlashInfoLib dependency
> and also updates the IORT revision macro.
>
> The IORT Rev E.d specification updates the IORT table revision
> to 5. Following this the IORT table revision macro
> EFI_ACPI_IO_REMAPPING_TABLE_REVISION which was at Rev 0 has
> been renamed to EFI_ACPI_IO_REMAPPING_TABLE_REV0. Therefore,
> this series updates the following platforms to reflect this
> renaming:
> - FVP
> - Morello FVP
> - SGI
> - AMD/Styx
> - Socionext/SynQuacer
> - RaspberryPi
> - N1SDP
> - Ampere/Jade
> - Pythium/FT2000-4
>
> Note: This patch series is dependent on the edk2 patch series:
> "[PATCH v5 0/8] IORT Rev E.d specification updates"
> (https://edk2.groups.io/g/devel/message/91264), which must
> be merged in edk2 before this patch series can be integrated.
>
> The changes can be seen at:
> https://github.com/samimujawar/edk2-platforms/tree/1527_iort_rev_ed_platforms_v3
>
> Sami Mujawar (12):
> Platform/ARM: FVP: Update for IORT revision macro renaming
> Platform/ARM: Morello: Update for IORT revision macro renaming
> Platform/ARM: SGI: Update for IORT revision macro renaming
> Silicon/AMD/Styx: Update for IORT revision macro renaming
> Silicon/Socionext/SynQuacer: Update for IORT revision macro renaming
> Platform/RaspberryPi: Update for IORT revision macro renaming
> Platform/ARM: N1SDP: Update for IORT revision macro renaming
> Silicon/Ampere: Add VariableFlashInfoLib
> Platform/Ampere: JadePkg: Update for IORT revision macro renaming
> Silicon/Phytium: Add VariableFlashInfoLib
> Silicon/Phytium: FT2000-4Pkg: Update for IORT revision macro renaming
> Platform/LeMaker: Fix missing dependency on VariablePolicyHelperLib
>
> Platform/ARM/Morello/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManagerFvp.c | 2 +-
> Platform/ARM/N1Sdp/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c | 2 +-
> Platform/ARM/SgiPkg/AcpiTables/Iort.aslc | 2 +-
> Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c | 2 +-
> Platform/Ampere/JadePkg/Drivers/AcpiPlatformDxe/AcpiIort.c | 2 +-
> Platform/LeMaker/CelloBoard/CelloBoard.dsc | 1 +
> Platform/RaspberryPi/AcpiTables/Iort.aslc | 2 +-
> Silicon/AMD/Styx/Drivers/AcpiPlatformDxe/Iort.aslc | 2 +-
> Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc | 1 +
> Silicon/Phytium/FT2000-4Pkg/Drivers/AcpiTables/Iort.aslc | 2 +-
> Silicon/Phytium/PhytiumCommonPkg/PhytiumCommonPkg.dsc.inc | 1 +
> Silicon/Socionext/SynQuacer/AcpiTables/Iort.aslc | 2 +-
> 12 files changed, 12 insertions(+), 9 deletions(-)
>
next prev parent reply other threads:[~2022-07-13 13:19 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-12 14:40 [PATCH edk2-platforms v3 00/12] Fix build breaks and update IORT revision macro Sami Mujawar
2022-07-12 14:40 ` [PATCH edk2-platforms v3 01/12] Platform/ARM: FVP: Update for IORT revision macro renaming Sami Mujawar
2022-07-12 14:40 ` [PATCH edk2-platforms v3 02/12] Platform/ARM: Morello: " Sami Mujawar
2022-07-12 14:40 ` [PATCH edk2-platforms v3 03/12] Platform/ARM: SGI: " Sami Mujawar
2022-07-14 12:30 ` Thomas Abraham
2022-07-12 14:40 ` [PATCH edk2-platforms v3 04/12] Silicon/AMD/Styx: " Sami Mujawar
2022-07-12 14:40 ` [PATCH edk2-platforms v3 05/12] Silicon/Socionext/SynQuacer: " Sami Mujawar
2022-07-12 14:40 ` [PATCH edk2-platforms v3 06/12] Platform/RaspberryPi: " Sami Mujawar
2022-07-12 14:40 ` [PATCH edk2-platforms v3 07/12] Platform/ARM: N1SDP: " Sami Mujawar
2022-07-12 14:40 ` [PATCH edk2-platforms v3 08/12] Silicon/Ampere: Add VariableFlashInfoLib Sami Mujawar
2022-07-14 3:34 ` Nhi Pham
2022-07-14 7:40 ` Sami Mujawar
[not found] ` <1701A22D591971D9.31468@groups.io>
2022-07-14 9:06 ` [edk2-devel] " Sami Mujawar
2022-07-14 9:12 ` Nhi Pham
2022-07-12 14:40 ` [PATCH edk2-platforms v3 09/12] Platform/Ampere: JadePkg: Update for IORT revision macro renaming Sami Mujawar
2022-07-14 3:34 ` Nhi Pham
2022-07-12 14:40 ` [PATCH edk2-platforms v3 10/12] Silicon/Phytium: Add VariableFlashInfoLib Sami Mujawar
2022-07-12 14:40 ` [PATCH edk2-platforms v3 11/12] Silicon/Phytium: FT2000-4Pkg: Update for IORT revision macro renaming Sami Mujawar
2022-07-12 14:40 ` [PATCH edk2-platforms v3 12/12] Platform/LeMaker: Fix missing dependency on VariablePolicyHelperLib Sami Mujawar
2022-07-13 13:18 ` PierreGondois [this message]
2022-07-14 6:38 ` [edk2-devel] [PATCH edk2-platforms v3 00/12] Fix build breaks and update IORT revision macro Masahisa Kojima
2022-07-14 8:01 ` Sami Mujawar
2022-07-14 8:06 ` Sami Mujawar
2022-07-14 8:43 ` Masahisa Kojima
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0d1690bd-2893-6595-e214-409bed94e613@arm.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox