From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web11.21724.1657718355802824553 for ; Wed, 13 Jul 2022 06:19:16 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: arm.com, ip: 217.140.110.172, mailfrom: pierre.gondois@arm.com) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 9A2361424; Wed, 13 Jul 2022 06:19:15 -0700 (PDT) Received: from [192.168.1.11] (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 2F0BE3F73D; Wed, 13 Jul 2022 06:19:10 -0700 (PDT) Message-ID: <0d1690bd-2893-6595-e214-409bed94e613@arm.com> Date: Wed, 13 Jul 2022 15:18:38 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH edk2-platforms v3 00/12] Fix build breaks and update IORT revision macro To: Sami Mujawar , devel@edk2.groups.io Cc: ardb+tianocore@kernel.org, quic_llindhol@quicinc.com, Matteo.Carlini@arm.com, Akanksha.Jain2@arm.com, Ben.Adderson@arm.com, gaoliming@byosoft.com.cn, jeremy.linton@arm.com, thomas.abraham@arm.com, Chandni.Cherukuri@arm.com, nhi@os.amperecomputing.com, vunguyen@os.amperecomputing.com, thang@os.amperecomputing.com, chuong@os.amperecomputing.com, xiepeng@phytium.com.cn, jialing@phytium.com.cn, shuyiqi@phytium.com.cn, nd@arm.com References: <20220712144047.3080-1-sami.mujawar@arm.com> From: "PierreGondois" In-Reply-To: <20220712144047.3080-1-sami.mujawar@arm.com> Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Sami, I think Silicon/NXP/NxpQoriqLs.dsc.inc also requires the VariableFlashInfoLib library. Otherwise: Reviewed-by: Pierre Gondois On 7/12/22 16:40, Sami Mujawar wrote: > This v3 patch series renames the EFI_ACPI_IO_REMAPPING_TABLE_REV0 > macro to EFI_ACPI_IO_REMAPPING_TABLE_REVISION_00 based on the > feedback received. It also includes an additional patch that fixes > the build break in CelloBoard due to missing VariablePolicyHelperLib > dependency. > > The v2 patch series fixes the build break in Ampere/Jade and > Pythium/FT2000-4 due to missing VariableFlashInfoLib dependency > and also updates the IORT revision macro. > > The IORT Rev E.d specification updates the IORT table revision > to 5. Following this the IORT table revision macro > EFI_ACPI_IO_REMAPPING_TABLE_REVISION which was at Rev 0 has > been renamed to EFI_ACPI_IO_REMAPPING_TABLE_REV0. Therefore, > this series updates the following platforms to reflect this > renaming: > - FVP > - Morello FVP > - SGI > - AMD/Styx > - Socionext/SynQuacer > - RaspberryPi > - N1SDP > - Ampere/Jade > - Pythium/FT2000-4 > > Note: This patch series is dependent on the edk2 patch series: > "[PATCH v5 0/8] IORT Rev E.d specification updates" > (https://edk2.groups.io/g/devel/message/91264), which must > be merged in edk2 before this patch series can be integrated. > > The changes can be seen at: > https://github.com/samimujawar/edk2-platforms/tree/1527_iort_rev_ed_platforms_v3 > > Sami Mujawar (12): > Platform/ARM: FVP: Update for IORT revision macro renaming > Platform/ARM: Morello: Update for IORT revision macro renaming > Platform/ARM: SGI: Update for IORT revision macro renaming > Silicon/AMD/Styx: Update for IORT revision macro renaming > Silicon/Socionext/SynQuacer: Update for IORT revision macro renaming > Platform/RaspberryPi: Update for IORT revision macro renaming > Platform/ARM: N1SDP: Update for IORT revision macro renaming > Silicon/Ampere: Add VariableFlashInfoLib > Platform/Ampere: JadePkg: Update for IORT revision macro renaming > Silicon/Phytium: Add VariableFlashInfoLib > Silicon/Phytium: FT2000-4Pkg: Update for IORT revision macro renaming > Platform/LeMaker: Fix missing dependency on VariablePolicyHelperLib > > Platform/ARM/Morello/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManagerFvp.c | 2 +- > Platform/ARM/N1Sdp/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c | 2 +- > Platform/ARM/SgiPkg/AcpiTables/Iort.aslc | 2 +- > Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c | 2 +- > Platform/Ampere/JadePkg/Drivers/AcpiPlatformDxe/AcpiIort.c | 2 +- > Platform/LeMaker/CelloBoard/CelloBoard.dsc | 1 + > Platform/RaspberryPi/AcpiTables/Iort.aslc | 2 +- > Silicon/AMD/Styx/Drivers/AcpiPlatformDxe/Iort.aslc | 2 +- > Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc | 1 + > Silicon/Phytium/FT2000-4Pkg/Drivers/AcpiTables/Iort.aslc | 2 +- > Silicon/Phytium/PhytiumCommonPkg/PhytiumCommonPkg.dsc.inc | 1 + > Silicon/Socionext/SynQuacer/AcpiTables/Iort.aslc | 2 +- > 12 files changed, 12 insertions(+), 9 deletions(-) >