From: Laszlo Ersek <lersek@redhat.com>
To: Varun Kumar <varun7036@gmail.com>
Cc: edk2-devel@lists.01.org
Subject: Re: Need clarification on ImageUpdatable field in EFI_FIRMWARE_MANAGEMENT_PROTOCOL.CheckImage()
Date: Tue, 9 Oct 2018 11:26:47 +0200 [thread overview]
Message-ID: <0d2417df-bc62-e279-97d5-8a84b706407a@redhat.com> (raw)
In-Reply-To: <CAK9qSntrdtSp=P4pgNH7N5JhoVMmhS9qFHVRyKrhp_4TSVgyug@mail.gmail.com>
Hi,
On 10/09/18 11:07, Varun Kumar wrote:
> I need clarification on ImageUpdatable field in
> EFI_FIRMWARE_MANAGEMENT_PROTOCOL.CheckImage(). ImageUpdatable is of 32
> bit wide
That seems to be the case, yes. (OUT UINT32 *).
> but ImageUpdatable Definitions for this field is of 64 bit wide.
That's not the case; the macros
- IMAGE_UPDATABLE_VALID,
- IMAGE_UPDATABLE_INVALID,
- IMAGE_UPDATABLE_INVALID_TYPE,
- IMAGE_UPDATABLE_INVALID_OLD,
- IMAGE_UPDATABLE_VALID_WITH_VENDOR_CODE
all have type INT32.
(Using the last one as an example, the integer constant
0x0000000000000010 has type INT32.)
I agree that the large number of leading zeroes is confusing. Please
consider filing a Mantis ticket for the UEFI spec, for cleaning those
up.
> I hope it's not defined intentionally if so, please clarify me on
> this. Please find the attached screenshot for reference.
Two comments on the screenshot:
- Currently the edk2-devel list strips attachments (most types, if not
all). That's a bug, but it's very hard to fix. Either way, the image
you may have attached hasn't reached the list.
- Sending a screenshot (I assume: from the UEFI spec) is not a bad idea
(assuming you use a lossless compression format, like PNG). It can be
improved further if you also provide textual pointers, such as: spec
release (e.g. "2.7"), and page number or section number.
Thanks!
Laszlo
next prev parent reply other threads:[~2018-10-09 9:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-09 9:07 Need clarification on ImageUpdatable field in EFI_FIRMWARE_MANAGEMENT_PROTOCOL.CheckImage() Varun Kumar
2018-10-09 9:26 ` Laszlo Ersek [this message]
2018-10-09 9:50 ` Varun Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0d2417df-bc62-e279-97d5-8a84b706407a@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox