From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f196.google.com (mail-pf1-f196.google.com [209.85.210.196]) by mx.groups.io with SMTP id smtpd.web12.6664.1606923086523277468 for ; Wed, 02 Dec 2020 07:31:26 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=UOtohbQp; spf=pass (domain: nuviainc.com, ip: 209.85.210.196, mailfrom: rebecca@nuviainc.com) Received: by mail-pf1-f196.google.com with SMTP id w187so1461946pfd.5 for ; Wed, 02 Dec 2020 07:31:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=Lza6irP9+LyYCsZAx24eMp0m5yVYha1/XALvaeSf6Fc=; b=UOtohbQpirZuWFFRdhjW438FXsdKchhQmq/YIvP2hpMNABRvHp2oFJCbraqFGY/Wit 9x2nMFX1q8SM2llradrp9z/Dy4LPFZqIqyF3mkmPZ3MQwK1LI8ovm2Y/Opx0YHU2i+Qt lnPsqnKkej2MzrbjHkfpahpvrktBcaYB2DN/YPWpfPt93CQn5EjYI5HVZibPM5CiQXBZ Iqn5FAWufkwdrwUZFsi1o1jKGjJ+C/UxcaRLCZwyAQC/LxLJ69dtps4uRUu6rsfSnir3 EHcdBMV6tXaqJhUR3Tyx6aODr9i+NlbrggWo+Zy4dwJfCOyfJmG2goHOtt8jyyTVLJAm 1JMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=Lza6irP9+LyYCsZAx24eMp0m5yVYha1/XALvaeSf6Fc=; b=Fg6a9/uAM6tlX/96rdCK5Q2VOeH/mUY1jaBK6WJxiOF7AuLI9V0obbFIGBPN3qTK9v FpXW6OtXHMs3Ct4nAXKUrGmYphlq4NK90lHO+6tMBxPTT0b6T5GxnIaTSnukDmNq7OaD 8RAVtrRB01p6+oIoLOguSL+ZLsqm/BAgbJTwLwIy4CytaPLFsR9uA3p+tscxUDp1+r14 zFa6gnEgKepcDs7NRyyzKb3zjiJZN1F3TxG1LsLpo5wnLc4IdWleP7KU/xznmxON0hgt 676lC3SYiQMaDkNu8nnQn1qEkWrNgBrKO1kXF7F6aQy+tIpqWfsoUvCoXNP+JUFG8lkG U77Q== X-Gm-Message-State: AOAM531wvq+08mM0BJsv5tWeK5obVwsQokT8AumszD5M70nZejUVsCuJ idSkzNKwy4i5fDJxom1561ZpTw== X-Google-Smtp-Source: ABdhPJzx6UhwEoPTr5F1Y07pqHgNNrARAuyzQXbOqNQ6z8CUd+Jl9FFle11+h2TQGVgfroXh3H7lWg== X-Received: by 2002:a62:7f4c:0:b029:198:bfe:96f6 with SMTP id a73-20020a627f4c0000b02901980bfe96f6mr3131942pfd.23.1606923086085; Wed, 02 Dec 2020 07:31:26 -0800 (PST) Return-Path: Received: from [10.0.10.142] (c-174-52-16-57.hsd1.ut.comcast.net. [174.52.16.57]) by smtp.gmail.com with ESMTPSA id n11sm129646pjf.1.2020.12.02.07.31.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 02 Dec 2020 07:31:25 -0800 (PST) Subject: Re: [PATCH v4 09/11] ArmPkg: Add FirmwareVersionInfoPeim To: Ard Biesheuvel , devel@edk2.groups.io Cc: Michael D Kinney , Liming Gao , Zhiguang Liu , Leif Lindholm , Sami Mujawar References: <20201201003358.8780-1-rebecca@nuviainc.com> <20201201003358.8780-10-rebecca@nuviainc.com> <0a794787-7db6-f13c-3bc0-7abe906427bd@arm.com> From: "Rebecca Cran" Message-ID: <0d3066d5-8365-7054-9827-fdeaa4066983@nuviainc.com> Date: Wed, 2 Dec 2020 08:31:22 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.5.1 MIME-Version: 1.0 In-Reply-To: <0a794787-7db6-f13c-3bc0-7abe906427bd@arm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US On 12/2/20 8:20 AM, Ard Biesheuvel wrote: > Is there any pressing need for this to execute in the PEI phase? These > are all compile time constants, which can easily be exposed the the > SMBIOS driver running in DXE in a different way, no? Hi Ard, I don't currently see any reason for this to execute in the PEI phase, and it introduces unnecessary complexity. I'll integrate it into Universal/Smbios instead. -- Rebecca Cran