From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.81]) by mx.groups.io with SMTP id smtpd.web12.216.1571786848133362491 for ; Tue, 22 Oct 2019 16:27:28 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=GcRuY0fo; spf=pass (domain: redhat.com, ip: 207.211.31.81, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1571786847; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vtMrcTdCQSbxcnMI8qaQCR+WuQkNQlK9zNpesq/mc40=; b=GcRuY0fobF3b45B6DSSQLwPKH40Hl9RlHC7GSZnKUhXBXSkLIvD5Xjs2+YVty+q80Z+jOi bHYxmw1k5NMx3YjUrouo3CZVb8FKsLaltw4YyavM9BkFTPNR80U33cnijx991twXvk5VQv 9A/6yAW3AEI1jr/yVBAsbA3N/q5qNKU= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-317-AfjTglVEPHaUGvzb95Dm4g-1; Tue, 22 Oct 2019 19:27:21 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 972FF1005509; Tue, 22 Oct 2019 23:27:20 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (unknown [10.36.118.54]) by smtp.corp.redhat.com (Postfix) with ESMTP id BF5E760C5D; Tue, 22 Oct 2019 23:27:18 +0000 (UTC) Subject: Re: [Patch] UefiCpuPkg: Add missing components to UefiCpuPkg.dsc To: "Kinney, Michael D" , "devel@edk2.groups.io" Cc: Sean Brogan , "Dong, Eric" , "Ni, Ray" , Wei David Y , Agyeman Prince References: <20191022190659.26912-1-michael.d.kinney@intel.com> From: "Laszlo Ersek" Message-ID: <0d6e9a75-a3cb-ea01-92ed-cc5d2f87dcc9@redhat.com> Date: Wed, 23 Oct 2019 01:27:17 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-MC-Unique: AfjTglVEPHaUGvzb95Dm4g-1 X-Mimecast-Spam-Score: 0 Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable (+David, +Prince) On 10/23/19 01:13, Kinney, Michael D wrote: > Laszlo, >=20 > I see 2 usages of this module in edk2-platforms: >=20 > edk2-platforms\Silicon\Intel\SimicsX58SktPkg\SktPkgPei.dsc(13): UefiCpuP= kg/ResetVector/Vtf0/Bin/ResetVector.inf >=20 > edk2-platforms\Silicon\Intel\SimicsX58SktPkg\SktSecInclude.fdf(16):INF R= uleOverride=3DRESET_VECTOR USE =3D IA32 UefiCpuPkg/ResetVector/Vtf0/Bin/Res= etVector.inf Can we update those platforms to build the reset vector from source? Embedding a binary blob seems wrong in its own right... Anyway, if Ray and/or Eric are OK with the present patch, I won't try to block it. Thanks, Laszlo >> -----Original Message----- >> From: Laszlo Ersek >> Sent: Tuesday, October 22, 2019 3:57 PM >> To: Kinney, Michael D ; >> devel@edk2.groups.io >> Cc: Sean Brogan ; Dong, Eric >> ; Ni, Ray >> Subject: Re: [Patch] UefiCpuPkg: Add missing components >> to UefiCpuPkg.dsc >> >> On 10/22/19 21:06, Michael D Kinney wrote: >>> From: Sean Brogan >>> >>> https://bugzilla.tianocore.org/show_bug.cgi?id=3D2255 >>> >>> Update UefiCpuPkg.dsc to guarantee all libraries and >> modules are >>> always built. Add the following components. >>> >>> * UefiCpuPkg/ResetVector/Vtf0/Bin/ResetVector.inf >>> * >> UefiCpuPkg/Library/CpuCommonFeaturesLib/CpuCommonFeature >> sLib.inf >>> >>> ResetVector.inf is a binary INF, so no source builds >> are triggered >>> from adding this line. However, a build with this >> component does >>> verify the contents of the INF file. >>> >>> Cc: Eric Dong >>> Cc: Ray Ni >>> Cc: Laszlo Ersek >>> Signed-off-by: Michael D Kinney >> >>> --- >>> UefiCpuPkg/UefiCpuPkg.dsc | 2 ++ >>> 1 file changed, 2 insertions(+) >>> >>> diff --git a/UefiCpuPkg/UefiCpuPkg.dsc >> b/UefiCpuPkg/UefiCpuPkg.dsc >>> index e7dfe30eda..d28cb5cccb 100644 >>> --- a/UefiCpuPkg/UefiCpuPkg.dsc >>> +++ b/UefiCpuPkg/UefiCpuPkg.dsc >>> @@ -121,6 +121,7 @@ [Components.IA32, Components.X64] >>> >> UefiCpuPkg/Library/BaseUefiCpuLib/BaseUefiCpuLib.inf >>> UefiCpuPkg/Library/BaseXApicLib/BaseXApicLib.inf >>> >> UefiCpuPkg/Library/BaseXApicX2ApicLib/BaseXApicX2ApicLib >> .inf >>> + >> UefiCpuPkg/Library/CpuCommonFeaturesLib/CpuCommonFeature >> sLib.inf >>> >> UefiCpuPkg/Library/CpuExceptionHandlerLib/DxeCpuExceptio >> nHandlerLib.inf >>> >> UefiCpuPkg/Library/CpuExceptionHandlerLib/SecPeiCpuExcep >> tionHandlerLib.inf >>> >>> >> UefiCpuPkg/Library/CpuExceptionHandlerLib/SmmCpuExceptio >> nHandlerLib.in >>> f @@ -146,6 +147,7 @@ [Components.IA32, >> Components.X64] >>> >> SmmCpuFeaturesLib|UefiCpuPkg/Library/SmmCpuFeaturesLib/S >> mmCpuFeaturesLibStm.inf >>> } >>> >> UefiCpuPkg/Universal/Acpi/S3Resume2Pei/S3Resume2Pei.inf >>> + UefiCpuPkg/ResetVector/Vtf0/Bin/ResetVector.inf >>> >>> [BuildOptions] >>> *_*_*_CC_FLAGS =3D -D >> DISABLE_NEW_DEPRECATED_INTERFACES >>> >> >> Can we retire >> >> UefiCpuPkg/ResetVector/Vtf0/Bin/ >> >> instead (in a separate patch)? >> >> Because, according to >> >> git log --stat master -- >> UefiCpuPkg/ResetVector/Vtf0/Bin/ >> >> the most recent commit in which we updated the *.raw >> files has been >> f7bb98019a71 ("UefiCpuPkg VTF0: Fix support for finding >> SEC image of type TE.", 2011-09-28). >> >> I doubt anyone consumes this (binary) module, since >> Jordan's commits >> - 5a1f324d946c ("UefiCpuPkg: Support building VTF0 >> ResetVector during the EDK II build", 2014-08-18) >> - eee1d2ca9078 ("UefiCpuPkg VTF0 X64: Build page tables >> in NASM code", 2014-08-18). >> >> We've by now dropped all top-level *BinPkg package >> directories too. >> >> If we remove the Bin subdir, then we should probably >> remove: >> - Build.py >> - Tools/ >> too. >> >> For the other addition (CpuCommonFeaturesLib): if that >> gets its own patch (after the removal of >> UefiCpuPkg/ResetVector/Vtf0/Bin/), then please add >> >> Reviewed-by: Laszlo Ersek >> >> to it. >> >> Thanks >> Laszlo >=20