From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id E40C4AC09F4 for ; Mon, 13 May 2024 04:08:26 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=SDezhwJSsK8T6wQli4oBxWZAfoXodS2YQrsDlAaOxUQ=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:User-Agent:Subject:To:References:From:In-Reply-To:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240206; t=1715573305; v=1; b=Ci8MZOHhRwyovUQOjEVuV0bIF1Yfm5oshGuVqrPAezaWNpjsoBQYyNkn6jl2o2HSa1l0AiGm wrLItiTsppdL316f3RLNWjhwr4gppF3/5fYXOsAY6rWfNig/9Fj+b9XNuJL7j5aVaU7k7BlBLfI 5UHuN0mIu5B53e2vFyK2KnVWpBdniMgmmhwQ1gQ6Nilp+6JwEUr+aiZaWQF+UYpjPRza8r6Vglg w2sVJYFsyfXobh/o1R1wwup8qvj+Y1VstEwkYhbx39limDWd+mm0WlFc+dW2Ze8+1AQNWcpuScq rLECbAaD+E4Gi03hHYPRxa4QxcylZY9UxsqspAf8cy7Jw== X-Received: by 127.0.0.2 with SMTP id UbwVYY7687511xNzcX47qZYi; Sun, 12 May 2024 21:08:25 -0700 X-Received: from NAM12-DM6-obe.outbound.protection.outlook.com (NAM12-DM6-obe.outbound.protection.outlook.com [40.107.243.89]) by mx.groups.io with SMTP id smtpd.web11.52516.1715573299457097800 for ; Sun, 12 May 2024 21:08:19 -0700 X-Received: from IA1PR12MB6458.namprd12.prod.outlook.com (2603:10b6:208:3aa::22) by IA1PR12MB8309.namprd12.prod.outlook.com (2603:10b6:208:3fe::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7544.55; Mon, 13 May 2024 04:08:17 +0000 X-Received: from IA1PR12MB6458.namprd12.prod.outlook.com ([fe80::1a52:ef3a:cf04:e56d]) by IA1PR12MB6458.namprd12.prod.outlook.com ([fe80::1a52:ef3a:cf04:e56d%3]) with mapi id 15.20.7544.052; Mon, 13 May 2024 04:08:17 +0000 Message-ID: <0d85c5cf-3f00-40d4-9965-de58d12d55eb@amd.com> Date: Mon, 13 May 2024 09:38:10 +0530 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] [RESEND PATCH v4 0/5] DynamicTablesPkg: Adds FADT, HPET, WSMT and MADT Table generators To: Sami Mujawar , Pierre Gondois , "devel@edk2.groups.io" References: <783a23af-5eec-48c9-bcbd-be1c40518e54@arm.com> From: "Abdul Lateef Attar via groups.io" In-Reply-To: X-ClientProxiedBy: PN3PR01CA0002.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c01:95::22) To IA1PR12MB6458.namprd12.prod.outlook.com (2603:10b6:208:3aa::22) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: IA1PR12MB6458:EE_|IA1PR12MB8309:EE_ X-MS-Office365-Filtering-Correlation-Id: 4603f85a-a2ea-4557-9c38-08dc73025123 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?EdIc5EIu1s6kvjKQ85rVsjygfThnRWWBRLW7U8OuXTeTWmLdP+Lzh2z+4GTe?= =?us-ascii?Q?b4mHmBgeO0ah5msomqBO7H2Ca6WCII2LdVVR8BPQU7wOsuBnacRsavRzPq6u?= =?us-ascii?Q?J/iST488KaTk0YQIRSSJ6pcwvizFbSsz2xTWlDUYY6/TK7FXNSVV8f31kgf5?= =?us-ascii?Q?Fd5sNoIGbiAESQKbNVuBTEkYnfgCIADYnlXbnJ+DssuHYfNAnMZ25gwj6QVu?= =?us-ascii?Q?LJ8DhH4R78oSP8iUgPsy2iyqA6dSthAHPt0HdupcUWq5a73Xfs9jJlW6wmLz?= =?us-ascii?Q?aAIhhS/xvV5bY2OVI0K4kztBL20d3etgLMFD7ySiI5eWXuwV7451Zfuvw+l8?= =?us-ascii?Q?RvKIUAhtaPEfrvB95J/BXhikOEctJKx05fPMFlJfd8gE9a5Otp4o+XtZfgWc?= =?us-ascii?Q?2YVvARLTh57AJ/JuhGxjZPkxLRHohjhka+YesNYIvt4xNwwff+7NUy7U09ST?= =?us-ascii?Q?a5s67A6rAxz3YxjK1THQDRBlxJcoURhOpO1I5ZB7Fdho/Uh2JylsadXfpIRc?= =?us-ascii?Q?bZ0lPcvK4bEX2QFBuBb5olt1bmovzBQGpZTAiy+XEaozJkTTnD7ATJOST/HV?= =?us-ascii?Q?101DCqQeD3p0th8vCq2BlXTNnLm0snjHimoPMW/LPhblkAZ5Ij14FJqTF3NS?= =?us-ascii?Q?XhPhyWewtMoQu+JemDA9rZ89pLsJs48GcuHeZE4tmu+lYHG6futhjaBIiUQb?= =?us-ascii?Q?/QVF+7j5X0rcvntahXScU13R2JEVMIg5F+FvgBxirMRWpFIcv/7TLJCiBzO/?= =?us-ascii?Q?Q3EMbzVitupN1zDEOgzlIFLSo/tUhIBLGdDJiQzuOvDC5l2TSzbY1/z4D42A?= =?us-ascii?Q?/F74u8zNpPhq1oaEeybjYOl9VL4SN3JvGgqOhCWUymESxn8yOqVu4U1KCDLZ?= =?us-ascii?Q?TyAOeQgcZhazPN12alDwCNCl8UIQy2uz8uc+ZpnHN8EOMwtGLo4YI23T+J4r?= =?us-ascii?Q?RVMz6AiD8DDKHUJ3Q2//Qj7EfuZo/QMS24t/gPXdQGO5603UkJuoPoKNPxbl?= =?us-ascii?Q?ODBWEXqaumAT5F8Y/utc9CPiWILL9qfo7GL4kvVHY8vRs16BB2heAdlnc1y+?= =?us-ascii?Q?sJ3F70fiEfYAevRj5eN9FODaLLyyp+CI/36Rrrj1CNqzvmQPQfm/Es605lbu?= =?us-ascii?Q?zf4Bti3imoP9Z3i2kr4kreQoTdKZ+gbCh/mdc46Z4FIPQUWrTA1vN/r0F0Yu?= =?us-ascii?Q?kKkrsAgnbtG982caa6iqUgU+Py9Kk0dUe6vfiKVSHAOQj4MXvQN26BvGmm4?= =?us-ascii?Q?=3D?= X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?1AIypzdzfo+Gi8ffk2MbLZh8vekHcDAspYuvTUHkxFHHKbnq46PXrdX8gLPw?= =?us-ascii?Q?VO0kLCrXL0Y42dZZTvqhqOY7oQyd5y74Tpa4zS5ZucrjViPiA9N+DbIqLliW?= =?us-ascii?Q?LBZ7BcG6qmh7U+Rm/n1M6uTUnWH4x0dCeC0RAGDk4iBV3RyNTpVpLlEarJfo?= =?us-ascii?Q?JAxA/QMFsTuXAbJG6pz7zDMouNFP/U4I0TupPhdyI9ka77VVZTUmqTgt89Nv?= =?us-ascii?Q?TrZaIEnSTz4ZewOQ0rAryTP5DmVYys2bxl5mpDGqd0eRfg95YVtdKejWUzZ9?= =?us-ascii?Q?1PpXk8PmCeaROeIyp4nBk8Q7bZZgaCHqpTXC+S8cAn9mMFOIhkbhgLo9zy7v?= =?us-ascii?Q?qDye9csnf+YOB0hEO0/c9vNuhPEUJNGazOCnv+HJG7zF6zLbE5dL0HaauvoX?= =?us-ascii?Q?KX1wdq+nDCoUjFjRH9EqCGTWhrNikvxMCjwXgOQQrvELlKMHGdh0jKYt60t4?= =?us-ascii?Q?bpLEDBRKOvdljr0FJZxSNyyst4AfFdtDto01/f9qGel0pi4rfjBiKkVU8sSp?= =?us-ascii?Q?cqRm3YvE/psr6znZCoXOdJ+G+X0hvuu/dzCYs8jCX+BfC274BSAQg6eq8g+B?= =?us-ascii?Q?AqbhhCs2XTf0A20oiWkbt7y+R5/xFOUXnSrhNpFyU6l+iGZVBBa//BcoHvOo?= =?us-ascii?Q?DyAAoujYCo0fWKaqtVvLSD0YYRzvoCL64mWvOfaJg3rY0oxOtzcxQZiddfzc?= =?us-ascii?Q?I034dPQruuk28Fdl95DPtb4vyJpElg4JoBgAlGiEkEkCxyLuJpktZztJqsnG?= =?us-ascii?Q?lmUokrQjUvgtubFCtRjZOoVbVIYkn9XS0FQ48jzey11/hkw54KMo2+N5tCkM?= =?us-ascii?Q?7RT7d1Uwv/rQ8Gib8IlHCh/N1Opq6Dpi195hpBJ4EBUKLEVV0B/aZUGQVlm/?= =?us-ascii?Q?aQajmPinRCs7770onJEfUn2zjCI8E3Og179CyfGX+125ua/g5GH/SSm5hxua?= =?us-ascii?Q?jfFAf3NSxikgRI7AQxCRc2IDQnv7KO9vknRwwD8RGejhBJy7KRqV3KgjUvsz?= =?us-ascii?Q?FqhYMvlcuFlma08BMVtgpTLk6Scx5JxthVvc4kffPYhV1fZD4+i9Y/u92vOu?= =?us-ascii?Q?7FtYTYTNN0+MkvrTkvQO/eb9oYcmSAbnnwFmZvnNzuUXInxoTnt2CZfR/H7M?= =?us-ascii?Q?P0DH2QTKaQlBIK/NFuro7uDedC8WMUs1FlVhWQuGpzCtPBauDue314ya9z6R?= =?us-ascii?Q?BSuf1tiijZEB9cM1yHGmkb7ywMSci6h8VFFzB6zvkJYUme7XIAq1MHM9arqU?= =?us-ascii?Q?MDRTlbX2RY0X2Ay6ytgoTXr8jrG2n5vi87JA5HSml14FM/W72Y43A5oBfMh/?= =?us-ascii?Q?QHwEdhC9w2daef45/H4rP3V+hfwIg9vAH2IpHUEjNYVCLehocYExgfwIj0/L?= =?us-ascii?Q?iaGBGnJ1UPLdHFVBpxXweWuvIEvGWNK7cRuF7jexFao5NXNpQrfwH96eg2F0?= =?us-ascii?Q?qoarBLFHhI1WRpTF0/L7fp8fj/dP5GurZIzyNN55Icl77uqcfCn4pK0W5R31?= =?us-ascii?Q?vmNAyyD4yHmDQvWkEK48BDzk2DvRJnCUDBqDt3lrCY8RkqnUZ9Imw8OAXEWw?= =?us-ascii?Q?xUXOz+Rzp8L+2MTdRcY2z/5ABCYcJ0KHc+m8uPtH?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4603f85a-a2ea-4557-9c38-08dc73025123 X-MS-Exchange-CrossTenant-AuthSource: IA1PR12MB6458.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 May 2024 04:08:17.1288 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 6kMMFnDpJiZtT3nGg+IS3G0q44E2cZV906PxPk34mi2QbBMovHNVxdW+Wt1+TdWvoQmn7ZgpwO0Wmf/6qB+llA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB8309 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Sun, 12 May 2024 21:08:19 -0700 Resent-From: AbdulLateef.Attar@amd.com Reply-To: devel@edk2.groups.io,AbdulLateef.Attar@amd.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 9gxGIq5n0rWEz8HZdZE3nii4x7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=Ci8MZOHh; dmarc=pass (policy=none) header.from=groups.io; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io Hi Pierre and Sami, =C2=A0=C2=A0=C2=A0 I'll submit separate patches for each table, which will= be ready=20 and easy to merge after the current hard feature freeze over. Thanks AbduL On 03-05-2024 13:11, Sami Mujawar wrote: > Caution: This message originated from an External Source. Use proper caut= ion when opening attachments, clicking links, or responding. > > > Hi All, > > Please find my response inline marked [SAMI]. > > Regards, > > Sami Mujawar > > =EF=BB=BFOn 02/05/2024, 17:36, "Pierre Gondois" > wrote: > > > Hello Abdul, > I added some comments. > I think that: > a. patches related to HPET/WSMT should require little work > b. MADT patch needs to redefine the CmObjects it uses, > but it seems ok otherwise (just need to have the right properties > in the right objects), > c. FADT patch is re-defining CmObjects that are already existing > in ArmNameSpaceObjects.h. So there is going to be a clash with > ongoing DynamicTables objects reorganization... > > > I think that a. could be sent separately and should quickly go in, > b. might require a bit more checking/reviewing, and c. might need > to wait for the re-org to be finished, unless Sami thinks it's ok > to take the patch, > [SAMI] For c., I think we should not wait for the reorg to be completed. = The FADT patch can go it the mainline if it passes the review. > The additional work would be to reorg this patch on the staging branch wh= en rebasing with the edk2 mainline code. However, this can be addressed jus= t before we merge the first set of reorg changes into mainline. > [/SAMI] > > > Regards, > Pierre > > > > > On 4/29/24 08:03, Abdul Lateef Attar wrote: >> PR: https://github.com/tianocore/edk2/pull/5500/ >> V4: delta changes >> Added X64 arch specific MADT table generator. >> V3: delta changes >> Restructure the code as the review comments. >> Added sanity check for WSMT flags. >> Added CM object for HPET base address. >> V2: delta changes >> Addressed review comments >> Adds ACPI HPET table to add HPET to ACPI namespace >> V1: >> Adds new space for ArchNameSpaceObjects. >> Adds generic FADT table generator. >> Adds generic HPET table generator. >> Adds generic WSMT table generator. >> >> Cc: Sami Mujawar > >> Cc: Pierre Gondois > >> Cc: Abdul Lateef Attar > >> >> Abdul Lateef Attar (5): >> DynamicTablesPkg: Adds ACPI FADT Table generator >> DynamicTablesPkg: Adds ACPI HPET Table generator >> DynamicTablesPkg: Adds ACPI WSMT Table generator >> DynamicTablesPkg: Adds ACPI SSDT HPET Table generator >> DynamicTablesPkg: Adds X64 arch MADT Table generator >> >> DynamicTablesPkg/DynamicTables.dsc.inc | 22 +- >> DynamicTablesPkg/DynamicTablesPkg.ci.yaml | 4 +- >> DynamicTablesPkg/Include/AcpiTableGenerator.h | 4 + >> .../Include/ArchNameSpaceObjects.h | 237 ++++++ >> .../Include/ConfigurationManagerObject.h | 7 + >> .../Include/X64NameSpaceObjects.h | 48 ++ >> .../Library/Acpi/AcpiFadtLib/AcpiFadtLib.inf | 36 + >> .../Library/Acpi/AcpiFadtLib/Arm/FadtUpdate.c | 39 + >> .../Library/Acpi/AcpiFadtLib/FadtGenerator.c | 745 ++++++++++++++++++ >> .../Library/Acpi/AcpiFadtLib/FadtUpdate.h | 26 + >> .../Library/Acpi/AcpiFadtLib/X64/FadtUpdate.c | 32 + >> .../Library/Acpi/AcpiHpetLib/AcpiHpetLib.inf | 31 + >> .../Library/Acpi/AcpiHpetLib/HpetGenerator.c | 246 ++++++ >> .../Acpi/AcpiSsdtHpetLib/AcpiSsdtHpetLib.inf | 32 + >> .../Acpi/AcpiSsdtHpetLib/SsdtHpetGenerator.c | 295 +++++++ >> .../Library/Acpi/AcpiWsmtLib/AcpiWsmtLib.inf | 30 + >> .../Library/Acpi/AcpiWsmtLib/WsmtGenerator.c | 243 ++++++ >> .../X64/AcpiMadtLibX64/AcpiMadtLibX64.inf | 27 + >> .../Acpi/X64/AcpiMadtLibX64/MadtGenerator.c | 375 +++++++++ >> 19 files changed, 2477 insertions(+), 2 deletions(-) >> create mode 100644 DynamicTablesPkg/Include/ArchNameSpaceObjects.h >> create mode 100644 DynamicTablesPkg/Include/X64NameSpaceObjects.h >> create mode 100644 DynamicTablesPkg/Library/Acpi/AcpiFadtLib/AcpiFadtLib= .inf >> create mode 100644 DynamicTablesPkg/Library/Acpi/AcpiFadtLib/Arm/FadtUpd= ate.c >> create mode 100644 DynamicTablesPkg/Library/Acpi/AcpiFadtLib/FadtGenerat= or.c >> create mode 100644 DynamicTablesPkg/Library/Acpi/AcpiFadtLib/FadtUpdate.= h >> create mode 100644 DynamicTablesPkg/Library/Acpi/AcpiFadtLib/X64/FadtUpd= ate.c >> create mode 100644 DynamicTablesPkg/Library/Acpi/AcpiHpetLib/AcpiHpetLib= .inf >> create mode 100644 DynamicTablesPkg/Library/Acpi/AcpiHpetLib/HpetGenerat= or.c >> create mode 100644 DynamicTablesPkg/Library/Acpi/AcpiSsdtHpetLib/AcpiSsd= tHpetLib.inf >> create mode 100644 DynamicTablesPkg/Library/Acpi/AcpiSsdtHpetLib/SsdtHpe= tGenerator.c >> create mode 100644 DynamicTablesPkg/Library/Acpi/AcpiWsmtLib/AcpiWsmtLib= .inf >> create mode 100644 DynamicTablesPkg/Library/Acpi/AcpiWsmtLib/WsmtGenerat= or.c >> create mode 100644 DynamicTablesPkg/Library/Acpi/X64/AcpiMadtLibX64/Acpi= MadtLibX64.inf >> create mode 100644 DynamicTablesPkg/Library/Acpi/X64/AcpiMadtLibX64/Madt= Generator.c >> > > > IMPORTANT NOTICE: The contents of this email and any attachments are conf= idential and may also be privileged. If you are not the intended recipient,= please notify the sender immediately and do not disclose the contents to a= ny other person, use it for any purpose, or store or copy the information i= n any medium. Thank you. -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#118855): https://edk2.groups.io/g/devel/message/118855 Mute This Topic: https://groups.io/mt/105796049/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-