public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Xiaoyu Lu" <xiaoyux.lu@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
	"newexplorerj@gmail.com" <newexplorerj@gmail.com>
Cc: "Wang, Jian J" <jian.j.wang@intel.com>
Subject: Re: [edk2-devel] [PATCH v2 1/2] CryptoPkg/BaseCryptLibOnProtocolPpi: Add missing comments
Date: Fri, 27 Mar 2020 09:23:31 +0000	[thread overview]
Message-ID: <0d8e612c7cd94fe0b3a29fc24050c80b@intel.com> (raw)
In-Reply-To: <2731dd841ca22bf605f0c115ff779cb1e6f7b926.1583390439.git.newexplorerj@gmail.com>

Reviewed-by: Xiaoyu Lu <xiaoyux.lu@intel.com>

> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> GuoMinJ
> Sent: Thursday, March 5, 2020 2:41 PM
> To: devel@edk2.groups.io
> Cc: GuoMinJ <newexplorerj@gmail.com>; Wang, Jian J
> <jian.j.wang@intel.com>; Lu, XiaoyuX <xiaoyux.lu@intel.com>
> Subject: [edk2-devel] [PATCH v2 1/2] CryptoPkg/BaseCryptLibOnProtocolPpi:
> Add missing comments
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2552
> 
> DxeCryptLibConstructor have no comments for it, add comments for it.
> 
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Xiaoyu Lu <xiaoyux.lu@intel.com>
> Signed-off-by: GuoMinJ <newexplorerj@gmail.com>
> ---
>  .../Library/BaseCryptLibOnProtocolPpi/DxeCryptLib.c      | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/CryptoPkg/Library/BaseCryptLibOnProtocolPpi/DxeCryptLib.c
> b/CryptoPkg/Library/BaseCryptLibOnProtocolPpi/DxeCryptLib.c
> index 34d5f410b0..b503a5708b 100644
> --- a/CryptoPkg/Library/BaseCryptLibOnProtocolPpi/DxeCryptLib.c
> +++ b/CryptoPkg/Library/BaseCryptLibOnProtocolPpi/DxeCryptLib.c
> @@ -32,6 +32,15 @@ GetCryptoServices (
>    return (VOID *)mCryptoProtocol;
>  }
> 
> +/**
> +  Locate the valid Crypto Protocol.
> +
> +  @param  ImageHandle   The firmware allocated handle for the EFI image.
> +  @param  SystemTable   A pointer to the EFI System Table.
> +
> +  @retval EFI_SUCCESS   The constructor executed correctly.
> +  @retval EFI_NOT_FOUND Found no valid Crypto Protocol.
> +**/
>  EFI_STATUS
>  EFIAPI
>  DxeCryptLibConstructor (
> --
> 2.17.1
> 
> 
> 


      parent reply	other threads:[~2020-03-27  9:23 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-05  6:40 [PATCH v2 1/2] CryptoPkg/BaseCryptLibOnProtocolPpi: Add missing comments GuoMinJ
2020-03-05  6:40 ` [PATCH v2 2/2] CryptoPkg/BaseHashApiLib: Rename BaseHashApiLib by HashApiLib GuoMinJ
2020-03-12  5:53   ` [edk2-devel] " Zhang, Shenglei
2020-03-17  0:16     ` Liming Gao
2020-03-27  9:23   ` Xiaoyu Lu
2020-03-12  5:49 ` [edk2-devel] [PATCH v2 1/2] CryptoPkg/BaseCryptLibOnProtocolPpi: Add missing comments Zhang, Shenglei
2020-03-17  0:14   ` Liming Gao
2020-03-27  9:23 ` Xiaoyu Lu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0d8e612c7cd94fe0b3a29fc24050c80b@intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox