[PATCH v2 1/2] CryptoPkg/BaseCryptLibOnProtocolPpi: Add missing comments

[PATCH v2 1/2] CryptoPkg/BaseCryptLibOnProtocolPpi: Add missing comments

[GuoMinJ]

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2552

DxeCryptLibConstructor have no comments for it, add comments for it.

Cc: Jian J Wang <jian.j.wang@intel.com>
Cc: Xiaoyu Lu <xiaoyux.lu@intel.com>
Signed-off-by: GuoMinJ <newexplorerj@gmail.com>
---
 .../Library/BaseCryptLibOnProtocolPpi/DxeCryptLib.c      | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/CryptoPkg/Library/BaseCryptLibOnProtocolPpi/DxeCryptLib.c b/CryptoPkg/Library/BaseCryptLibOnProtocolPpi/DxeCryptLib.c
index 34d5f410b0..b503a5708b 100644
--- a/CryptoPkg/Library/BaseCryptLibOnProtocolPpi/DxeCryptLib.c
+++ b/CryptoPkg/Library/BaseCryptLibOnProtocolPpi/DxeCryptLib.c
@@ -32,6 +32,15 @@ GetCryptoServices (
   return (VOID *)mCryptoProtocol;
 }
 
+/**
+  Locate the valid Crypto Protocol.
+
+  @param  ImageHandle   The firmware allocated handle for the EFI image.
+  @param  SystemTable   A pointer to the EFI System Table.
+
+  @retval EFI_SUCCESS   The constructor executed correctly.
+  @retval EFI_NOT_FOUND Found no valid Crypto Protocol.
+**/
 EFI_STATUS
 EFIAPI
 DxeCryptLibConstructor (
-- 
2.17.1

[PATCH v2 2/2] CryptoPkg/BaseHashApiLib: Rename BaseHashApiLib by HashApiLib

[GuoMinJ]

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2552

According to CryptoPkg.dsc, the library class only have HashApiLib, so i
think the BaseHashApiLib should be considered as base name rather than
library class.

Cc: Jian J Wang <jian.j.wang@intel.com>
Cc: Xiaoyu Lu <xiaoyux.lu@intel.com>
Signed-off-by: GuoMinJ <newexplorerj@gmail.com>
---
 CryptoPkg/Library/BaseHashApiLib/BaseHashApiLib.inf | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/CryptoPkg/Library/BaseHashApiLib/BaseHashApiLib.inf b/CryptoPkg/Library/BaseHashApiLib/BaseHashApiLib.inf
index b4d8675ddd..046320353b 100644
--- a/CryptoPkg/Library/BaseHashApiLib/BaseHashApiLib.inf
+++ b/CryptoPkg/Library/BaseHashApiLib/BaseHashApiLib.inf
@@ -17,7 +17,7 @@
   FILE_GUID                      = B1E566DD-DE7C-4F04-BDA0-B1295D3BE927
   MODULE_TYPE                    = BASE
   VERSION_STRING                 = 1.0
-  LIBRARY_CLASS                  = BaseHashApiLib
+  LIBRARY_CLASS                  = HashApiLib
 
 #
 # The following information is for reference only and not required by the build tools.
-- 
2.17.1

Re: [edk2-devel] [PATCH v2 1/2] CryptoPkg/BaseCryptLibOnProtocolPpi: Add missing comments

[Zhang, Shenglei]

Reviewed-by: Shenglei Zhang <shenglei.zhang@intel.com>

> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> GuoMinJ
> Sent: Thursday, March 5, 2020 2:41 PM
> To: devel@edk2.groups.io
> Cc: GuoMinJ <newexplorerj@gmail.com>; Wang, Jian J
> <jian.j.wang@intel.com>; Lu, XiaoyuX <xiaoyux.lu@intel.com>
> Subject: [edk2-devel] [PATCH v2 1/2] CryptoPkg/BaseCryptLibOnProtocolPpi:
> Add missing comments
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2552
> 
> DxeCryptLibConstructor have no comments for it, add comments for it.
> 
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Xiaoyu Lu <xiaoyux.lu@intel.com>
> Signed-off-by: GuoMinJ <newexplorerj@gmail.com>
> ---
>  .../Library/BaseCryptLibOnProtocolPpi/DxeCryptLib.c      | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/CryptoPkg/Library/BaseCryptLibOnProtocolPpi/DxeCryptLib.c
> b/CryptoPkg/Library/BaseCryptLibOnProtocolPpi/DxeCryptLib.c
> index 34d5f410b0..b503a5708b 100644
> --- a/CryptoPkg/Library/BaseCryptLibOnProtocolPpi/DxeCryptLib.c
> +++ b/CryptoPkg/Library/BaseCryptLibOnProtocolPpi/DxeCryptLib.c
> @@ -32,6 +32,15 @@ GetCryptoServices (
>    return (VOID *)mCryptoProtocol;
>  }
> 
> +/**
> +  Locate the valid Crypto Protocol.
> +
> +  @param  ImageHandle   The firmware allocated handle for the EFI image.
> +  @param  SystemTable   A pointer to the EFI System Table.
> +
> +  @retval EFI_SUCCESS   The constructor executed correctly.
> +  @retval EFI_NOT_FOUND Found no valid Crypto Protocol.
> +**/
>  EFI_STATUS
>  EFIAPI
>  DxeCryptLibConstructor (
> --
> 2.17.1
> 
> 
> 

Re: [edk2-devel] [PATCH v2 2/2] CryptoPkg/BaseHashApiLib: Rename BaseHashApiLib by HashApiLib

[Zhang, Shenglei]

Reviewed-by: Shenglei Zhang <shenglei.zhang@intel.com>

> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> GuoMinJ
> Sent: Thursday, March 5, 2020 2:41 PM
> To: devel@edk2.groups.io
> Cc: GuoMinJ <newexplorerj@gmail.com>; Wang, Jian J
> <jian.j.wang@intel.com>; Lu, XiaoyuX <xiaoyux.lu@intel.com>
> Subject: [edk2-devel] [PATCH v2 2/2] CryptoPkg/BaseHashApiLib: Rename
> BaseHashApiLib by HashApiLib
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2552
> 
> According to CryptoPkg.dsc, the library class only have HashApiLib, so i
> think the BaseHashApiLib should be considered as base name rather than
> library class.
> 
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Xiaoyu Lu <xiaoyux.lu@intel.com>
> Signed-off-by: GuoMinJ <newexplorerj@gmail.com>
> ---
>  CryptoPkg/Library/BaseHashApiLib/BaseHashApiLib.inf | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/CryptoPkg/Library/BaseHashApiLib/BaseHashApiLib.inf
> b/CryptoPkg/Library/BaseHashApiLib/BaseHashApiLib.inf
> index b4d8675ddd..046320353b 100644
> --- a/CryptoPkg/Library/BaseHashApiLib/BaseHashApiLib.inf
> +++ b/CryptoPkg/Library/BaseHashApiLib/BaseHashApiLib.inf
> @@ -17,7 +17,7 @@
>    FILE_GUID                      = B1E566DD-DE7C-4F04-BDA0-B1295D3BE927
>    MODULE_TYPE                    = BASE
>    VERSION_STRING                 = 1.0
> -  LIBRARY_CLASS                  = BaseHashApiLib
> +  LIBRARY_CLASS                  = HashApiLib
> 
>  #
>  # The following information is for reference only and not required by the
> build tools.
> --
> 2.17.1
> 
> 
> 

Re: [edk2-devel] [PATCH v2 1/2] CryptoPkg/BaseCryptLibOnProtocolPpi: Add missing comments

[Liming Gao]

@Jian, Xiao, can you review this change also?

Reviewed-by: Liming Gao <liming.gao@intel.com>

-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Zhang, Shenglei
Sent: 2020年3月12日 13:49
To: devel@edk2.groups.io; newexplorerj@gmail.com
Cc: Wang, Jian J <jian.j.wang@intel.com>; Lu, XiaoyuX <xiaoyux.lu@intel.com>
Subject: Re: [edk2-devel] [PATCH v2 1/2] CryptoPkg/BaseCryptLibOnProtocolPpi: Add missing comments

Reviewed-by: Shenglei Zhang <shenglei.zhang@intel.com>

> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of 
> GuoMinJ
> Sent: Thursday, March 5, 2020 2:41 PM
> To: devel@edk2.groups.io
> Cc: GuoMinJ <newexplorerj@gmail.com>; Wang, Jian J 
> <jian.j.wang@intel.com>; Lu, XiaoyuX <xiaoyux.lu@intel.com>
> Subject: [edk2-devel] [PATCH v2 1/2] CryptoPkg/BaseCryptLibOnProtocolPpi:
> Add missing comments
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2552
> 
> DxeCryptLibConstructor have no comments for it, add comments for it.
> 
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Xiaoyu Lu <xiaoyux.lu@intel.com>
> Signed-off-by: GuoMinJ <newexplorerj@gmail.com>
> ---
>  .../Library/BaseCryptLibOnProtocolPpi/DxeCryptLib.c      | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/CryptoPkg/Library/BaseCryptLibOnProtocolPpi/DxeCryptLib.c
> b/CryptoPkg/Library/BaseCryptLibOnProtocolPpi/DxeCryptLib.c
> index 34d5f410b0..b503a5708b 100644
> --- a/CryptoPkg/Library/BaseCryptLibOnProtocolPpi/DxeCryptLib.c
> +++ b/CryptoPkg/Library/BaseCryptLibOnProtocolPpi/DxeCryptLib.c
> @@ -32,6 +32,15 @@ GetCryptoServices (
>    return (VOID *)mCryptoProtocol;
>  }
> 
> +/**
> +  Locate the valid Crypto Protocol.
> +
> +  @param  ImageHandle   The firmware allocated handle for the EFI image.
> +  @param  SystemTable   A pointer to the EFI System Table.
> +
> +  @retval EFI_SUCCESS   The constructor executed correctly.
> +  @retval EFI_NOT_FOUND Found no valid Crypto Protocol.
> +**/
>  EFI_STATUS
>  EFIAPI
>  DxeCryptLibConstructor (
> --
> 2.17.1
> 
> 
> 

Re: [edk2-devel] [PATCH v2 2/2] CryptoPkg/BaseHashApiLib: Rename BaseHashApiLib by HashApiLib

[Liming Gao]

@Jian, Xiaoyu: can you review this change?

Good catch. Reviewed-by: Liming Gao <liming.gao@intel.com>

-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Zhang, Shenglei
Sent: 2020年3月12日 13:53
To: devel@edk2.groups.io; newexplorerj@gmail.com
Cc: Wang, Jian J <jian.j.wang@intel.com>; Lu, XiaoyuX <xiaoyux.lu@intel.com>
Subject: Re: [edk2-devel] [PATCH v2 2/2] CryptoPkg/BaseHashApiLib: Rename BaseHashApiLib by HashApiLib

Reviewed-by: Shenglei Zhang <shenglei.zhang@intel.com>

> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of 
> GuoMinJ
> Sent: Thursday, March 5, 2020 2:41 PM
> To: devel@edk2.groups.io
> Cc: GuoMinJ <newexplorerj@gmail.com>; Wang, Jian J 
> <jian.j.wang@intel.com>; Lu, XiaoyuX <xiaoyux.lu@intel.com>
> Subject: [edk2-devel] [PATCH v2 2/2] CryptoPkg/BaseHashApiLib: Rename 
> BaseHashApiLib by HashApiLib
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2552
> 
> According to CryptoPkg.dsc, the library class only have HashApiLib, so 
> i think the BaseHashApiLib should be considered as base name rather 
> than library class.
> 
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Xiaoyu Lu <xiaoyux.lu@intel.com>
> Signed-off-by: GuoMinJ <newexplorerj@gmail.com>
> ---
>  CryptoPkg/Library/BaseHashApiLib/BaseHashApiLib.inf | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/CryptoPkg/Library/BaseHashApiLib/BaseHashApiLib.inf
> b/CryptoPkg/Library/BaseHashApiLib/BaseHashApiLib.inf
> index b4d8675ddd..046320353b 100644
> --- a/CryptoPkg/Library/BaseHashApiLib/BaseHashApiLib.inf
> +++ b/CryptoPkg/Library/BaseHashApiLib/BaseHashApiLib.inf
> @@ -17,7 +17,7 @@
>    FILE_GUID                      = B1E566DD-DE7C-4F04-BDA0-B1295D3BE927
>    MODULE_TYPE                    = BASE
>    VERSION_STRING                 = 1.0
> -  LIBRARY_CLASS                  = BaseHashApiLib
> +  LIBRARY_CLASS                  = HashApiLib
> 
>  #
>  # The following information is for reference only and not required by 
> the build tools.
> --
> 2.17.1
> 
> 
> 

Re: [PATCH v2 2/2] CryptoPkg/BaseHashApiLib: Rename BaseHashApiLib by HashApiLib

[Xiaoyu Lu]

Reviewed-by: Xiaoyu Lu <xiaoyux.lu@intel.com>

> -----Original Message-----
> From: GuoMinJ [mailto:newexplorerj@gmail.com]
> Sent: Thursday, March 5, 2020 2:41 PM
> To: devel@edk2.groups.io
> Cc: GuoMinJ <newexplorerj@gmail.com>; Wang, Jian J
> <jian.j.wang@intel.com>; Lu, XiaoyuX <xiaoyux.lu@intel.com>
> Subject: [PATCH v2 2/2] CryptoPkg/BaseHashApiLib: Rename BaseHashApiLib
> by HashApiLib
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2552
> 
> According to CryptoPkg.dsc, the library class only have HashApiLib, so i
> think the BaseHashApiLib should be considered as base name rather than
> library class.
> 
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Xiaoyu Lu <xiaoyux.lu@intel.com>
> Signed-off-by: GuoMinJ <newexplorerj@gmail.com>
> ---
>  CryptoPkg/Library/BaseHashApiLib/BaseHashApiLib.inf | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/CryptoPkg/Library/BaseHashApiLib/BaseHashApiLib.inf
> b/CryptoPkg/Library/BaseHashApiLib/BaseHashApiLib.inf
> index b4d8675ddd..046320353b 100644
> --- a/CryptoPkg/Library/BaseHashApiLib/BaseHashApiLib.inf
> +++ b/CryptoPkg/Library/BaseHashApiLib/BaseHashApiLib.inf
> @@ -17,7 +17,7 @@
>    FILE_GUID                      = B1E566DD-DE7C-4F04-BDA0-B1295D3BE927
>    MODULE_TYPE                    = BASE
>    VERSION_STRING                 = 1.0
> -  LIBRARY_CLASS                  = BaseHashApiLib
> +  LIBRARY_CLASS                  = HashApiLib
> 
>  #
>  # The following information is for reference only and not required by the
> build tools.
> --
> 2.17.1

Re: [edk2-devel] [PATCH v2 1/2] CryptoPkg/BaseCryptLibOnProtocolPpi: Add missing comments

[Xiaoyu Lu]

Reviewed-by: Xiaoyu Lu <xiaoyux.lu@intel.com>

> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> GuoMinJ
> Sent: Thursday, March 5, 2020 2:41 PM
> To: devel@edk2.groups.io
> Cc: GuoMinJ <newexplorerj@gmail.com>; Wang, Jian J
> <jian.j.wang@intel.com>; Lu, XiaoyuX <xiaoyux.lu@intel.com>
> Subject: [edk2-devel] [PATCH v2 1/2] CryptoPkg/BaseCryptLibOnProtocolPpi:
> Add missing comments
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2552
> 
> DxeCryptLibConstructor have no comments for it, add comments for it.
> 
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Xiaoyu Lu <xiaoyux.lu@intel.com>
> Signed-off-by: GuoMinJ <newexplorerj@gmail.com>
> ---
>  .../Library/BaseCryptLibOnProtocolPpi/DxeCryptLib.c      | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/CryptoPkg/Library/BaseCryptLibOnProtocolPpi/DxeCryptLib.c
> b/CryptoPkg/Library/BaseCryptLibOnProtocolPpi/DxeCryptLib.c
> index 34d5f410b0..b503a5708b 100644
> --- a/CryptoPkg/Library/BaseCryptLibOnProtocolPpi/DxeCryptLib.c
> +++ b/CryptoPkg/Library/BaseCryptLibOnProtocolPpi/DxeCryptLib.c
> @@ -32,6 +32,15 @@ GetCryptoServices (
>    return (VOID *)mCryptoProtocol;
>  }
> 
> +/**
> +  Locate the valid Crypto Protocol.
> +
> +  @param  ImageHandle   The firmware allocated handle for the EFI image.
> +  @param  SystemTable   A pointer to the EFI System Table.
> +
> +  @retval EFI_SUCCESS   The constructor executed correctly.
> +  @retval EFI_NOT_FOUND Found no valid Crypto Protocol.
> +**/
>  EFI_STATUS
>  EFIAPI
>  DxeCryptLibConstructor (
> --
> 2.17.1
> 
> 
>