From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mx.groups.io with SMTP id smtpd.web12.7867.1585301014209096767 for ; Fri, 27 Mar 2020 02:23:34 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.136, mailfrom: xiaoyux.lu@intel.com) IronPort-SDR: q0ZTZhAwtVCO7IzH3z1yI0YIItNkbzz+yj65QFuNHle6311Pe25DSG03iM7SzGsc2MVfyrzXQp HPnaNs7hj56g== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Mar 2020 02:23:34 -0700 IronPort-SDR: 1mY7aq9Rk1xCBs9s1SxnYBy9XH6fKiP+I092eTvBAX8wI8Lc7gC8a6RMAHCQ80y9Xd7tnfQSCD eiZMzxuF9HsQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,311,1580803200"; d="scan'208";a="448948932" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by fmsmga006.fm.intel.com with ESMTP; 27 Mar 2020 02:23:34 -0700 Received: from shsmsx602.ccr.corp.intel.com (10.109.6.142) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 27 Mar 2020 02:23:33 -0700 Received: from shsmsx603.ccr.corp.intel.com (10.109.6.143) by SHSMSX602.ccr.corp.intel.com (10.109.6.142) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Fri, 27 Mar 2020 17:23:31 +0800 Received: from shsmsx603.ccr.corp.intel.com ([10.109.6.143]) by SHSMSX603.ccr.corp.intel.com ([10.109.6.143]) with mapi id 15.01.1713.004; Fri, 27 Mar 2020 17:23:31 +0800 From: "Xiaoyu Lu" To: "devel@edk2.groups.io" , "newexplorerj@gmail.com" CC: "Wang, Jian J" Subject: Re: [edk2-devel] [PATCH v2 1/2] CryptoPkg/BaseCryptLibOnProtocolPpi: Add missing comments Thread-Topic: [edk2-devel] [PATCH v2 1/2] CryptoPkg/BaseCryptLibOnProtocolPpi: Add missing comments Thread-Index: AQHV8rknW1UFCetwC0iMcPG12uthFqhcR0KA Date: Fri, 27 Mar 2020 09:23:31 +0000 Message-ID: <0d8e612c7cd94fe0b3a29fc24050c80b@intel.com> References: <2731dd841ca22bf605f0c115ff779cb1e6f7b926.1583390439.git.newexplorerj@gmail.com> In-Reply-To: <2731dd841ca22bf605f0c115ff779cb1e6f7b926.1583390439.git.newexplorerj@gmail.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.36] MIME-Version: 1.0 Return-Path: xiaoyux.lu@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Xiaoyu Lu > -----Original Message----- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > GuoMinJ > Sent: Thursday, March 5, 2020 2:41 PM > To: devel@edk2.groups.io > Cc: GuoMinJ ; Wang, Jian J > ; Lu, XiaoyuX > Subject: [edk2-devel] [PATCH v2 1/2] CryptoPkg/BaseCryptLibOnProtocolPpi= : > Add missing comments >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2552 >=20 > DxeCryptLibConstructor have no comments for it, add comments for it. >=20 > Cc: Jian J Wang > Cc: Xiaoyu Lu > Signed-off-by: GuoMinJ > --- > .../Library/BaseCryptLibOnProtocolPpi/DxeCryptLib.c | 9 +++++++++ > 1 file changed, 9 insertions(+) >=20 > diff --git a/CryptoPkg/Library/BaseCryptLibOnProtocolPpi/DxeCryptLib.c > b/CryptoPkg/Library/BaseCryptLibOnProtocolPpi/DxeCryptLib.c > index 34d5f410b0..b503a5708b 100644 > --- a/CryptoPkg/Library/BaseCryptLibOnProtocolPpi/DxeCryptLib.c > +++ b/CryptoPkg/Library/BaseCryptLibOnProtocolPpi/DxeCryptLib.c > @@ -32,6 +32,15 @@ GetCryptoServices ( > return (VOID *)mCryptoProtocol; > } >=20 > +/** > + Locate the valid Crypto Protocol. > + > + @param ImageHandle The firmware allocated handle for the EFI image= . > + @param SystemTable A pointer to the EFI System Table. > + > + @retval EFI_SUCCESS The constructor executed correctly. > + @retval EFI_NOT_FOUND Found no valid Crypto Protocol. > +**/ > EFI_STATUS > EFIAPI > DxeCryptLibConstructor ( > -- > 2.17.1 >=20 >=20 >=20