From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: devel@edk2.groups.io, pete@akeo.ie
Cc: ard.biesheuvel@linaro.org, leif.lindholm@linaro.org
Subject: Re: [edk2-devel] [edk2-platforms][PATCH 1/1] RPi3/PlatformSmbiosDxe: Fix use of invalid debug facility
Date: Wed, 16 Oct 2019 13:56:15 +0200 [thread overview]
Message-ID: <0d98e7b4-b959-7bb6-e314-c4b2cbc6c7e6@redhat.com> (raw)
In-Reply-To: <20191016114341.10732-1-pete@akeo.ie>
On 10/16/19 1:43 PM, Pete Batard wrote:
> DEBUG_WARNING was invalid. DEBUG_WARN is the proper channel name to use.
Oops.
Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>
>
> Signed-off-by: Pete Batard <pete@akeo.ie>
> ---
> Platform/RaspberryPi/RPi3/Drivers/PlatformSmbiosDxe/PlatformSmbiosDxe.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Platform/RaspberryPi/RPi3/Drivers/PlatformSmbiosDxe/PlatformSmbiosDxe.c b/Platform/RaspberryPi/RPi3/Drivers/PlatformSmbiosDxe/PlatformSmbiosDxe.c
> index 5abc82b8d363..c72a749b6a2a 100644
> --- a/Platform/RaspberryPi/RPi3/Drivers/PlatformSmbiosDxe/PlatformSmbiosDxe.c
> +++ b/Platform/RaspberryPi/RPi3/Drivers/PlatformSmbiosDxe/PlatformSmbiosDxe.c
> @@ -874,7 +874,7 @@ MemArrMapInfoUpdateSmbiosType19 (
> mMemArrMapInfoType19.EndingAddress = 256 * 1024;
> Status = mFwProtocol->GetModelRevision (&BoardRevision);
> if (Status != EFI_SUCCESS) {
> - DEBUG ((DEBUG_WARNING, "Couldn't get the board memory size - defaulting to 256 MB: %r\n", Status));
> + DEBUG ((DEBUG_WARN, "Couldn't get the board memory size - defaulting to 256 MB: %r\n", Status));
> } else {
> // www.raspberrypi.org/documentation/hardware/raspberrypi/revision-codes/README.md
> // Bits [20-22] indicate the amount of memory starting with 256MB (000b)
>
next prev parent reply other threads:[~2019-10-16 11:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-16 11:43 [edk2-platforms][PATCH 1/1] RPi3/PlatformSmbiosDxe: Fix use of invalid debug facility Pete Batard
2019-10-16 11:56 ` Philippe Mathieu-Daudé [this message]
2019-10-16 13:24 ` [edk2-devel] " Leif Lindholm
2019-10-16 13:35 ` Pete Batard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0d98e7b4-b959-7bb6-e314-c4b2cbc6c7e6@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox