From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.120]) by mx.groups.io with SMTP id smtpd.web12.4104.1571226981250862842 for ; Wed, 16 Oct 2019 04:56:21 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=gTA2quqV; spf=pass (domain: redhat.com, ip: 205.139.110.120, mailfrom: philmd@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1571226980; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dsf4cJwzvTu52k5iJOxr2xEx0KrCzS/ZWfYrxJa/pwo=; b=gTA2quqV8S5FT9ck3r/7HtgIq31RIWjYc80AnrB+Feq/TyVuoghiOCkJ8prsHxaRbsGXWJ 3I5tphkrxZrljdsrWre+Ujzw81GisRHqb/LtQ6lqaum/Q1lTDgDIucotnDFZbSw+6TW6J7 DHGgalwOi7PRVHzRzkGGTHZIjMnCRKE= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-316-N3HZcItuNLaIDs9C5b8RQw-1; Wed, 16 Oct 2019 07:56:18 -0400 Received: by mail-wm1-f71.google.com with SMTP id m6so893742wmf.2 for ; Wed, 16 Oct 2019 04:56:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=8cAMWasQbirGgL6cLw+rm7qGbd5Ik2oKdduOjtV//xg=; b=tSArcCD5krh9suSwrzGBmS0/odu1CtMeHEQv/ocGbkK6hVuY7TXPNd5n6wF99JKBQr 4kwzk6G3MaNA8PUYr2IXVfFyYCMDyQZy6yLohQpY+A34d1J3HbJhVFZwMliFqMiRb+ET RjiVPCp5orz5CYWLSyiF1Dbn/mMRfeVxu5xBmiYAK6gsiWy1V7ZVaIRAhFcTW14Z7Kh4 FiREeT3nB66U03+c5qXx9fEJsms7GSwlm6XZaUpArDkrfpaAV7DmVGHOYC7D7B6BEERs /AhVBdlGKo2GUbSPXhvDUeWSmHSJWrlMunjedxc6etX25dLu6dSiJdEilL4rmx6wxUZD VEFg== X-Gm-Message-State: APjAAAXH957SfCS9FpMwQht0CZKDvPFBmxjynhoRCHeX00v15drrD6ID nYxjZoHbKLBB/Xq7IBOily7tXWAr8hrpupGSzJXFy9sDUhw5gr3pZ43YF0xYLXw2OarrRDaib9+ KoVjcoVUJ6DJ1yA== X-Received: by 2002:a1c:7c0a:: with SMTP id x10mr3099574wmc.48.1571226977416; Wed, 16 Oct 2019 04:56:17 -0700 (PDT) X-Google-Smtp-Source: APXvYqwB5RLr0J9776ChPKOphdcNv0NheFFBzPQRTrEH5bmtikCJ3FqgG/AvXTr+Nv6XvnHwXAnKwQ== X-Received: by 2002:a1c:7c0a:: with SMTP id x10mr3099560wmc.48.1571226977215; Wed, 16 Oct 2019 04:56:17 -0700 (PDT) Return-Path: Received: from [192.168.1.36] (14.red-88-21-201.staticip.rima-tde.net. [88.21.201.14]) by smtp.gmail.com with ESMTPSA id q66sm2554006wme.39.2019.10.16.04.56.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 16 Oct 2019 04:56:16 -0700 (PDT) Subject: Re: [edk2-devel] [edk2-platforms][PATCH 1/1] RPi3/PlatformSmbiosDxe: Fix use of invalid debug facility To: devel@edk2.groups.io, pete@akeo.ie Cc: ard.biesheuvel@linaro.org, leif.lindholm@linaro.org References: <20191016114341.10732-1-pete@akeo.ie> From: =?UTF-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= Message-ID: <0d98e7b4-b959-7bb6-e314-c4b2cbc6c7e6@redhat.com> Date: Wed, 16 Oct 2019 13:56:15 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.0 MIME-Version: 1.0 In-Reply-To: <20191016114341.10732-1-pete@akeo.ie> X-MC-Unique: N3HZcItuNLaIDs9C5b8RQw-1 X-Mimecast-Spam-Score: 0 Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable On 10/16/19 1:43 PM, Pete Batard wrote: > DEBUG_WARNING was invalid. DEBUG_WARN is the proper channel name to use. Oops. Reviewed-by: Philippe Mathieu-Daude >=20 > Signed-off-by: Pete Batard > --- > Platform/RaspberryPi/RPi3/Drivers/PlatformSmbiosDxe/PlatformSmbiosDxe.c= | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/Platform/RaspberryPi/RPi3/Drivers/PlatformSmbiosDxe/Platform= SmbiosDxe.c b/Platform/RaspberryPi/RPi3/Drivers/PlatformSmbiosDxe/PlatformS= mbiosDxe.c > index 5abc82b8d363..c72a749b6a2a 100644 > --- a/Platform/RaspberryPi/RPi3/Drivers/PlatformSmbiosDxe/PlatformSmbiosD= xe.c > +++ b/Platform/RaspberryPi/RPi3/Drivers/PlatformSmbiosDxe/PlatformSmbiosD= xe.c > @@ -874,7 +874,7 @@ MemArrMapInfoUpdateSmbiosType19 ( > mMemArrMapInfoType19.EndingAddress =3D 256 * 1024; > Status =3D mFwProtocol->GetModelRevision (&BoardRevision); > if (Status !=3D EFI_SUCCESS) { > - DEBUG ((DEBUG_WARNING, "Couldn't get the board memory size - default= ing to 256 MB: %r\n", Status)); > + DEBUG ((DEBUG_WARN, "Couldn't get the board memory size - defaulting= to 256 MB: %r\n", Status)); > } else { > // www.raspberrypi.org/documentation/hardware/raspberrypi/revision-= codes/README.md > // Bits [20-22] indicate the amount of memory starting with 256MB (= 000b) >=20