From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f50.google.com (mail-pj1-f50.google.com [209.85.216.50]) by mx.groups.io with SMTP id smtpd.web08.18.1641592593236366433 for ; Fri, 07 Jan 2022 13:56:33 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@gmail.com header.s=20210112 header.b=qQdjkwf+; spf=pass (domain: gmail.com, ip: 209.85.216.50, mailfrom: kuqin12@gmail.com) Received: by mail-pj1-f50.google.com with SMTP id d10-20020a17090a498a00b001b33bc40d01so3169794pjh.1 for ; Fri, 07 Jan 2022 13:56:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=UXssg07ZH1sQ2ecS71FZttjpZs/cIYaN6s/z7BpVp0I=; b=qQdjkwf+KF9vc67lKr/emr/3aX4g4b4jkuQuS2rK9leUP7obe87qLZBFgPGrB+f6rh gXE2Xl9MDi2ZLcD2DM5DXrB/NdDl5FZ4wac66WNW+0Lbgy08bxv+zm0V9ZkZNGdMQHaR IKBf/QSt0OdERTkcqn+IW0OA/+BvZTTL8ebQWIO5kk80wPXM95Ssv1ChK5hppMxqyJ7l lg/dCthBSYnT2sHuraI2D7WxnhdVPa/vMFz1K9qS6iFQJ+P4jU6RJD72dXtQBS6pHlCi G2XCqmLiUY4iasdg9Ee2ANAg8sbglHgHjH4jErip0g1zRSKjvxh1+a8dk8jol/AegWxd raiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=UXssg07ZH1sQ2ecS71FZttjpZs/cIYaN6s/z7BpVp0I=; b=3BQYK8+ErWE8k+LqAQM3/LDXLvdcx5qqBgsBALL7v5VjvBEXcHKxrU51dkoGBiK6sL uP/9B89rwDRWGyd2d8Yia3XOJIJEDENb62UFKh1xJNzjfvtGKuyekLkHRkXI/iqEpJXy wJriTsNLSKFN2+NwAVTrFqU0otn55p6GBXj6Sc6GwOacc3Ju1ludMHvPRFS0gvqL8V54 9RPOu4y0zzvNP7BUCacWLENMOu3EgiTBPiy3tASetSkLpeX4mOJJvGglIAJI+wlCJ8n7 +34kg0g9gF6sEtmMdn8p3EpOra7slVTxqPiqaICYmChAjnotu3eOSFwI590GPrINbNSn /yig== X-Gm-Message-State: AOAM531ih+bEc0P/E8VZ299T3pUUuBtudmJ6+vN2mYiHkLBAMbfUE7br IWP330DzT6NFWNnD6V4KrIE= X-Google-Smtp-Source: ABdhPJxicxF734Khpmpbwz4EzxoIP18gFzB1dzYx4FdNmgzOcBWU0h9fnBKaSv2uaHpQJDHUJJsRUA== X-Received: by 2002:a17:90a:ec08:: with SMTP id l8mr4987195pjy.103.1641592592776; Fri, 07 Jan 2022 13:56:32 -0800 (PST) Return-Path: Received: from [192.168.1.18] ([50.35.74.198]) by smtp.gmail.com with ESMTPSA id e4sm4059760pjr.40.2022.01.07.13.56.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 07 Jan 2022 13:56:32 -0800 (PST) Message-ID: <0dab0f5e-632e-5cb5-828c-cf0d24a895ec@gmail.com> Date: Fri, 7 Jan 2022 13:56:32 -0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.4.1 Subject: Re: [edk2-devel] [PATCH v1 1/2] EDK2 Code First: PI Specification: New error codes of Host Software class To: "Kinney, Michael D" , "devel@edk2.groups.io" Cc: Andrew Fish , Leif Lindholm , "Gao, Liming" , "Liu, Zhiguang" References: <20220107010306.1253-1-kuqin12@gmail.com> <20220107010306.1253-2-kuqin12@gmail.com> <015bc526-1f7f-ccfc-13f9-1b3996337c62@gmail.com> From: "Kun Qin" In-Reply-To: Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi Mike, Thanks for the suggestion. I am good with the new name and will send out the updated branch shortly. Regards, Kun On 01/07/2022 12:45, Kinney, Michael D wrote: > Perhaps the term fragmented would be better than inconsistent for this condition? > > EFI_SW_EC_FRAGMENTED_MEMORY_MAP > > The term inconsistent could be used to describe other issues with the memory map. > If we think there may be other memory map conditions that we want to cover with > the same status code, then I am fine with INCONSISTENT. > > Mike > >> -----Original Message----- >> From: Kun Qin >> Sent: Friday, January 7, 2022 12:10 PM >> To: devel@edk2.groups.io; Kinney, Michael D >> Cc: Andrew Fish ; Leif Lindholm ; Gao, Liming ; Liu, Zhiguang >> >> Subject: Re: [edk2-devel] [PATCH v1 1/2] EDK2 Code First: PI Specification: New error codes of Host Software class >> >> Hi Mike, >> >> Thanks for the input. >> >> Is it better to rename "EFI_SW_EC_MEMORY_TYPE_INFORMATION_CHANGE" as >> "EFI_SW_EC_INCONSISTENT_MEM_MAP"? This name should be more generic yet >> still describing what OSes may be expecting. >> >> As per RELEASE_ASSERT, I agree that this definition is implementation >> specific and such unrecoverable errors are already covered by >> "EFI_SW_EC_ILLEGAL_SOFTWARE_STATE". So I will drop the addition of >> "RELEASE_ASSERT" in the next update. >> >> Please let me know if you have other comments or concerns, otherwise I >> will send out v2 update shortly. >> >> Thanks, >> Kun >> >> On 01/06/2022 18:09, Michael D Kinney wrote: >>> Hi Kun, >>> >>> Memory Type Information is the name of an EDK II feature. Also, not all memory >>> type information changes required a reset/reboot. That is configurable by the >>> platform. >>> >>> The system attribute that requires a reboot is if the UEFI Memory Map during a normal >>> boot is in a state that would be incompatible with a potential future ACPI S4 >>> resume boot. Some OSes require the UEFI Memory ranges for RT and ACPI memory types >>> to be in the same location in normal boot and ACPI S4 resume boot. >>> >>> I am wondering if we can choose a different name for the new PI Status code that >>> reflects this OS ACPI requirement for a consistent memory map instead of referring >>> to the EDK II Memory Type Information feature. That way, the PI Spec name would >>> allow implementations that do not necessarily required the EDK II specific >>> implementation feature. >>> >>> RELEASE_ASSERT also seems to imply an implementation specific way the reset/reboot >>> is triggered. An ASSERT() is typically triggered for a condition for which the >>> code that follow the ASSERT() can not continue without unexpected or undefined >>> behavior. So the system is in a bad state that is not recoverable. This type of >>> state could be detected with a normal if/then/else logic in C code when looking >>> at system state or encapsulated in an ASSERT() that is enabled in release builds. >>> Once again, I think we need a different name that does not require the detection >>> logic to be in an EDK II ASSERT() macro. >>> >>> Thanks, >>> >>> Mike >>> >>> >>>> -----Original Message----- >>>> From: devel@edk2.groups.io On Behalf Of Kun Qin >>>> Sent: Thursday, January 6, 2022 5:03 PM >>>> To: devel@edk2.groups.io >>>> Cc: Andrew Fish ; Leif Lindholm ; Kinney, Michael D ; Gao, >> Liming >>>> ; Liu, Zhiguang >>>> Subject: [edk2-devel] [PATCH v1 1/2] EDK2 Code First: PI Specification: New error codes of Host Software class >>>> >>>> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3794 >>>> >>>> This change includes specification update markdown file that describes >>>> the proposed PI Specification v1.7 Errata A in detail and potential >>>> impact to the existing codebase. >>>> >>>> Cc: Andrew Fish >>>> Cc: Leif Lindholm >>>> Cc: Michael D Kinney >>>> Cc: Liming Gao >>>> Cc: Zhiguang Liu >>>> >>>> Signed-off-by: Kun Qin >>>> --- >>>> CodeFirst/BZ3794-SpecChange.md | 60 ++++++++++++++++++++ >>>> 1 file changed, 60 insertions(+) >>>> >>>> diff --git a/CodeFirst/BZ3794-SpecChange.md b/CodeFirst/BZ3794-SpecChange.md >>>> new file mode 100644 >>>> index 000000000000..bbb526896795 >>>> --- /dev/null >>>> +++ b/CodeFirst/BZ3794-SpecChange.md >>>> @@ -0,0 +1,60 @@ >>>> +# Title: Introduction of `EFI_MM_COMMUNICATE_HEADER_V3` and `MM_COMMUNICATE3_*` interface >>>> + >>>> +## Status: Draft >>>> + >>>> +## Document: UEFI Platform Initialization Specification Version 1.7 Errata A >>>> + >>>> +## License >>>> + >>>> +SPDX-License-Identifier: CC-BY-4.0 >>>> + >>>> +## Submitter: [TianoCore Community](https://www.tianocore.org) >>>> + >>>> +## Summary of the change >>>> + >>>> +Introduce `EFI_SW_EC_MEMORY_TYPE_INFORMATION_CHANGE` and `EFI_SW_EC_RELEASE_ASSERT` into Status Codes definition. >>>> + >>>> +## Benefits of the change >>>> + >>>> +Current Status Codes covered various [software class error code >>>> definitions](https://github.com/tianocore/edk2/blob/master/MdePkg/Include/Pi/PiStatusCode.h). >>>> + >>>> +However, there are a few critical instances where the software could trigger system reboots while the corresponding case was >> not >>>> covered by the already defined status codes: >>>> + >>>> +1. Memory type information change triggered system reboot; >>>> +2. Assert triggered reboot on systems that did not enable system halts; >>>> + >>>> +The unexpected system reboots above could indicate decay of system health and reporting of such generic events would provide >>>> helpful information to OEMs to investigate/prevent system failures in general. >>>> + >>>> +The request of this change intends to expand definitions of `EFI_SW_EC_**` under Status Codes to cover more unexpected system >>>> reboot events, which could improve Status Code futility and readability. >>>> + >>>> +## Impact of the change >>>> + >>>> +Occupy 2 new macro definitions of Error Codes under Software class Status Codes. >>>> + >>>> +## Detailed description of the change [normative updates] >>>> + >>>> +### Specification Changes >>>> + >>>> +1. In PI Specification v1.7 Errata A: Vol. 3, Table 3-61: Error Code Operations: Host Software Class, add 2 new rows below >>>> `EFI_SW_EC_FV_CORRUPTED` definition: >>>> + >>>> + | Operation | Description | Extended Data | >>>> + | --- | --- | --- | >>>> + | EFI_SW_EC_MEMORY_TYPE_INFORMATION_CHANGE | System will reboot due to memory type information changes | None | >>>> + | EFI_SW_EC_RELEASE_ASSERT | System software asserted | None | >>>> + >>>> +1. In PI Specification v1.7 Errata A: Vol. 3, Table 3-61: Error Code Operations: Host Software Class, replace the row of >>>> `0x0014–0x00FF` to: >>>> + >>>> + | Operation | Description | Extended Data | >>>> + | --- | --- | --- | >>>> + | 0x0016–0x00FF | Reserved for future use by this specification for Host Software class error codes. | None | >>>> + >>>> +1. In PI Specification v1.7 Errata A: Vol. 3, Section 6.7.4.3 Error Code Definitions: Prototype, add 2 new definitions below >>>> `EFI_SW_EC_FV_CORRUPTED` definition: >>>> + >>>> + ```c >>>> + #define EFI_SW_EC_MEMORY_TYPE_INFORMATION_CHANGE 0x00000014 >>>> + #define EFI_SW_EC_RELEASE_ASSERT 0x00000015 >>>> + ``` >>>> + >>>> +### Code Changes >>>> + >>>> +1. Add macro definitions in `MdePkg/Include/Pi/PiStatusCode.h` to match new specification. >>>> -- >>>> 2.34.1.windows.1 >>>> >>>> >>>> >>>> >>>> >>> >>> >>> >>> >>> >>>