From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 7C90CD8026F for ; Fri, 2 Feb 2024 03:44:12 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=dJp0tt11lQh/NwWkAu2ifjeuPTCXcDdoq+VlqT7Tj9A=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:User-Agent:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type; s=20140610; t=1706845451; v=1; b=EYcGwBbxzzIVYdG3SIUHYwjbebBcec476PtfSMAN/xKjg+jiNh5KmWsEezgwTFjEE3kcbY98 4Tsn8jb4gV+Djr9StjRjq0aYAZwILjSZEAYIrAiOub7BNQfw+TNSG3tGovTpM+mFzDPWF6ypNyY oxdOcEK7uTyzakslEqciZLSE= X-Received: by 127.0.0.2 with SMTP id wr87YY7687511xSPimUUWUPN; Thu, 01 Feb 2024 19:44:11 -0800 X-Received: from mail.loongson.cn (mail.loongson.cn [114.242.206.163]) by mx.groups.io with SMTP id smtpd.web10.15539.1706845449369045089 for ; Thu, 01 Feb 2024 19:44:10 -0800 X-Received: from loongson.cn (unknown [10.40.24.149]) by gateway (Coremail) with SMTP id _____8Dx_7sFZbxlRP0JAA--.9402S3; Fri, 02 Feb 2024 11:44:06 +0800 (CST) X-Received: from [10.40.24.149] (unknown [10.40.24.149]) by localhost.localdomain (Coremail) with SMTP id AQAAf8AxRMwEZbxlX9csAA--.31882S3; Fri, 02 Feb 2024 11:44:04 +0800 (CST) Message-ID: <0db4c29b-d3d7-4979-b896-f3a335aebf54@loongson.cn> Date: Fri, 2 Feb 2024 11:44:04 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] [PATCH v8 12/37] UefiCpuPkg: Add CPU exception library for LoongArch To: devel@edk2.groups.io, ray.ni@intel.com Cc: "Dong, Eric" , "Kumar, Rahul R" , Gerd Hoffmann , Baoqi Zhang References: <20240126062715.3099433-1-lichao@loongson.cn> <20240126062907.3101558-1-lichao@loongson.cn> From: "Chao Li" In-Reply-To: X-CM-TRANSID: AQAAf8AxRMwEZbxlX9csAA--.31882S3 X-CM-SenderInfo: xolfxt3r6o00pqjv00gofq/1tbiAQAPCGW7VmEO1wABs3 X-Coremail-Antispam: 1Uk129KBj9xXoWrKFW8Gw1kKF1Uuw4UXFWUAwc_yoWDKwc_WF yxXFyxJw1qqFnIg3Z7trnxtFZY9wnrAw4aq3yvq393ArW8Zr4qyF4v93W2gr1fX347Zrn8 Cr9IkF4DJ34FqosvyTuYvTs0mTUanT9S1TB71UUUUUDqnTZGkaVYY2UrUUUUj1kv1TuYvT s0mT0YCTnIWjDUYxn0WfASr-VFAUDa7-sFnT9fnUUIcSsGvfJTRUUUbzkYFVCjjxCrM7AC 8VAFwI0_Jr0_Gr1l1xkIjI8I6I8E6xAIw20EY4v20xvaj40_Wr0E3s1l1IIY67AEw4v_Jr 0_Jr4l8cAvFVAK0II2c7xJM28CjxkF64kEwVA0rcxSw2x7M28EF7xvwVC0I7IYx2IY67AK xVW8JVW5JwA2z4x0Y4vE2Ix0cI8IcVCY1x0267AKxVW8JVWxJwA2z4x0Y4vEx4A2jsIE14 v26r4UJVWxJr1l84ACjcxK6I8E87Iv6xkF7I0E14v26r4UJVWxJr1le2I262IYc4CY6c8I j28IcVAaY2xG8wAqjxCEc2xF0cIa020Ex4CE44I27wAv7VC0I7IYx2IY67AKxVWUtVWrXw Av7VC2z280aVAFwI0_Gr0_Cr1lOx8S6xCaFVCjc4AY6r1j6r4UM4x0Y48IcVAKI48JMx8G jcxK6IxK0xIIj40E5I8CrwCF04k20xvY0x0EwIxGrwCFx2IqxVCFs4IE7xkEbVWUJVW8Jw C20s026c02F40E14v26r106r1rMI8I3I0E7480Y4vE14v26r106r1rMI8E67AF67kF1VAF wI0_JF0_Jw1lIxkGc2Ij64vIr41lIxAIcVC0I7IYx2IY67AKxVWUCVW8JwCI42IY6xIIjx v20xvEc7CjxVAFwI0_Gr0_Cr1lIxAIcVCF04k26cxKx2IYs7xG6r1j6r1xMIIF0xvEx4A2 jsIE14v26r4j6F4UMIIF0xvEx4A2jsIEc7CjxVAFwI0_Gr0_Gr1UYxBIdaVFxhVjvjDU0x ZFpf9x07UEJPiUUUUU= Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,lichao@loongson.cn List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: lZGMnEpJweco9MkTKoRCTw3Tx7686176AA= Content-Type: multipart/alternative; boundary="------------AgM0DwtpI22P9XJSxPK81poC" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=EYcGwBbx; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=none --------------AgM0DwtpI22P9XJSxPK81poC Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable Hi Ray, Thanks, Chao On 2024/2/2 11:30, Ni, Ray wrote: > 1. Most of INF changes are not necessary for x86. Can you avoid them? I just sorted them alphabetically, do you think it is unnecessary? If=20 so, I will remove the changes in other patches in next time. > >> + ## This PCD Contains the pointer to a CPU exception vector base addre= ss. >> + # @Prompt The pointer to a CPU exception vector base address. >> + >> gUefiCpuPkgTokenSpaceGuid.PcdCpuExceptionVectorBaseAddress|0x0|UINT >> 64|0x60000022 >> + > 2. I do not see any reference to the above PCD in source/INF files. > Any mistake here? This PCD is used in CpuDxe and MmuLib, among others. Do you think this=20 change should be made as a separate patch? > > > >=20 > -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#115013): https://edk2.groups.io/g/devel/message/115013 Mute This Topic: https://groups.io/mt/103971651/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- --------------AgM0DwtpI22P9XJSxPK81poC Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable

Hi Ray,


=
Thanks,
Chao
On 2024/2/2 11:30, Ni, Ray wrote:
1. Most of INF changes are not necessary for x86. Can you avoid them?
I just sorted them alphabetically, do you think it is unnecessary? If so, I will remove the changes in other patches in next time.


+  ## This PCD Contains the =
pointer to a CPU exception vector base address.
+  # @Prompt The pointer to a CPU exception vector base address.
+
gUefiCpuPkgTokenSpaceGuid.PcdCpuExceptionVectorBaseAddress|0x0|UINT
64|0x60000022
+

2. I do not see any reference to the above PCD in source/INF files.
Any mistake here?
This PCD is used in CpuDxe and MmuLib, among others. Do you think this change should be made as a separate patch?
_._,_._,_
Groups.io Links:

=20 You receive all messages sent to this group. =20 =20

View/Reply Online (#115013) | =20 | Mute= This Topic | New Topic
Your Subscriptio= n | Contact Group Owner | Unsubscribe [rebecca@openfw.io]

_._,_._,_
--------------AgM0DwtpI22P9XJSxPK81poC--