From: "Laszlo Ersek" <lersek@redhat.com>
To: devel@edk2.groups.io, vit9696@protonmail.com, "Ni,
Ray" <ray.ni@intel.com>, "Gao, Zhichao" <zhichao.gao@intel.com>
Subject: Re: [edk2-devel] [PATCH 1/1] ShellPkg: Do not connect handles without device paths
Date: Tue, 14 Jan 2020 13:53:06 +0100 [thread overview]
Message-ID: <0db58769-a955-8ee1-d19b-afaef699ce1e@redhat.com> (raw)
In-Reply-To: <A750D537-1862-438C-837D-A65573D1A517@protonmail.com>
On 01/14/20 11:34, Vitaly Cheptsov via Groups.Io wrote:
> - ConnectControllers
> ShellPkg/Library/UefiShellDriver1CommandsLib/Connect.c
>
> This one is more complex, as it supports explicitly connecting specified controllers, however, for connecting all controllers it locates handles with gEfiDevicePathProtocolGuid. I.e. exactly what we ask.
This surprised me, but I think you are right.
Interestingly, the logic goes back to historical commit 4ba49616416a
("Adding Driver1 profile commands to the UEFI Shell 2.0.", 2010-11-12).
Laszlo
prev parent reply other threads:[~2020-01-14 12:53 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-12 21:38 [PATCH 0/1] ShellPkg: Do not connect handles without device paths Vitaly Cheptsov
2020-01-12 21:38 ` [PATCH 1/1] " Vitaly Cheptsov
2020-01-13 8:11 ` [edk2-devel] " Gao, Zhichao
2020-01-13 9:19 ` Vitaly Cheptsov
2020-01-13 11:56 ` Ni, Ray
2020-01-13 17:55 ` Laszlo Ersek
2020-01-13 20:46 ` Vitaly Cheptsov
2020-01-14 2:53 ` Ni, Ray
2020-01-14 8:36 ` Vitaly Cheptsov
2020-01-14 10:34 ` Vitaly Cheptsov
2020-01-14 12:53 ` Laszlo Ersek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0db58769-a955-8ee1-d19b-afaef699ce1e@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox