From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.81]) by mx.groups.io with SMTP id smtpd.web11.11038.1579006397013523848 for ; Tue, 14 Jan 2020 04:53:17 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=DihFJumF; spf=pass (domain: redhat.com, ip: 207.211.31.81, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1579006396; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=e0Tud61w+1aeq2kOZ8pQYCcuLmrKuk+55W6N5dgr75M=; b=DihFJumF6DI3PElX3SsjnUM/2pxMt3DvpsUi65ipUgNwWS/X+lLyVjBhv5YxLZ1cFumGBe MjEg+cPAGsx8E3LMJyTse2Jp8l1p3VNDOe3gEg9Zy7Z9imVvHEthvDSv7g+fBYMsb6ak6W hldgE5iSSbx2xo8sbh4K1XHTRlWQ4VY= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-117-obJgwxJfMPSA61RIfssqXg-1; Tue, 14 Jan 2020 07:53:09 -0500 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 4A559800D41; Tue, 14 Jan 2020 12:53:08 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-116-66.ams2.redhat.com [10.36.116.66]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1C36A19756; Tue, 14 Jan 2020 12:53:06 +0000 (UTC) Subject: Re: [edk2-devel] [PATCH 1/1] ShellPkg: Do not connect handles without device paths To: devel@edk2.groups.io, vit9696@protonmail.com, "Ni, Ray" , "Gao, Zhichao" References: <20200112213845.96853-1-vit9696@protonmail.com> <20200112213845.96853-2-vit9696@protonmail.com> <483a200323c14afb95bdb94ad447868d@intel.com> <9A165163-4BB4-434A-8C65-A84CDCB3C3C2@protonmail.com> <734D49CCEBEEF84792F5B80ED585239D5C3F2C88@SHSMSX104.ccr.corp.intel.com> <0f80880e-417c-6aaf-4dfe-16158dd799c0@redhat.com> <734D49CCEBEEF84792F5B80ED585239D5C3F3905@SHSMSX104.ccr.corp.intel.com> <6D0IjdPY_gnW3iTK9Z145_tWcbCfqel3hQ0-6ENStUfchVtOe9pdu9r5ewViA8ICrkuDIQnHC8Ds1XBNfCLCP2F_hSN2-Sx9j8qqM6mPQF4=@protonmail.com> From: "Laszlo Ersek" Message-ID: <0db58769-a955-8ee1-d19b-afaef699ce1e@redhat.com> Date: Tue, 14 Jan 2020 13:53:06 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-MC-Unique: obJgwxJfMPSA61RIfssqXg-1 X-Mimecast-Spam-Score: 0 Content-Language: en-US Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit On 01/14/20 11:34, Vitaly Cheptsov via Groups.Io wrote: > - ConnectControllers > ShellPkg/Library/UefiShellDriver1CommandsLib/Connect.c > > This one is more complex, as it supports explicitly connecting specified controllers, however, for connecting all controllers it locates handles with gEfiDevicePathProtocolGuid. I.e. exactly what we ask. This surprised me, but I think you are right. Interestingly, the logic goes back to historical commit 4ba49616416a ("Adding Driver1 profile commands to the UEFI Shell 2.0.", 2010-11-12). Laszlo