From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: redhat.com, ip: 209.132.183.28, mailfrom: lersek@redhat.com) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by groups.io with SMTP; Wed, 10 Apr 2019 09:22:31 -0700 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 5D3E0307D91E; Wed, 10 Apr 2019 16:22:31 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-121-133.rdu2.redhat.com [10.10.121.133]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9B1905D961; Wed, 10 Apr 2019 16:22:29 +0000 (UTC) Subject: Re: [edk2-devel] [PATCH v2 7/8] OvmfPkg/8254TimerDxe: Update to make it build for OVMF To: devel@edk2.groups.io, hao.a.wu@intel.com Cc: Jordan Justen , Ard Biesheuvel , David Woodhouse , Ray Ni References: <20190410010628.19708-1-hao.a.wu@intel.com> <20190410010628.19708-8-hao.a.wu@intel.com> From: "Laszlo Ersek" Message-ID: <0db64707-b018-e4d3-4678-4fb5df83ad99@redhat.com> Date: Wed, 10 Apr 2019 18:22:27 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190410010628.19708-8-hao.a.wu@intel.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.48]); Wed, 10 Apr 2019 16:22:31 +0000 (UTC) Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 04/10/19 03:06, Wu, Hao A wrote: > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1496 > > This commit will remove the IntelFrameworkPkg DEC file dependency in the > driver INF file. > > A new GUID has been updated for the INF file. > > Corresponding changes have been made in OVMF DSC files as well in order to > verify the build. > > Please note that a subsequent commit (final patch of the series) will: > > A) Add OvmfPkg/8254TimerDxe driver in OVMF FDF files; > B) Remove the consumption of PcAtChipsetPkg/8254TimerDxe driver in OVMF > DSC/FDF files. > > Cc: Jordan Justen > Cc: Ard Biesheuvel > Cc: David Woodhouse > Cc: Ray Ni > Signed-off-by: Hao Wu > Reviewed-by: Laszlo Ersek > --- > OvmfPkg/OvmfPkgIa32.dsc | 1 + > OvmfPkg/OvmfPkgIa32X64.dsc | 1 + > OvmfPkg/OvmfPkgX64.dsc | 1 + > OvmfPkg/8254TimerDxe/8254Timer.inf | 6 +++--- > 4 files changed, 6 insertions(+), 3 deletions(-) > > diff --git a/OvmfPkg/OvmfPkgIa32.dsc b/OvmfPkg/OvmfPkgIa32.dsc > index feb8bc9b92..888909d809 100644 > --- a/OvmfPkg/OvmfPkgIa32.dsc > +++ b/OvmfPkg/OvmfPkgIa32.dsc > @@ -668,6 +668,7 @@ [Components] > UefiCpuPkg/CpuIo2Dxe/CpuIo2Dxe.inf > UefiCpuPkg/CpuDxe/CpuDxe.inf > PcAtChipsetPkg/8254TimerDxe/8254Timer.inf > + OvmfPkg/8254TimerDxe/8254Timer.inf > OvmfPkg/IncompatiblePciDeviceSupportDxe/IncompatiblePciDeviceSupport.inf > OvmfPkg/PciHotPlugInitDxe/PciHotPlugInit.inf > MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridgeDxe.inf { > diff --git a/OvmfPkg/OvmfPkgIa32X64.dsc b/OvmfPkg/OvmfPkgIa32X64.dsc > index 993da3197c..1771c457f4 100644 > --- a/OvmfPkg/OvmfPkgIa32X64.dsc > +++ b/OvmfPkg/OvmfPkgIa32X64.dsc > @@ -677,6 +677,7 @@ [Components.X64] > UefiCpuPkg/CpuIo2Dxe/CpuIo2Dxe.inf > UefiCpuPkg/CpuDxe/CpuDxe.inf > PcAtChipsetPkg/8254TimerDxe/8254Timer.inf > + OvmfPkg/8254TimerDxe/8254Timer.inf > OvmfPkg/IncompatiblePciDeviceSupportDxe/IncompatiblePciDeviceSupport.inf > OvmfPkg/PciHotPlugInitDxe/PciHotPlugInit.inf > MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridgeDxe.inf { > diff --git a/OvmfPkg/OvmfPkgX64.dsc b/OvmfPkg/OvmfPkgX64.dsc > index 65aab4f711..dfe5781658 100644 > --- a/OvmfPkg/OvmfPkgX64.dsc > +++ b/OvmfPkg/OvmfPkgX64.dsc > @@ -675,6 +675,7 @@ [Components] > UefiCpuPkg/CpuIo2Dxe/CpuIo2Dxe.inf > UefiCpuPkg/CpuDxe/CpuDxe.inf > PcAtChipsetPkg/8254TimerDxe/8254Timer.inf > + OvmfPkg/8254TimerDxe/8254Timer.inf > OvmfPkg/IncompatiblePciDeviceSupportDxe/IncompatiblePciDeviceSupport.inf > OvmfPkg/PciHotPlugInitDxe/PciHotPlugInit.inf > MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridgeDxe.inf { > diff --git a/OvmfPkg/8254TimerDxe/8254Timer.inf b/OvmfPkg/8254TimerDxe/8254Timer.inf > index 751ed1c02c..8a07c8247e 100644 > --- a/OvmfPkg/8254TimerDxe/8254Timer.inf > +++ b/OvmfPkg/8254TimerDxe/8254Timer.inf > @@ -1,7 +1,7 @@ > ## @file > # 8254 timer driver that provides Timer Arch protocol. > # > -# Copyright (c) 2005 - 2018, Intel Corporation. All rights reserved.
> +# Copyright (c) 2005 - 2019, Intel Corporation. All rights reserved.
> # SPDX-License-Identifier: BSD-2-Clause-Patent > # > ## > @@ -10,7 +10,7 @@ [Defines] > INF_VERSION = 0x00010005 > BASE_NAME = Timer > MODULE_UNI_FILE = Timer.uni > - FILE_GUID = f2765dec-6b41-11d5-8e71-00902707b35e > + FILE_GUID = C190FE35-44AA-41A1-8AEA-4947BC60E09D > MODULE_TYPE = DXE_DRIVER > VERSION_STRING = 1.0 > > @@ -18,7 +18,7 @@ [Defines] > > [Packages] > MdePkg/MdePkg.dec > - IntelFrameworkPkg/IntelFrameworkPkg.dec > + OvmfPkg/OvmfPkg.dec > > [LibraryClasses] > UefiBootServicesTableLib > Thanks for the commit msg update Laszlo