From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mx.groups.io with SMTP id smtpd.web12.1893.1608233002556135244 for ; Thu, 17 Dec 2020 11:23:22 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=gCfYNuvz; spf=pass (domain: redhat.com, ip: 63.128.21.124, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1608233001; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=A/2o6I4zulYRbWEdcFhqwEItMdFRxhKntL/jvZ/a6UY=; b=gCfYNuvzxK/hZTMRusxdy3ANSrA0WSxuPnxLeuxWA9eWsW2t6AxmU2agkX/ydD4od3MRct Vx13fvPOg83/N5KiXISTkO6wyuyFr2AuerYV7dTb7Ejpuz+sYagiQbkIIKGIVwKQPhEX31 kDP73VJAGNpupg/xS/Lovco+W6MiNPM= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-34-JeOPnO_PMeW1vOhkrMdFmw-1; Thu, 17 Dec 2020 14:23:16 -0500 X-MC-Unique: JeOPnO_PMeW1vOhkrMdFmw-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id EE7131005513; Thu, 17 Dec 2020 19:23:13 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-112-17.ams2.redhat.com [10.36.112.17]) by smtp.corp.redhat.com (Postfix) with ESMTP id 721295D9CD; Thu, 17 Dec 2020 19:23:10 +0000 (UTC) Subject: Re: [edk2-devel] [PATCH 0/2] Update SevSecret API to work for TDX From: "Laszlo Ersek" To: devel@edk2.groups.io, jejb@linux.ibm.com Cc: dovmurik@linux.vnet.ibm.com, Dov.Murik1@il.ibm.com, ashish.kalra@amd.com, brijesh.singh@amd.com, tobin@ibm.com, david.kaplan@amd.com, jon.grimm@amd.com, thomas.lendacky@amd.com, frankeh@us.ibm.com, "Dr . David Alan Gilbert" , Jordan Justen , Ard Biesheuvel , "Yao, Jiewen" , Michael Kinney , Sean Brogan References: <20201216014146.2229-1-jejb@linux.ibm.com> <9f490145-b7a2-f568-f8e8-7f2b115708ea@redhat.com> Message-ID: <0de76b37-1914-cb97-ed5f-70141de3bc8a@redhat.com> Date: Thu, 17 Dec 2020 20:23:09 +0100 MIME-Version: 1.0 In-Reply-To: <9f490145-b7a2-f568-f8e8-7f2b115708ea@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lersek@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 12/17/20 19:43, Laszlo Ersek wrote: > I tried merging this: > > https://github.com/tianocore/edk2/pull/1235 > > but the Ubuntu builds all failed. I've checked two logs: > > https://dev.azure.com/tianocore/edk2-ci/_build/results?buildId=16967&view=logs&j=cf2d8b26-a21c-5c68-abf4-b944c123e462&t=5ffbbe5c-1d3a-55f5-5ef3-8a0ef80d76a1&l=184 > https://dev.azure.com/tianocore/edk2-ci/_build/results?buildId=16968&view=logs&j=47cf355a-6eb4-51a8-46a8-ff4028bfcac0&t=beedef5d-00d0-5a8c-fa35-57d7319988c2&l=182 > > They say, > > INFO - /bin/sh: 1: qemu-system-aarch64: not found > INFO - /bin/sh: 1: qemu-system-x86_64: not found The "Install qemu" tasks earlier seem to complete: https://dev.azure.com/tianocore/edk2-ci/_build/results?buildId=16967&view=logs&j=cf2d8b26-a21c-5c68-abf4-b944c123e462&t=a5c654c1-e049-5a30-61a9-da81b8ec031f https://dev.azure.com/tianocore/edk2-ci/_build/results?buildId=16968&view=logs&j=47cf355a-6eb4-51a8-46a8-ff4028bfcac0&t=9a629c6e-a36d-5733-3aff-19ed2a42cf75 However, the qemu "4.2-3ubuntu6.10" package is a dummy package: https://packages.ubuntu.com/focal/qemu and as shown under the link, it has no dependency on the packages with the actual qemu executables. So the latter do not get pulled in. (Even the logs make that clear: "Need to get 14.3 kB of archives" -- obviously, a real QEMU won't fit in that, and no other packages get pulled in). The meta-package that pulls in all system emulators is called "qemu-system": https://packages.ubuntu.com/focal/qemu-system What I don't understand at this point is how the CI scripts could work previously. ... Aha! I do understand it now. Look at one of the last successful PRs: https://github.com/tianocore/edk2/pull/1232 The CI logs contain this message: "##[warning]Ubuntu-latest pipelines will use Ubuntu-20.04 soon. For more details, see https://github.com/actions/virtual-environments/issues/1816" So let's check out: https://github.com/actions/virtual-environments/issues/1816 Okay... so it looks like I'm the victim of "Ubuntu-latest" switching to 20.04 ("focal") from 18.04 ("bionic"). Compare the "qemu" package in both: https://packages.ubuntu.com/bionic/qemu https://packages.ubuntu.com/focal/qemu In the former, qemu depends on qemu-system (which depends further on the actual emulator subpackages), in the latter, qemu doesn't depend on anything. According to , we could change: .azurepipelines/Ubuntu-GCC5.yml: vm_image: 'ubuntu-latest' .azurepipelines/Ubuntu-PatchCheck.yml: vmImage: 'ubuntu-latest' ArmVirtPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml: vm_image: 'ubuntu-latest' EmulatorPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml: vm_image: 'ubuntu-latest' OvmfPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml: vm_image: 'ubuntu-latest' to "ubuntu-18.04". But perhaps we should change: ArmVirtPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml: - bash: sudo apt-get install qemu OvmfPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml: - bash: sudo apt-get install qemu to "qemu-system", instead. Laszlo