Re: [edk2-devel] [PATCH v4 4/7] OvmfPkg: Generate CloudHv as a PVH ELF binary

["Boeuf, Sebastien" <sebastien.boeuf@intel.com>]

On Tue, 2022-03-01 at 08:16 +0100, Gerd Hoffmann wrote:
> On Mon, Feb 28, 2022 at 03:12:53PM +0000, Boeuf, Sebastien wrote:
> > So what do you think I should do with this patch?
> 
> I think you can:
> 
>   (1) drop FD.CLOUDHV_VARS
Ok
>   (2) drop FD.CLOUDHV_CODE
Ok
>   (3) make VARS_SIZE smaller (just enough for the pvh header),

Ok. Do you want me to keep the factorization in VarStore.fdf.inc?

>   (4) make FVMAIN_SIZE larger (so the total size remains the same).
Ok
>   (5) possibly rename VARS_SIZE.  It's not about VARS any more.  Not
>       sure this is worth the churn and how many places you need to
> touch
>       for this, maybe a big'n'fat comment instead will do.

Ok I'll check how feasible this is.
> 
> HTH,
>   Gerd
> 
> 
> 
> 
> 
> 

---------------------------------------------------------------------
Intel Corporation SAS (French simplified joint stock company)
Registered headquarters: "Les Montalets"- 2, rue de Paris, 
92196 Meudon Cedex, France
Registration Number:  302 456 199 R.C.S. NANTERRE
Capital: 4,572,000 Euros

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.