From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 5035BAC08F8 for ; Tue, 16 Jan 2024 05:07:51 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=XanvJWfuqSeJMDrhsJh7WhoaeAGytVxu3G6slKQEaO4=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:Message-ID:Date:User-Agent:Subject:To:CC:References:From:In-Reply-To:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1705381670; v=1; b=hFJVNTQsiYZWsY7FMtSVabku564n/4lgUq4HcOyqeJ53weoLHGwh+5DTbQcOHbZ/LgSx5qQT YeBz1XtrvHAQAYgq14Q7AKEMlc6MiqOIqLaQacB8wr4kFNYOv/E30OPBXcR+nvDeabRowTdUve8 cNV803HSCznBJ3p0g63IUQe0= X-Received: by 127.0.0.2 with SMTP id kb6HYY7687511x8oiqi4IXM2; Mon, 15 Jan 2024 21:07:50 -0800 X-Received: from NAM12-MW2-obe.outbound.protection.outlook.com (NAM12-MW2-obe.outbound.protection.outlook.com [40.107.244.91]) by mx.groups.io with SMTP id smtpd.web10.79323.1705324069394307537 for ; Mon, 15 Jan 2024 05:07:49 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EaO8gB8x7fMK2rhxHZfLtQ5nb1RwxlKF7YFOdR/qUWGnzvFQnmJBHFrM0foDmTlRjUAilTIf47YIbm01AbGxKu75QYuFg5pDgvjwq2nm1T4NOVYuSgi5ylfifrbZShX8rNYMIv9+fkIxiByLPZfEG8GSNAvZIzNqG7gEOhiynjA0BIe8vUx2VBolo3xlPV6Kii2E+TVwVweVOIWHU/8/R4qMq4cIqfZ7VEfMVWbD6M+NgSVJZytDGDYvhlBwu1+Dv6ZZWmPeeAQNGmTQ2/ZRctnMGYfTr4KWKYYCv/Ek9qnyh+0fwXBSnya4kgXlmynW8xrLkm2dRXCc+nd1nww2Fw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=sBl2CwaVDLOhvcPYnliOinYXuRb1+CYr/AUmx5zvupU=; b=Nak/lcaRpY5MuYe9ZVPuVk/9zNo8H5lt1zHKcQwVrtntXI9xXDfkdWiCYVavkFMWJ8U6JFvzuqwY8zUcwLRD8XjrPYE7XtK5t8orNtujsXlL9Ypcax4uozsqXNduvrzMPs10+EnFuXrhUgZD/TxnjCO2FWq70JTDz8KINQhK/IIRomkQ3jdznxBepXu/RHPCyANQwInysRVOFM5qXvLoAD9qKF6F4djLuP8kg3Pvz/cXZzQMBCZ+yyPdEAm+Vyzt6bt066vysoTYr4kJpiyGlswo8LQwxO4+lp9PnOLZCRxMg/1LYsG3uNo5ab6yuqIiIghT5pq19xwV+HUanYNioA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=os.amperecomputing.com; dmarc=pass action=none header.from=os.amperecomputing.com; dkim=pass header.d=os.amperecomputing.com; arc=none X-Received: from PH0PR01MB7287.prod.exchangelabs.com (2603:10b6:510:10a::21) by PH0PR01MB6247.prod.exchangelabs.com (2603:10b6:510:18::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7181.26; Mon, 15 Jan 2024 13:07:43 +0000 X-Received: from PH0PR01MB7287.prod.exchangelabs.com ([fe80::516a:4d2f:440f:148]) by PH0PR01MB7287.prod.exchangelabs.com ([fe80::516a:4d2f:440f:148%7]) with mapi id 15.20.7181.026; Mon, 15 Jan 2024 13:07:42 +0000 Message-ID: <0e0b2e56-30dd-4f5f-9708-98690246efda@os.amperecomputing.com> Date: Mon, 15 Jan 2024 20:07:34 +0700 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] Memory Attribute for depex section To: Laszlo Ersek , "Andrew (EFI) Fish" , edk2-devel-groups-io CC: "ardb+tianocore@kernel.org" References: <44ca139f-4d78-4322-b5b6-8e9788bb7486@os.amperecomputing.com> <2ad16043-754e-3bb9-3a4a-702d9a50bf63@redhat.com> <45b95719-f1fc-dbc6-a4cc-a022d691844c@redhat.com> <8d745268-263c-c99a-67c6-fe0fb6cd4b8e@redhat.com> From: "Nhi Pham via groups.io" In-Reply-To: <8d745268-263c-c99a-67c6-fe0fb6cd4b8e@redhat.com> X-ClientProxiedBy: SG2P153CA0049.APCP153.PROD.OUTLOOK.COM (2603:1096:4:c6::18) To PH0PR01MB7287.prod.exchangelabs.com (2603:10b6:510:10a::21) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR01MB7287:EE_|PH0PR01MB6247:EE_ X-MS-Office365-Filtering-Correlation-Id: 90c276bc-b9f2-4b38-513d-08dc15caf519 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Message-Info: F6UulGKekZKeOM1S4hOY6K7RdphRGIZHSUVXMDHyivRgLzjcJ6JvVvYHHtzhTSomToMpduegm5gyv1aiE8OIo0R2nrspta2sIX0VZaxja9imTY35eJu3BHwMOI2IVWBSaz3eFJDRqzmrM/ENyjme+EmkmQTDXfNhNoM1mGwX/Zmuyvh22zeJsycsk99lLdPBfq//9cGB6pL0wn1Y3nX5kWHoniKNH5tf8vuMVJu0eeqYoJc45+ZqLu/iR50+Gi7GsEP9abduvq+wMJMwBrQRuocY+z1CaCjzdJOlirk18xw1WKuwMLRxaEDaFJQTortxRAiJ4cDwv9WpaCVKHFmgbT10p4M1spL4Rsn525VpeEsrdOL9SrKMJTT2NK/J7Snkl6QOn2s85if2s8CeHtK7FijAQIKUTP3tMJaIuhb1qdjzrMv/IkmcxpbauPQ99pG82COAXDNH0jJcrmhp6+iIQwpRoNXVHmS1HQIFcaUa60xMwVU/OPtXFLWsXnxCwlG7vkmzL71HK8nzR4s33G4BH2/lSmB9/uG13RwpvPoFJYm15xJdBolOsEpaUQFDZyWCuw0z6+DE9dCim+H/i3o++9AFruHVv8uLQZMDOYCESNsFDxprGIzLxWmDDyxzzzZc X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?8JjK683NQfoLR2vzuaf30GeBr7Z83Gcr1wAt79NV5G0aDyuGqlElnZarRLSo?= =?us-ascii?Q?er56wwvNNLjJ4oUYkacuD1LdYzKqTRrZeIeEnwkYX6eYUp8rvDFCGeblIu+j?= =?us-ascii?Q?14nh4zqyJrkGPAKrdOkKwno6MXCaoR/Iw2fK16iybq7ivi0gWSAIJ532F9t9?= =?us-ascii?Q?3SDAFDB2tb7N/DKlnYkxVBp2EHj0/Xx0Isk4BJpGeYLjvjgk26BwUj69b/z0?= =?us-ascii?Q?WMfw/3aUjpypo6Q77JgZhdcRymVaGx5dVpU3TG2VanT8Dto8vuB9akttkwt+?= =?us-ascii?Q?pXTKryunfwHR+gw1bHtkYpeNT8ipVtb+G0ZcjTfp0iApgH0hQdqNeUlW4Lb7?= =?us-ascii?Q?O5nOJwOc9LwOJ9zLTJQ6Z/hDp+AQ7brE9mdindwet3OOOQnwN+tFXnd0lAvb?= =?us-ascii?Q?0aZuANqCqeEaV7pVvwsPoB6fzez64BhySqMOK1BoQGrrc03N+cRDtq5GJdB/?= =?us-ascii?Q?ndyaCZznYgBcPgKcKZYt4doKGTxA9bzDhGG4/1sfS3AtkBU+IxGARNvmO/md?= =?us-ascii?Q?7HRIBs+LamAs4Ufc5svNZehWIuhJWIHDrEhL2Uu5nB5bjEEuAB1+pWVQ5XUo?= =?us-ascii?Q?kBGc3FmZiDFy4/wmJOKQRRbJdxRL+AW7i5mlbbpudNuxjG1DzvCMJhe7hy4P?= =?us-ascii?Q?hC4SmimxjflxONKQgkLAQ34qTR1LyRfosfZPLU1wt8tefdpJgNjMZBQJBIrv?= =?us-ascii?Q?qp5Iy/P2TCFWxbkl50G9WtBZRnmv+C3PFph4StMVVxsD3kmXNX3BjE5TvJtc?= =?us-ascii?Q?7pB+nPPHSw7u1Nf/+vVVS76LLnFgsXG75Mw3JDSy6VTwOoy1YgK+70ARFQAK?= =?us-ascii?Q?71U5pDJRHTOLV5pND5WilhoO65XhPSDNDyJ75emUNe6EXlDdBjIrw45AqSeq?= =?us-ascii?Q?p//pubcVlv42a9oR+wwqvDSk23FM4D+6XAYuVDanrjXrsmVf5ZbJZ3uhsykl?= =?us-ascii?Q?YpwhfKHAwnCqNF9dgrD4nfLiQJT8zRDfUuRpOgtTy8qjZ+xK0Wt98Tob1Jmc?= =?us-ascii?Q?1h45j6yhT1V1wmMfmFukBqGVCGllSx/vw4d76fNaQvoGigtgIEuRacmLPSMP?= =?us-ascii?Q?IOlf8/XChf5w9XqBIeMcoOwvsCTbk/nD43rt7/6U1NWijomHp/dXxodfD0KN?= =?us-ascii?Q?E14RSrTh9Y0Fb3pSGSnjRHBsMXxtco+Gg0qOci4jDpXaEbMn58B/cznhxJv6?= =?us-ascii?Q?2W5GD/MfQffXIBsXFx2Z8k956APLgCYziQSkfNJ4AeU17ixhNGv+k5uzZbsI?= =?us-ascii?Q?hoNMwo9/NvLL59myyACYqgOEKOQq5Bvr6y2tA4iqth6KGlYZESylx55Q+zKw?= =?us-ascii?Q?/yVEistbKJeN9gQE2BbxLFTAoN8RwBJrtcBvgwv1XUNChYKEpb5DB3OymUtX?= =?us-ascii?Q?X5s0iA4DMupvJc50EkugX1dLZb6ixtAz6kYkFYn8RCruC2z2pb074uqaS05G?= =?us-ascii?Q?oDn8lseEa+K04wTV2tln98EogpLcwRZgyLdvnxY7iI/QaDQkuoRYHcUm9Eq2?= =?us-ascii?Q?kewVHdAYRHhhYO00BMqBfzy5bwb+i1PDfYtsh65V5m/sFwpJHwBL2Is+T+CO?= =?us-ascii?Q?93ZuFL0GOS0xYdvdbKJ9sd/y9DzkFs1f8bO1mxElg5kJc4WXu7VWOm0B9NLu?= =?us-ascii?Q?ex7nz3ecbLjxD5v0on7b+ko=3D?= X-OriginatorOrg: os.amperecomputing.com X-MS-Exchange-CrossTenant-Network-Message-Id: 90c276bc-b9f2-4b38-513d-08dc15caf519 X-MS-Exchange-CrossTenant-AuthSource: PH0PR01MB7287.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Jan 2024 13:07:42.2421 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: nzgYmjnk78SZHm64Df2PNB7ltqz2MT0HP9Jh3e1cFJUahqHfYyvy/VpI11JwXcy1+OHCBON0+6BE8A49+MfmF9qG/EwsAJ5eMouSu0rDb04= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR01MB6247 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,nhi@os.amperecomputing.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: uOSWEiMINOOZrX0uaTe3Hd7Mx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=hFJVNTQs; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On 1/12/2024 4:45 PM, Laszlo Ersek wrote: > (Independently: I think that's a valid thing to do for *SMM* drivers, > because the entry point functions of those drivers are permitted to use > both SMM and DXE/UEFI protocols. But whether the same is valid for the > *standalone* MM drivers -- that looks questionable. Standalone MM > drivers should not depend on UEFI/DXE protocols ever, IIUC.) >=20 >> 3) The issue is patching the grammar in place, why can=E2=80=99t we just= make a >> copy for the dispatcher grammer, and operate on the copy. Maybe via a >> copy on 1st update strategy?=C2=A0 >=20 > Yes, copying the depex to the heap, and patching it there, was Nhi's #1 > fix proposal. I think that could be made work. But I'm not sure if the > perf savings are worth the additional complexity. The heap allocation > (where the writeable depex would exist) would have to be permanently > associated with the loaded PE image -- because the dispatcher might need > to reevaluate the depex across multiple rounds of dispatching. So that's > a new field in some image-related structure, it also needs to be freed > upon unload (?), what if the memory allocation fails during depex eval > (just consider the depex to eval to FALSE?), etc. Doable, but hairy; not > sure if the perf is worth that effort. >=20 Thanks so much, Laszlo for your valuable insights. The approach #1 works for me. I will do further check for your concerns above. I'm trying your suggested patch and investigating the performance being discussed here. Regards, Nhi -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#113821): https://edk2.groups.io/g/devel/message/113821 Mute This Topic: https://groups.io/mt/103594587/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-