From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 96B8B7803DA for ; Tue, 7 Nov 2023 13:13:14 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=rT/1z9+J0geRsfV1PlrU488c5PtdEjnahT9ka/E86Co=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:User-Agent:Subject:To:CC:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1699362793; v=1; b=JXIQ0L9ZfDCHxv1MJfdZRl992G7YGTsm5R/axPryXw/dKq+abzgL6RdMaqev7GuQX3FZ7bag JeRaDJnCVHB8j/ou3/tQkPcd9RtbiBnrRlFAjuS18ZLR8tmu7hiMqJ5Q/5kTBkf27dHNDGi5ABG 6YJnShtG2XV6vuIlL11xncE4= X-Received: by 127.0.0.2 with SMTP id GA4SYY7687511xbPO8tzUlE9; Tue, 07 Nov 2023 05:13:13 -0800 X-Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by mx.groups.io with SMTP id smtpd.web10.10219.1699362792465412098 for ; Tue, 07 Nov 2023 05:13:12 -0800 X-Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 3A793U9s030361; Tue, 7 Nov 2023 13:13:01 GMT X-Received: from nasanppmta03.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3u72c02n0e-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 07 Nov 2023 13:13:01 +0000 X-Received: from nasanex01c.na.qualcomm.com (nasanex01c.na.qualcomm.com [10.45.79.139]) by NASANPPMTA03.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 3A7DD00o016151 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 7 Nov 2023 13:13:00 GMT X-Received: from [10.251.40.107] (10.80.80.8) by nasanex01c.na.qualcomm.com (10.45.79.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.39; Tue, 7 Nov 2023 05:12:57 -0800 Message-ID: <0e0d7f3f-6e56-41fd-8eb4-b4fec469f629@quicinc.com> Date: Tue, 7 Nov 2023 13:12:54 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] [PATCH 1/1] BaseTools/tools_def: drop -mgeneral-regs-only for AArch64 CLANGDWARF To: "Yeping Song (QUIC)" , "devel@edk2.groups.io" , Liming Gao CC: Rebecca Cran , Bob Feng , "Yuwei Chen" , Ard Biesheuvel , "Sami Mujawar" , "Kinney, Michael D" References: <17942B788A4667A6.3650@groups.io> From: "Leif Lindholm" In-Reply-To: X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nasanex01c.na.qualcomm.com (10.45.79.139) X-QCInternal: smtphost X-Proofpoint-ORIG-GUID: im-wHl_dkwoHuqyXypZ8dzWZyL8SvFzD X-Proofpoint-GUID: im-wHl_dkwoHuqyXypZ8dzWZyL8SvFzD Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,quic_llindhol@quicinc.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: AxIN1kJKzeTHOk2s3711tpeEx7686176AA= Content-Language: en-GB Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=JXIQ0L9Z; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=quicinc.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Liming, You reviewed this patch before the stable tag. Am I OK to stage a github=20 PR for this change? Reviewed-by: Leif Lindholm Regards, Leif On 2023-11-07 13:11, Yeping Song (QUIC) wrote: > Hi all, > I would like for this to be include in stable tag. Please help to review = and merge this patch into stable release. > Thanks > Yepings >=20 >=20 > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Yeping Son= g > Sent: Saturday, November 4, 2023 12:38 AM > To: devel@edk2.groups.io > Cc: Yeping Song (QUIC) ; Rebecca Cran ; Liming Gao ; Bob Feng ; Yuwei Chen ; Ard Biesheuvel ; Leif Lindholm (QUIC) ; Sami Mujawar= > Subject: [edk2-devel] [PATCH 1/1] BaseTools/tools_def: drop -mgeneral-reg= s-only for AArch64 CLANGDWARF >=20 > WARNING: This email originated from outside of Qualcomm. Please be wary o= f any links or attachments, and do not enable macros. >=20 > Commit 0df6c8c157af9 ("BaseTools/tools_def AARCH64: > avoid SIMD registers in XIP code") > adds -mgeneral-regs-only to GCC_AARCH64_CC_XIPFLAGS, in order to avoid a = bug present in certain versions of GCC. > This was never a problem for clang. > That's given the history of what the problem is. > Then we can describe how we fix it: > Change *_CLANGDWARF_AARCH64_CC_XIPFLAGS to set the required -mstrict-alig= n option instead of importing the whole GCC variable. >=20 > Signed-off-by: Yeping Song > Cc: Rebecca Cran > Cc: Liming Gao > Cc: Bob Feng > Cc: Yuwei Chen > Cc: Ard Biesheuvel > Cc: Leif Lindholm > Cc: Sami Mujawar > --- > BaseTools/Conf/tools_def.template | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/BaseTools/Conf/tools_def.template b/BaseTools/Conf/tools_def= .template > index 5bd5283655ea..c34ecfd557c5 100755 > --- a/BaseTools/Conf/tools_def.template > +++ b/BaseTools/Conf/tools_def.template > @@ -2015,7 +2015,7 @@ DEFINE CLANGDWARF_AARCH64_DLINK_FLAGS =3D DEF(CLAN= GDWARF_AARCH64_TARGET) DEF(GCC_ > *_CLANGDWARF_AARCH64_RC_FLAGS =3D DEF(GCC_AARCH64_RC_FLAGS) DEF(G= CC_AARCH64_RC_BTI_FLAGS) > *_CLANGDWARF_AARCH64_VFRPP_FLAGS =3D DEF(GCC_VFRPP_FLAGS) DEF(CLANGD= WARF_AARCH64_TARGET) $(PLATFORM_FLAGS) > *_CLANGDWARF_AARCH64_ASLPP_FLAGS =3D DEF(GCC_ASLPP_FLAGS) DEF(CLANGD= WARF_AARCH64_TARGET) > -*_CLANGDWARF_AARCH64_CC_XIPFLAGS =3D DEF(GCC_AARCH64_CC_XIPFLAGS) > +*_CLANGDWARF_AARCH64_CC_XIPFLAGS =3D -mstrict-align >=20 > DEBUG_CLANGDWARF_AARCH64_CC_FLAGS =3D DEF(CLANGDWARF_AARCH64_CC_FL= AGS) $(PLATFORM_FLAGS) -flto -O1 > DEBUG_CLANGDWARF_AARCH64_DLINK_FLAGS =3D DEF(CLANGDWARF_AARCH64_DLINK= _FLAGS) -flto -Wl,-O1 -fuse-ld=3Dlld -L$(WORKSPACE)/ArmPkg/Library/GccLto -= llto-aarch64 -Wl,-plugin-opt=3D-pass-through=3D-llto-aarch64 -Wl,--no-pie,-= -no-relax > -- > 2.25.1 >=20 >=20 >=20 >=20 >=20 >=20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#110852): https://edk2.groups.io/g/devel/message/110852 Mute This Topic: https://groups.io/mt/102368361/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/19134562= 12/xyzzy [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-