From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 0D6667803CE for ; Wed, 8 Nov 2023 22:24:46 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=BnmpwMepBQTkeEBgPMkQwyg4NR1gbrNkOya979i5ipo=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1699482285; v=1; b=usQn/mB30m3Z6ESx4QFrujUfQ+LmerhOLV3dunHJrCGnzoIQ+JlOacnVdZFFYykw4X564elE iRtpmY+MKk/P54zRxsnzlpcOKqtEYD+x7tIRJyJxmRkYwYFhk9R2CSsVx/kVI6JReE99HL3fQIj 4i+3EC5xmZIE4g9WMJJoUylA= X-Received: by 127.0.0.2 with SMTP id PgRTYY7687511xNlAR1ocjAa; Wed, 08 Nov 2023 14:24:45 -0800 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web11.106177.1699482285080029658 for ; Wed, 08 Nov 2023 14:24:45 -0800 X-Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-588-aiSKNNs8PtyhfOuznmoceA-1; Wed, 08 Nov 2023 17:24:41 -0500 X-MC-Unique: aiSKNNs8PtyhfOuznmoceA-1 X-Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 8A620282476A; Wed, 8 Nov 2023 22:24:40 +0000 (UTC) X-Received: from [10.39.192.41] (unknown [10.39.192.41]) by smtp.corp.redhat.com (Postfix) with ESMTPS id AB77C25C1; Wed, 8 Nov 2023 22:24:38 +0000 (UTC) Message-ID: <0e2c2f4d-c559-f9f9-881a-143eec02de4d@redhat.com> Date: Wed, 8 Nov 2023 23:24:36 +0100 MIME-Version: 1.0 Subject: Re: [edk2-devel] [PATCH v2 24/30] OvmfPkg/LoongArchVirt: Add platform boot manager library To: devel@edk2.groups.io, lichao@loongson.cn Cc: Ard Biesheuvel , Jiewen Yao , Jordan Justen , Gerd Hoffmann , Xianglai Li , Bibo Mao References: <20231106032521.2251143-1-lichao@loongson.cn> <20231106033021.2294243-1-lichao@loongson.cn> From: "Laszlo Ersek" In-Reply-To: <20231106033021.2294243-1-lichao@loongson.cn> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,lersek@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: XLPh3M6z8sHeHF7NHmiZU6Qex7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b="usQn/mB3"; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On 11/6/23 04:30, Chao Li wrote: > This library is provides boot mananger interfaces, and it is referenced > from ArmVirtPkg. >=20 > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4584 >=20 > Cc: Ard Biesheuvel > Cc: Jiewen Yao > Cc: Jordan Justen > Cc: Gerd Hoffmann > Signed-off-by: Chao Li > Co-authored-by: Xianglai Li > Co-authored-by: Bibo Mao > --- > .../PlatformBootManagerLib/PlatformBm.c | 829 ++++++++++++++++++ > .../PlatformBootManagerLib/PlatformBm.h | 112 +++ > .../PlatformBootManagerLib.inf | 73 ++ > .../PlatformBootManagerLib/QemuKernel.c | 81 ++ > 4 files changed, 1095 insertions(+) > create mode 100644 OvmfPkg/LoongArchVirt/Library/PlatformBootManagerLib/= PlatformBm.c > create mode 100644 OvmfPkg/LoongArchVirt/Library/PlatformBootManagerLib/= PlatformBm.h > create mode 100644 OvmfPkg/LoongArchVirt/Library/PlatformBootManagerLib/= PlatformBootManagerLib.inf > create mode 100644 OvmfPkg/LoongArchVirt/Library/PlatformBootManagerLib/= QemuKernel.c I wish it were "referenced"; it's not referenced but *copied*. Why is the library in ArmVirtPkg not good enough? What are the differences? Etc. I'm not even asking about the specifics here, but trying to show you how you should please *present* this platform enablement for review. Laszlo -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#110933): https://edk2.groups.io/g/devel/message/110933 Mute This Topic: https://groups.io/mt/102413902/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/19134562= 12/xyzzy [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-