From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web10.138535.1673783416206477217 for ; Sun, 15 Jan 2023 03:50:16 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Q7Zq0u1g; spf=pass (domain: redhat.com, ip: 170.10.133.124, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1673783414; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FHDcCyRCDAxceBd6P3rA46nFdsyVA17ePaiGA5AwE6M=; b=Q7Zq0u1gUwiEAv7GxAPHl5w8YtiipVgEgStggdddk7sYnDSa9KgqphLl70xw3kiFFXdeMq +YMCPE4kVPr7gfkQtgojmv955c7bPRD2WXKYovkDjOajE1E9UD9toDw74SddKwc76pAGZe HR7Eruxrm3jzVzPtJNCErPl7To5GHDE= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-368-TcsapZ8ROLGr_HVhNiOm7g-1; Sun, 15 Jan 2023 06:50:11 -0500 X-MC-Unique: TcsapZ8ROLGr_HVhNiOm7g-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id BFA60811E9C; Sun, 15 Jan 2023 11:50:10 +0000 (UTC) Received: from [10.39.192.109] (unknown [10.39.192.109]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 49C041121314; Sun, 15 Jan 2023 11:50:09 +0000 (UTC) Message-ID: <0e494671-570c-e8d3-8b24-ebece1a8cc09@redhat.com> Date: Sun, 15 Jan 2023 12:50:07 +0100 MIME-Version: 1.0 Subject: Re: [edk2-devel] [PATCH V3 0/6] Refactor installation of gQemuAcpiTableNotifyProtocol To: devel@edk2.groups.io, min.m.xu@intel.com Cc: Erdem Aktas , James Bottomley , Jiewen Yao , Gerd Hoffmann , Tom Lendacky , Sebastien Boeuf References: <20230111012235.189-1-min.m.xu@intel.com> From: "Laszlo Ersek" In-Reply-To: <20230111012235.189-1-min.m.xu@intel.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 1/11/23 02:22, Min Xu wrote: > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4237 > > Commit 9fdc70af6ba8 breaks log analysis and code cohesion in > AcpiPlatformDxe. See the detailed information in BZ#4237. > > This patch-set contains below patches to fix above issues. > #1: Remove QEMU_ACPI_TABLE_NOTIFY_PROTOCOL and delete > QemuAcpiTableNotify.h. > #2: Use local variable of ChAcpiHandle to store the handle. > #3: Use local variable of QemuAcpiHandle to store the handle. > #4: Add log to show how many ACPI tables installed. > #5: Refactor the installation of QemuAcpiTableNotifyProtocol and > its error handling. > #6: Return error code if QemuAcpiTableNotifyProtocol is failed to be > installed so that the caller can handle the error. > > Code: https://github.com/mxu9/edk2/tree/AcpiPlatformDxe.v3 > > v3 changes: > - Set QemuAcpiHandle to NULL right before installing the > gQemuAcpiTableNotifyProtocol. > > v2 changes: > - Split v1 patch into 6 separate patches. > > Cc: Laszlo Ersek > Cc: Erdem Aktas > Cc: James Bottomley > Cc: Jiewen Yao > Cc: Gerd Hoffmann > Cc: Tom Lendacky > Cc: Sebastien Boeuf > Reported-by: Laszlo Ersek > Signed-off-by: Min Xu > > Min M Xu (6): > OvmfPkg/AcpiPlatformDxe: Remove QEMU_ACPI_TABLE_NOTIFY_PROTOCOL > OvmfPkg/AcpiPlatformDxe: Use local variable in CloudHvAcpi.c > OvmfPkg/AcpiPlatformDxe: Use local variable in QemuFwCfgAcpi.c > OvmfPkg/AcpiPlatformDxe: Add log to show the installed tables > OvmfPkg/AcpiPlatformDxe: Refactor QemuAcpiTableNotifyProtocol > OvmfPkg/AcpiPlatformDxe: Return error if installing NotifyProtocol > failed > > OvmfPkg/AcpiPlatformDxe/CloudHvAcpi.c | 23 +++++----- > OvmfPkg/AcpiPlatformDxe/QemuFwCfgAcpi.c | 43 ++++++++++++------- > .../Include/Protocol/QemuAcpiTableNotify.h | 27 ------------ > 3 files changed, 40 insertions(+), 53 deletions(-) > delete mode 100644 OvmfPkg/Include/Protocol/QemuAcpiTableNotify.h > https://github.com/tianocore/edk2/pull/3897 Commit range ba08910df107..7cd55f300915. Thanks.