From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 2EC1AAC19E3 for ; Thu, 18 Jan 2024 20:28:35 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=JC8WVlJlaTAIWd6qMuMsnFKjnxiYEo2KvrxhqsZRQuk=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1705609714; v=1; b=vw/7YZHhCTJ8BoV70jDcFCIH+dRzg8SRyBCTwGytyVXfPkR4Dj00gGcbnx33n2yOUyYdPHKc NXcOF0X1MUKUqGfLZLLHNQpm7Z4tep3ucu1nZw9GOYzue+VrdiEm/S8QLXp0fcnkiZFh+IlSb7m kQx1ZByxLFmUhbEtM41MMxUM= X-Received: by 127.0.0.2 with SMTP id uN8vYY7687511x1OOzNamyzz; Thu, 18 Jan 2024 12:28:34 -0800 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web11.3967.1705609713786074328 for ; Thu, 18 Jan 2024 12:28:33 -0800 X-Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-128-y8zynPs3NyCdKmBEdnt3dw-1; Thu, 18 Jan 2024 15:28:26 -0500 X-MC-Unique: y8zynPs3NyCdKmBEdnt3dw-1 X-Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 61F8388CDCA for ; Thu, 18 Jan 2024 20:28:25 +0000 (UTC) X-Received: from [10.39.194.70] (unknown [10.39.194.70]) by smtp.corp.redhat.com (Postfix) with ESMTPS id BF019200A2F4; Thu, 18 Jan 2024 20:28:24 +0000 (UTC) Message-ID: <0e75f505-063f-171a-676e-59c6fcc56c6c@redhat.com> Date: Thu, 18 Jan 2024 21:28:23 +0100 MIME-Version: 1.0 Subject: Re: [edk2-devel] [PATCH v3 0/6] OvmfPkg/VirtNorFlashDxe: fix corruption + misc small improvements To: devel@edk2.groups.io, kraxel@redhat.com Cc: oliver@redhat.com References: <20240116171105.37831-1-kraxel@redhat.com> From: "Laszlo Ersek" In-Reply-To: <20240116171105.37831-1-kraxel@redhat.com> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.4 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,lersek@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: p79j7GlF49Il8flBKnN0vQoux7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b="vw/7YZHh"; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On 1/16/24 18:10, Gerd Hoffmann wrote: > This is a little series containing the flash corruption fix sent > yesterday with an slightly improved commit message and some small > improvements on top of this. >=20 > v3: > - fix diagram > - fix DoErase control flow > - pick up reviewed-by tags > v2: > - drop broken bugfix, fix the bug when introducing Start+End variables > instead. > - add patch with UINTN and UINT32 casts. > - add patch splitting the DoErase code path into a new function. > - add the diagram sent by Laszlo. >=20 > Gerd Hoffmann (6): > OvmfPkg/VirtNorFlashDxe: add casts to UINTN and UINT32 > OvmfPkg/VirtNorFlashDxe: clarify block write logic & fix shadowbuffer > reads > OvmfPkg/VirtNorFlashDxe: add a loop for NorFlashWriteBuffer calls. > OvmfPkg/VirtNorFlashDxe: allow larger writes without block erase > OvmfPkg/VirtNorFlashDxe: ValidateFvHeader: unwritten state is EOL too > OvmfPkg/VirtNorFlashDxe: move DoErase code block into new function >=20 > OvmfPkg/VirtNorFlashDxe/VirtNorFlash.h | 2 +- > OvmfPkg/VirtNorFlashDxe/VirtNorFlash.c | 145 ++++++++++++++-------- > OvmfPkg/VirtNorFlashDxe/VirtNorFlashFvb.c | 5 + > 3 files changed, 101 insertions(+), 51 deletions(-) >=20 Merged as commit range 59f024c76ee5..b481b00f593e, via . Thanks! Laszlo -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#114010): https://edk2.groups.io/g/devel/message/114010 Mute This Topic: https://groups.io/mt/103766773/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/19134562= 12/xyzzy [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-