From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR03-AM7-obe.outbound.protection.outlook.com (EUR03-AM7-obe.outbound.protection.outlook.com [40.107.105.55]) by mx.groups.io with SMTP id smtpd.web12.6806.1666787815948161362 for ; Wed, 26 Oct 2022 05:36:56 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=DxhkbZ/K; spf=pass (domain: arm.com, ip: 40.107.105.55, mailfrom: sami.mujawar@arm.com) ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=MhhXDkJhHU0UnX8/l1aK1gflYcjrEpoChRU4ugMnnqrCUHo3CVIlsPKLpk1BwsA4qyRP6L3y3W7u+Fz1aCZpCXleXk9Cax6kp5YkEoVi/pJrWnQUAS5bkT8taSBSZZwLaQXOMLgJnU960O1O4lGG7Cgz/cReIHi6pRdwhN2SSEAIchB68+aMBSQ2CEJUuLvHJfkS7kUHzXbIk/pbxW1aCyd3ccg+ffp29UFqbJvt0kmC0TJte4UsI2j92exhUOHKeDJp4yutpyii2uN6MCtXRcHCRokCA5AX/Dwz9SBhYjwAtpuLgnysKFon/4v5nQlEmu/j6UNLXC6i7Xd5qH7SDg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5tCf6w94dUyDT4XruJeJ9ca6wFbf8b4Zh0eWWbhbHfQ=; b=LNS2GzpP2BdbpF9Yd2Xn+/+jVawGtJre7cnEUIc8wRHcFmyL11LC2ccmeGzmgE6aT+6Y5javsHLc5jBN/JIoIErBtYFxy2HFTNn84DL2oMnUnOy2aAIVcHwTdE/ZtnhsZ8EOdNkAD/GP7wKyJ5ct5GN7ecj/vDgN+hKEDHjgO+hxlQpB4dgyZdKQzoY5Wl4NaUtBqnhgMOGItZ561gzHgJs1aiBQIfY1b+tNIlaSBb/eqvQZil0hE940JtpPy0uM2HDmEFGchRydLKHbwCTl2C6uVhD6A/YJGTUqiuDjI6WakFqXbIV8j97xw9bWhTq4ihw9Nol6fxO66Cgn0tiNvQ== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5tCf6w94dUyDT4XruJeJ9ca6wFbf8b4Zh0eWWbhbHfQ=; b=DxhkbZ/KacB12rkxP3s4NLktSAyq+jbXqGvrdRufdwlKL6G6qfllSW0/2ORvnBjom7k0JPcYL+XwPnjHj+YJ6Q85Hud1EBYE/TwbL9qADPSU7kQNwUJP5UJNZJu83Cl6tVjRBedVanO6XpG2F1wMo8035O5EaebWYVr3QwcVNRI= Received: from AS9PR06CA0291.eurprd06.prod.outlook.com (2603:10a6:20b:45a::15) by VE1PR08MB5774.eurprd08.prod.outlook.com (2603:10a6:800:1a1::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.26; Wed, 26 Oct 2022 12:36:51 +0000 Received: from AM7EUR03FT027.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:45a:cafe::64) by AS9PR06CA0291.outlook.office365.com (2603:10a6:20b:45a::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.28 via Frontend Transport; Wed, 26 Oct 2022 12:36:51 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT027.mail.protection.outlook.com (100.127.140.124) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.19 via Frontend Transport; Wed, 26 Oct 2022 12:36:50 +0000 Received: ("Tessian outbound 6c699027a257:v130"); Wed, 26 Oct 2022 12:36:50 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 57c808424f8f9ce3 X-CR-MTA-TID: 64aa7808 Received: from f0de342ee718.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 410BD42F-1851-42BE-9840-C7FF1A60C05C.1; Wed, 26 Oct 2022 12:36:39 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id f0de342ee718.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 26 Oct 2022 12:36:39 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=e3hLeahQlXTJjiaEtSBZxNElYQKF6rj2YvCt5zjbAxRd+mr1Z4AZCxPM84up4N3IazDiqbM338bPnTDSSYtStjyQCrCMPrKGvDXAIMuavUl4nGq5opXukzb6A6luZQvoVhGi7XVdBztgiSlIbpvmy+gPv1F7tVyH0JcPuY8QsHqAyicEIM7TsT7//0IbnkXqINmsLABmavd98JbnMRTB5opp0XEGMcUWpd2iB1sTmoCX2F3e9GAUhAiRisL2l84mW09EPsxx7dVjNLTTvymslQJB+tmw0cthLuEUrCZcWbvCDiZYPUhLiYw4VOHspFuRvnVP8q/1jj38aOwOdhekmg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5tCf6w94dUyDT4XruJeJ9ca6wFbf8b4Zh0eWWbhbHfQ=; b=X2jlE7kDfydwgsI2nI0FJOAzRwKlv35d1eyF6ujy9wEI+2ROSK675WTntdvTBdisDB90YvErefqkjXpXnHcPKQpSeoGWeKAshGUkoDMhJXwqXqwlPZaPj/a47RKtZpev67KZFh/B7LHcYJ8ssHOYr1Pbdclef7+pZoxsRRxMV0hXoWJIy8/k9aiJN9TkCGAouLUewG669PElEsLAxJUFDrcKQXbdM1y4HxlQuJt/F5F7e2CQbKcRYHTCVlPLLK2ddIx+0ialWA6WQEW3mVxlbq7y7qSAtS5yOF91folz7co2YmvEf2R7HNAmTyBHv1jldQ7EeqswBJoQnwcxalD+tw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5tCf6w94dUyDT4XruJeJ9ca6wFbf8b4Zh0eWWbhbHfQ=; b=DxhkbZ/KacB12rkxP3s4NLktSAyq+jbXqGvrdRufdwlKL6G6qfllSW0/2ORvnBjom7k0JPcYL+XwPnjHj+YJ6Q85Hud1EBYE/TwbL9qADPSU7kQNwUJP5UJNZJu83Cl6tVjRBedVanO6XpG2F1wMo8035O5EaebWYVr3QwcVNRI= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) by PAXPR08MB6398.eurprd08.prod.outlook.com (2603:10a6:102:12d::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.26; Wed, 26 Oct 2022 12:36:37 +0000 Received: from AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::283c:fe2e:699d:2bf]) by AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::283c:fe2e:699d:2bf%5]) with mapi id 15.20.5746.027; Wed, 26 Oct 2022 12:36:37 +0000 Message-ID: <0eb939da-a13a-4851-3d8d-f17d9b716fdd@arm.com> Date: Wed, 26 Oct 2022 13:36:36 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Subject: Re: [PATCH 02/14] DynamicTablesPkg: Add PrintString to CmObjParser To: Pierre.Gondois@arm.com, devel@edk2.groups.io Cc: Alexei Fedorov , "nd@arm.com" References: <20221010092058.118714-1-Pierre.Gondois@arm.com> <20221010092058.118714-3-Pierre.Gondois@arm.com> From: "Sami Mujawar" In-Reply-To: <20221010092058.118714-3-Pierre.Gondois@arm.com> X-ClientProxiedBy: LO4P123CA0252.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1a7::23) To AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: AS8PR08MB6806:EE_|PAXPR08MB6398:EE_|AM7EUR03FT027:EE_|VE1PR08MB5774:EE_ X-MS-Office365-Filtering-Correlation-Id: 2cafa9b2-1b16-4880-2357-08dab74ec198 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: otZI6UAHTrDq9fHI2xacpfgqCw2KHxNE4VnJbZAx7lmUYFr53kXoCmdlNltjnDGu8j3m1XIgFICTIzRVUFh3I2pRLsaRhHSZBNtn7ooWFafJIWYX2t4EDh5Trpjse1kaQEXAsYgRMZwVdxh3y9jG9B994ZZ+p/EOD8dzklNVWwjdL8expPsBo1MXdEML9lq+N1HbAyCnJj8IZlAHf6GFnrYMntaSKKVtNoyejOT0xFC2MjvznfX1YOTlgUWBWvmfIkB3sviQh3ea97oBpP1loBU4dwHJuhQs0Jg9thEnBlBymE9KJn6BP5SNaGsrRVpjztYdQuEg2jbz3IRAzzDOWutYuIwL7LuEa1ltzgXuLvYR0sMBpDPcGXRn13JquKVSeR2s4yqmZtBq7eVGmPwDQPCDuqFOl8GdaDHcyWU2MRf3GmBIr1LW2H6FvfGiEFdBq2SUaxyX67yPT2rnzcXn7CGMWaoXV9jQba0g1j3wNQJn93e+CmUPnbDY853kDYYd8xHBy6NfpUO0eWtHMMa2zNr/RQFGcUGCZ7dVP2GfrgDJ0ymlj7200ibBg0eKUNEAgVz19ZnKloMOvnKGXUeTXlhCWzTtOw52VHepXIFowgP/04kSWf1ZPq8K8Vr4p9mopnNKG4n7ecGhE3ojUvwaIo5TZoxHDIsYzwfHL3kZZrKLlWhZCMcJV2wlkGrFBSIIEsleR9RliU6JdWiWj8g2kSQniuBCBqnfuT8ZQy1bhU2z0lM92n8aOHEkP4J1u+Vzczels9zxPzMawvJ7ankPywrDCOTfS+KiYDp9zzP1StM= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB6806.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(6029001)(4636009)(136003)(376002)(346002)(366004)(39860400002)(396003)(451199015)(66556008)(86362001)(38100700002)(31696002)(66476007)(8936002)(66946007)(5660300002)(44832011)(8676002)(6506007)(4326008)(41300700001)(2906002)(53546011)(6486002)(36756003)(26005)(2616005)(6512007)(54906003)(316002)(478600001)(31686004)(186003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB6398 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Return-Path: Sami.Mujawar@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT027.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 9002ce34-1298-47a3-1e68-08dab74eb977 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: RtxXLbXPJdnjQ4Ui9cnaBq0k8H75wu39O2MmIX+ccMKcC9eYxHyEGsgyjz4SbLKvTz5xLDV1ATYZ0aMReX4Dnn67XNGjs8vy3rvtKipugjluh15G9wcGiWhFNQCIDMaIYGSMtjZ3IwHYE0iEyu0nVZ6KvZA6QSyLS6IDH4v29y8nqkBTmeWNsSBzGsgvfeQOLDphyK/lAb8VZaXKH7I2QRbU6ezPR/KOXPCfkT77rVXQlBafFuAnVruqqqvBZ+aGRPUUapSIner6yPj1kbQhwBF4an3lyEhFmk9+Zoija1zlCOFlH6NkQzpYgFVFw/vGfho2uMbfUugebQgTxU7aoxFPueUmAZkFYKiC5H3r34DG6RhNq14yNHwMbKhNiZj7+nTpsUBJxuOVf12j8bU17wJmhm5o18YW+j323FEN1RWiQeQcwq2ggv1FGvonLNWth2pYA5Y6YZfV8NHTfBpcyAh7VSPzDvK7uobHqAb//Oy/O4YE0Z7KW2pDiRMTSExT8CzaMQrdlZ3LOkfdTKP0WxEm7cBDpCQkur+JYw+x/cnBNlpuPCBc8Zgys6qd0OEXVff3x4wQweCi2XidU2kqFHqu7bwGu1kwk2AZc1vq21yzYHGuq6nYt14/fX5t8ADaeTJvj0mBOys3+bykKT2eioJZAouBfdHGE82XBdf//ZmsvfOOY2cSXEdylxY0RjHeGVrf1YWDOQTYumCbmA7TuGc4oI29ijOwUwLlxvCBoT8RqPle4SqKODIPc4fDHoYvb3t083PzlzfzuBlnroZcT7d88wYeWHVNXjfrFho+zXcCXFaggzmpzyaTbUzxO3i0 X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(6029001)(4636009)(136003)(346002)(39860400002)(396003)(376002)(451199015)(36840700001)(40470700004)(46966006)(478600001)(6486002)(31696002)(86362001)(47076005)(31686004)(54906003)(53546011)(8676002)(70206006)(316002)(4326008)(6506007)(6512007)(36756003)(26005)(8936002)(41300700001)(5660300002)(2906002)(40480700001)(336012)(186003)(44832011)(70586007)(2616005)(81166007)(40460700003)(82310400005)(82740400003)(356005)(36860700001)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Oct 2022 12:36:50.9026 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 2cafa9b2-1b16-4880-2357-08dab74ec198 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT027.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB5774 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Pierre, Thank you for this patch. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 10/10/2022 10:20 am, Pierre.Gondois@arm.com wrote: > From: Pierre Gondois > > Add a PrintString to print strings in the CmObjParser. > String must be NULL terminated and no buffer overrun check > is done by this function. > > Signed-off-by: Pierre Gondois > --- > .../ConfigurationManagerObjectParser.c | 26 +++++++++++++++++++ > 1 file changed, 26 insertions(+) > > diff --git a/DynamicTablesPkg/Library/Common/TableHelperLib/ConfigurationManagerObjectParser.c b/DynamicTablesPkg/Library/Common/TableHelperLib/ConfigurationManagerObjectParser.c > index 13e6c0e321c4..b46f19693bb5 100644 > --- a/DynamicTablesPkg/Library/Common/TableHelperLib/ConfigurationManagerObjectParser.c > +++ b/DynamicTablesPkg/Library/Common/TableHelperLib/ConfigurationManagerObjectParser.c > @@ -19,6 +19,14 @@ PrintOemId ( > UINT8 *Ptr > ); > > +STATIC > +VOID > +EFIAPI > +PrintString ( > + CONST CHAR8 *Format, > + UINT8 *Ptr > + ); > + > /** A parser for EArmObjBootArchInfo. > */ > STATIC CONST CM_OBJ_PARSER CmArmBootArchInfoParser[] = { > @@ -646,6 +654,24 @@ PrintOemId ( > )); > } > > +/** Print string. > + > + The string must be NULL terminated. > + > + @param [in] Format Format to print the Ptr. > + @param [in] Ptr Pointer to the string. > +**/ > +STATIC > +VOID > +EFIAPI > +PrintString ( > + CONST CHAR8 *Format, > + UINT8 *Ptr > + ) > +{ > + DEBUG ((DEBUG_ERROR, "%a", Ptr)); > +} > + > /** Print fields of the objects. > > @param [in] Data Pointer to the object to print.