From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (EUR05-AM6-obe.outbound.protection.outlook.com [40.107.22.71]) by mx.groups.io with SMTP id smtpd.web12.13309.1633369606786016405 for ; Mon, 04 Oct 2021 10:46:47 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=Ckh+AV+n; spf=pass (domain: arm.com, ip: 40.107.22.71, mailfrom: sami.mujawar@arm.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CyzpMBq5+JpGFbVMdbD21kT7mkDOmdNnQn8mFJpXsJs=; b=Ckh+AV+nm6nPsEjCMTOXuCzTIQ8faoi5c8Yt0R7WSXNZZoL1vMruijDwfhpJIt5i2EfrL/XxJCZwFxTqEWt1VDj/sIqHapcYgv3GbZyDnRD/r3EJjeVna8RX2DpGgZPfU5U+NcpC01KstKSzCxkawtArnaymQCtAN0MwKaH+134= Received: from AM6P195CA0104.EURP195.PROD.OUTLOOK.COM (2603:10a6:209:86::45) by AS8PR08MB6119.eurprd08.prod.outlook.com (2603:10a6:20b:290::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.22; Mon, 4 Oct 2021 17:46:44 +0000 Received: from VE1EUR03FT054.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:86:cafe::d) by AM6P195CA0104.outlook.office365.com (2603:10a6:209:86::45) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.16 via Frontend Transport; Mon, 4 Oct 2021 17:46:44 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; edk2.groups.io; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;edk2.groups.io; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT054.mail.protection.outlook.com (10.152.19.64) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.14 via Frontend Transport; Mon, 4 Oct 2021 17:46:43 +0000 Received: ("Tessian outbound 010023020eef:v103"); Mon, 04 Oct 2021 17:46:42 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: a3f325bd68110777 X-CR-MTA-TID: 64aa7808 Received: from ffaa259f70d0.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 20253E01-7EED-4C4F-9619-E3245FF58ACD.1; Mon, 04 Oct 2021 17:46:32 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id ffaa259f70d0.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 04 Oct 2021 17:46:32 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Tabze6xJK6K7EBQ9sywL394mYssrfIglPSeltg4Jvlu1KOjCC86pBYoRrLmRxLjv/pQXawU2S1mUjCci2QZlV8ncqrQNj/gdY55a/svHVsggodax2PnUrQ1OG4eEvt11zkA+K8PWgUit7V1DkAFe5WUv8LT+Fln1TL06BASwCdi9Td7lcVGhQufwR8ckSU4dlDwi5BvuM4+r8n8mI0+eI4oi2nDqnlaBUH7joDXu8TYEBwoDd8rJrKmiLbM7MqCsinhLjQWIbPfxdQsuqV/rhuGldco6ukxGx6XGH+xogWycRcW+1sJrZF4ijL3N//yLk/MgFvHTVp5lDq/IZlr2kA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CyzpMBq5+JpGFbVMdbD21kT7mkDOmdNnQn8mFJpXsJs=; b=M6bMixEtI2fWEn8Z3ianEE/88w3yGjl1LnmrauFDDcYT1tIQVlfa8zZav11Aogp1CIfqOmaJUCP0wP6lPr2M8t5GAfGFqATfC5lxtIHaxxlcHzi9HrVbWhwt0x/zSVed2y0KIlTcPShibVRY/WeUKGTjgqSsHQJquYGPtlJomsea10fpABmOjdMhRypcAUrp8ot08OiCmgKuUkoqZnFBDXfKKJ+cDp51gHoQm+Fl4zzDXuBDwAyBEQxkrB5r+HNCl0lD2Vp7sadH7bO1RsQmkWwxty4k2lyGx3i5/3Hw7mtvvCmiTNn0UaNhzCjE6NplCYjjXdz79rFNfoXf13SBGA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CyzpMBq5+JpGFbVMdbD21kT7mkDOmdNnQn8mFJpXsJs=; b=Ckh+AV+nm6nPsEjCMTOXuCzTIQ8faoi5c8Yt0R7WSXNZZoL1vMruijDwfhpJIt5i2EfrL/XxJCZwFxTqEWt1VDj/sIqHapcYgv3GbZyDnRD/r3EJjeVna8RX2DpGgZPfU5U+NcpC01KstKSzCxkawtArnaymQCtAN0MwKaH+134= Authentication-Results-Original: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=arm.com; Received: from AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) by AM6PR08MB4597.eurprd08.prod.outlook.com (2603:10a6:20b:90::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.22; Mon, 4 Oct 2021 17:46:30 +0000 Received: from AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::54b5:239d:9896:ee65]) by AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::54b5:239d:9896:ee65%4]) with mapi id 15.20.4566.022; Mon, 4 Oct 2021 17:46:30 +0000 Subject: Re: [edk2-platforms][PATCH v3 0/5] Add support to generate HEST ACPI table To: Omkar Anand Kulkarni , devel@edk2.groups.io Cc: Ard Biesheuvel , nd References: <20210824053403.24103-1-omkar.kulkarni@arm.com> From: "Sami Mujawar" Message-ID: <0eb9a8ac-efdd-8d76-2a76-c25721309b45@arm.com> Date: Mon, 4 Oct 2021 18:46:29 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.0.1 In-Reply-To: <20210824053403.24103-1-omkar.kulkarni@arm.com> X-ClientProxiedBy: LO2P265CA0166.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:9::34) To AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) MIME-Version: 1.0 Received: from [10.1.196.43] (217.140.106.52) by LO2P265CA0166.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:9::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.16 via Frontend Transport; Mon, 4 Oct 2021 17:46:30 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 28e0e8ea-f287-4c2e-e33f-08d9875eee0e X-MS-TrafficTypeDiagnostic: AM6PR08MB4597:|AS8PR08MB6119: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:6108;OLM:6108; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: TeUeTpzFk13+wX1XS/mYp9Gpg2uVatzGu73KAuwhTrz6kLiP7AvqnjVaqwBic12mXhE+yUBMBCxQxwa3qL9NAIcD+kq4KujtvDemu3G93j9b4013vQEA4dI0ex1DRpBwJTygqHxgvQy3Ha36bCR4LjpR9RKMjZEL8O9uQEanCL2qc7shT7lNvkb7ydHcMLS2fMSsAnqfPrSWNJDLRabEqNgZvOOtSTtbUN2bUgcJLfrM1x9+B0cMPX3d5CeCHHpR5RKUFirl8Fu/1HLhkQi/1lOvpk+010D8Zz+utBzw1RqNevOzcmLvWNzmDsvZC5oA4oLJBldL7Lf2saAgYLJc6C0My6we/aOU+rowra360epAMqlVyKnOT4BCJ3ogo+E7ZrnLS96yAiJqI1Csr2z2n24ry6yiLQuJMdFoiV4I3AbJ9+hEzssMDFrpAm4s2QSQ62LN//2AaeKbfl+G1BxlvgWf3DdmxFfaNnqPhvSSRXqDXkCTknv/3Tsag97fBLLY+0UeiVS6+Sgr91SsKs/8P8YRt+z4hfsRZzqtt8Ao/R79Gz8V45wjmp8dUYcEqQRUEpCdU6w1g0A1ArKVLcvQs4M7VGIsduoT9RzlJEMKc3S/CoTRadXzLnoLniWCJz2HKL4a43yzSuHF2QBVbtRSnjfpNMhg10V/lVHbW16ba6v27BAliVuUiIAf5Z4DTk8iV9AqvxdXuHKAgit2oOGMPB/5tDir3mQP//TmQgpIyBNM8czTI2nttcvBLPCEmv4xm8ert/ZoqAPP+mpzC82tCZTPayIGX/Z+ne11hGTO+glMG80zK2t+4Tg9VDQ9LapdONfnht5/CTQLR3f3NGtqHe7BRu6zJpKmiUJ+PPVexCw= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB6806.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(53546011)(52116002)(8936002)(36756003)(86362001)(5660300002)(38350700002)(38100700002)(508600001)(186003)(44832011)(66476007)(6486002)(66946007)(26005)(966005)(16576012)(66556008)(31696002)(2616005)(31686004)(4326008)(8676002)(2906002)(956004)(316002)(54906003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB4597 Original-Authentication-Results: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=arm.com; Return-Path: Sami.Mujawar@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT054.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 5ba38d14-e410-428b-a3e9-08d9875ee60a X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: fWlI5szIbfBuC9o2Nl49Wf+UAI+he/dPC1DiNso3A3jk/Tc2xJSHFxZBWShWwH/Tp1rH9ewUjUBqrLm5gYL/mz5YAvYygm+3FTGvI3lrmzIWjeNW3NDEJ+NzdTgzGD1qX6l6FIkIN1iiICvzIuRJwwCkLpZKFlx0h1XNHx44xHieFb0GXw8iaGZbd3Sf3BNaEsi6+sUvqy/e06Y8Q9Q5d0FCI6RsoiDZy2Z1NqTFgGVCWerzCegKMeXSdy3kbXbSFVKcIKL/TpJ4gjJ6M+71z3Et3Td9FOJ4hWEupJZyzsbf3Ra3zX9x+sNDJwBxgHGGyztKZRdTI26GVIWX2P+FNt4tZO9Tnt7YLNLhxQkxeBjQUcxxn/4dLu3RrTSUfOz70KYoPsD6EAa/9ZLXq/CAb/5iTwu4wX2xs9FZF2GywuRrVEZyB0BMKVPYu6hR3PuhXug3YdO/HvKiE4lOQ3nCCluhfaKVZHKYp49Mm9hPd2lON+rN9mUunJIthu54dFcKrQ4hVYLoyfJCHO2JHVF7ZJMYLQVD1/UZ5+CYSnq77twsEE7Jn/rWM7wUgPHvwZdGuaFG+mYuFFm9VoSbN2BsPHzLDTQIyoPtZqWB+lyQQRCpsTEjmX0SPkGIXVXputcYrJeqnmbHZPxk1kNH0xGj5QS3fi1Byh9idAxEUQUGx3M+zMHGmUIcWZbDXttGdE1ejqpkjGqLSiONIMrfgMArvR5PLcbMnGrmexo1BR24ttRqoie99JsCrMVnaTNXDIDVcudDDvzLYInduGFsvcg2PTflx4KlN+j687gS8XLNCi8+rs4QAmja/2FXm5bxwfiP X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(46966006)(36840700001)(508600001)(54906003)(956004)(16576012)(47076005)(44832011)(36756003)(53546011)(5660300002)(8936002)(36860700001)(966005)(8676002)(316002)(2906002)(2616005)(82310400003)(70586007)(6486002)(4326008)(186003)(31686004)(336012)(356005)(31696002)(86362001)(81166007)(70206006)(26005)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Oct 2021 17:46:43.9206 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 28e0e8ea-f287-4c2e-e33f-08d9875eee0e X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT054.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6119 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-GB Hi Omkar, The subject for this patch series should be fixed. These patches are not for edk2-platforms. Regards, Sami Mujawar On 24/08/2021 06:33 AM, Omkar Anand Kulkarni wrote: > Changes since v2: > - Addressed the comments given by Sami. > - Added Readme file with all cover letter information. > - Rebased to the latest upstream code. > > Hardware Error Source Table (HEST)[1] and Software Delegated Exception Interface > (SDEI)[2] ACPI tables are used to acomplish firmware first error handling.This > patch series introduces a framework to build and install the HEST ACPI table > dynamically. > > The following figure illustrates the possible usage of the dyanamic > generation of HEST ACPI table. > > NS | S > +--------------------------------------+--------------------------------------+ > | | | > |+-------------------------------------+---------------------+ | > || +---------------------+--------------------+| | > || | | || | > || +-----------+ |+------------------+ | +-----------------+|| +-------------+| > || |HestTable | || HestErrorSource | | | HestErrorSource ||| | DMC-620 || > || | DXE | || DXE | | | StandaloneMM ||| |Standalone MM|| > || +-----------+ |+------------------+ | +-----------------+|| +-------------+| > || |GHESv2 | || | > || +---------------------+--------------------+| | > || +--------------------+ | | | > || |PlatformErrorHandler| | | | > || | DXE | | | | > || +--------------------+ | | | > ||FF FWK | | | > |+-------------------------------------+---------------------+ | > | | | > +--------------------------------------+--------------------------------------+ > | > Figure: Firmware First Error Handling approach. > > All the hardware error sources are added to HEST table as GHESv2[3] error source > descriptors. The framework comprises of following DXE and MM drivers: > > - HestTableDxe: > Builds HEST table header and allows appending error source descriptors to the > HEST table. Also provides protocol interface to install the built HEST table. > > - HestErrorSourceDxe & HestErrorSourceStandaloneMM: > These two drivers together retrieve all possible error source descriptors of > type GHESv2 from the MM drivers implementing HEST Error Source Descriptor > protocol. Once all the descriptors are collected HestErrorSourceDxe appends > it to HEST table using HestTableDxe driver. > > Link to github branch with the patches in this series - > https://github.com/omkkul01/edk2/tree/ras_firware_first_edk2-platforms_v3 > > Omkar Anand Kulkarni (5): > MdeModulePkg: Allow dynamic generation of HEST ACPI table > ArmPlatformPkg: add definition for MM_HEST_ERROR_SOURCE_DESC_PROTOCOL > ArmPlatformPkg: retreive error source descriptors from MM > EmbeddedPkg: Add helpers for HEST table generation > ArmPlatformPkg: Add Readme file > > ArmPlatformPkg/ArmPlatformPkg.dec | 10 + > MdeModulePkg/MdeModulePkg.dec | 3 + > .../HestMmErrorSources/HestErrorSourceDxe.inf | 45 +++ > .../HestErrorSourceStandaloneMm.inf | 51 +++ > .../Universal/Apei/HestDxe/HestDxe.inf | 49 +++ > .../HestMmErrorSourceCommon.h | 37 ++ > .../Include/Protocol/HestErrorSourceInfo.h | 64 ++++ > EmbeddedPkg/Include/Library/AcpiLib.h | 20 ++ > MdeModulePkg/Include/Protocol/HestTable.h | 71 ++++ > MdePkg/Include/Protocol/MmCommunication.h | 2 + > .../HestMmErrorSources/HestErrorSourceDxe.c | 309 +++++++++++++++++ > .../HestErrorSourceStandaloneMm.c | 312 +++++++++++++++++ > MdeModulePkg/Universal/Apei/HestDxe/HestDxe.c | 318 ++++++++++++++++++ > .../Drivers/HestMmErrorSources/Readme.md | 66 ++++ > 14 files changed, 1357 insertions(+) > create mode 100644 ArmPlatformPkg/Drivers/HestMmErrorSources/HestErrorSourceDxe.inf > create mode 100644 ArmPlatformPkg/Drivers/HestMmErrorSources/HestErrorSourceStandaloneMm.inf > create mode 100644 MdeModulePkg/Universal/Apei/HestDxe/HestDxe.inf > create mode 100644 ArmPlatformPkg/Drivers/HestMmErrorSources/HestMmErrorSourceCommon.h > create mode 100644 ArmPlatformPkg/Include/Protocol/HestErrorSourceInfo.h > create mode 100644 MdeModulePkg/Include/Protocol/HestTable.h > create mode 100644 ArmPlatformPkg/Drivers/HestMmErrorSources/HestErrorSourceDxe.c > create mode 100644 ArmPlatformPkg/Drivers/HestMmErrorSources/HestErrorSourceStandaloneMm.c > create mode 100644 MdeModulePkg/Universal/Apei/HestDxe/HestDxe.c > create mode 100644 ArmPlatformPkg/Drivers/HestMmErrorSources/Readme.md >