Re: [edk2-devel] [PATCH v2 0/4] BaseTools/PatchCheck: Check committer/author email addresses

["Philippe Mathieu-Daudé" <philmd@redhat.com>]

On 1/9/20 10:50 AM, Feng, Bob C wrote:
> Please update the copyright to 2020.

OK will do.

> 
> For the patch set,
> 
> Reviewed-by: Bob Feng <bob.c.feng@intel.com>

Thanks!

> 
> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Philippe Mathieu-Daudé
> Sent: Monday, January 6, 2020 6:35 PM
> To: devel@edk2.groups.io
> Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Laszlo Ersek <lersek@redhat.com>; Philippe Mathieu-Daude <philmd@redhat.com>
> Subject: [edk2-devel] [PATCH v2 0/4] BaseTools/PatchCheck: Check committer/author email addresses
> 
> Last month I cleaned the git-history incorrect email
> addresses: https://edk2.groups.io/g/devel/message/51834
> but today I noticed more incorrect addresses got committed (see caa917491a4..33a3293651).
> To avoid having the same cleanup in the future, fix the problem once for all by having PatchCheck doing this automatically (on merge).
> 
> Since we already have code to check email address in PatchCheck, factor the code out to reuse it, and add checks for committer/author addresses.
> 
> Series only tested on Linux.
> 
> Since v1 [*]:
> - Addressed Jordan Justen review comment
> 
> [*] https://edk2.groups.io/g/devel/message/52656
> 
> Philippe Mathieu-Daude (4):
>    BaseTools/PatchCheck.py: Extract email check code to EmailAddressCheck
>    BaseTools/PatchCheck.py: Let EmailAddressCheck describe email checked
>    BaseTools/PatchCheck.py: Check the patch author email address
>    BaseTools/PatchCheck.py: Check the committer email address
> 
>   BaseTools/Scripts/PatchCheck.py | 99 +++++++++++++++++++++++----------
>   1 file changed, 69 insertions(+), 30 deletions(-)