From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.81]) by mx.groups.io with SMTP id smtpd.web12.7048.1578566384727933051 for ; Thu, 09 Jan 2020 02:39:45 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Uc6aFBbP; spf=pass (domain: redhat.com, ip: 207.211.31.81, mailfrom: philmd@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1578566383; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=T0amWnO/CDkXGJ3xzmh5CCv46JJgIJzn8liBVVOXT5o=; b=Uc6aFBbPS7qSdG2u5LzH0P3yCuQr1lm9kGdAHkuindnmyCVi83KvrN/arvdBfjcPuDekWS h4lLurOpWVBvNuE3R8myaSJxhJHBqmsPSJNbTTOJxeXgVPeU5n9DRuurCZGjw0NWz3GkVU E4RCm8n2n1dfFc/H4U7TCyR0TTaDJTc= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-81-2oKOlr0iMo21GvUJVRRH9A-1; Thu, 09 Jan 2020 05:39:40 -0500 Received: by mail-wm1-f70.google.com with SMTP id y125so621693wmg.1 for ; Thu, 09 Jan 2020 02:39:39 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=vXOv9esw4x1k9NFdCPzokQTLpFmhAiXy/QodTrRO2mo=; b=c0e2QaLa0L8Da+520h8SMbfidpAZS+rHr5MCaKmoE8a1f8ZbYVbjmCi50dD50x0Tzv aPaYnFYmHbOkx0a8qI8qt8gCGV2NxDTc1RdO85INfL7qVPRaEP5UWDHTbZ7foO0JGVG8 tZEjd726v10W6mTvxH8aiVaZi4HmhUGhu3k7T/7bfTfNstnIxMl3ArNKcL2d7fbGSMdr JdaNADKoo5dE9bLTApvKjSu6suUp6Zn66/IbAnwCY21qTkaJhjf/eDkH8j09GAMMjIAG NT4nLXgCi4uujzunuNziC+xP1EZtv7QNgifekJ+2FR9BS+LY0MFBFMCP6TMgEEEMt4Ht ++iw== X-Gm-Message-State: APjAAAXVdHvQmUB9g8LjXY9prL7hVQG6X2nbZzJ7xLViAoMvxnmTBfuf uINvLFnyetVsfJW+Yaz2lRMeTIndoCilxAEf7i4qWd44gw3bz+z+GM4DQyPScN620J0bkGA12Dt ctAeAHc+Wmq28tA== X-Received: by 2002:a7b:cb0a:: with SMTP id u10mr3905220wmj.165.1578566379010; Thu, 09 Jan 2020 02:39:39 -0800 (PST) X-Google-Smtp-Source: APXvYqxwq2TTNyNaloMHpzONatMwoEL/nYibV5jtmoeZ+olAPdDVBAC4zLUPqzQfBm4HNcLyrhiy7Q== X-Received: by 2002:a7b:cb0a:: with SMTP id u10mr3905202wmj.165.1578566378836; Thu, 09 Jan 2020 02:39:38 -0800 (PST) Return-Path: Received: from [192.168.1.35] (113.red-83-57-172.dynamicip.rima-tde.net. [83.57.172.113]) by smtp.gmail.com with ESMTPSA id f1sm2543337wmc.45.2020.01.09.02.39.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 09 Jan 2020 02:39:38 -0800 (PST) Subject: Re: [edk2-devel] [PATCH v2 0/4] BaseTools/PatchCheck: Check committer/author email addresses To: "Feng, Bob C" , "devel@edk2.groups.io" Cc: "Kinney, Michael D" , Laszlo Ersek References: <20200106103528.5438-1-philmd@redhat.com> <08650203BA1BD64D8AD9B6D5D74A85D1615A131C@SHSMSX104.ccr.corp.intel.com> From: =?UTF-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= Message-ID: <0ed1c562-2454-9a85-e731-233011f86847@redhat.com> Date: Thu, 9 Jan 2020 11:39:37 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: <08650203BA1BD64D8AD9B6D5D74A85D1615A131C@SHSMSX104.ccr.corp.intel.com> X-MC-Unique: 2oKOlr0iMo21GvUJVRRH9A-1 X-Mimecast-Spam-Score: 0 Content-Language: en-US Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable On 1/9/20 10:50 AM, Feng, Bob C wrote: > Please update the copyright to 2020. OK will do. >=20 > For the patch set, >=20 > Reviewed-by: Bob Feng Thanks! >=20 > -----Original Message----- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Phi= lippe Mathieu-Daud=C3=A9 > Sent: Monday, January 6, 2020 6:35 PM > To: devel@edk2.groups.io > Cc: Kinney, Michael D ; Laszlo Ersek ; Philippe Mathieu-Daude > Subject: [edk2-devel] [PATCH v2 0/4] BaseTools/PatchCheck: Check committe= r/author email addresses >=20 > Last month I cleaned the git-history incorrect email > addresses: https://edk2.groups.io/g/devel/message/51834 > but today I noticed more incorrect addresses got committed (see caa917491= a4..33a3293651). > To avoid having the same cleanup in the future, fix the problem once for = all by having PatchCheck doing this automatically (on merge). >=20 > Since we already have code to check email address in PatchCheck, factor t= he code out to reuse it, and add checks for committer/author addresses. >=20 > Series only tested on Linux. >=20 > Since v1 [*]: > - Addressed Jordan Justen review comment >=20 > [*] https://edk2.groups.io/g/devel/message/52656 >=20 > Philippe Mathieu-Daude (4): > BaseTools/PatchCheck.py: Extract email check code to EmailAddressCheck > BaseTools/PatchCheck.py: Let EmailAddressCheck describe email checked > BaseTools/PatchCheck.py: Check the patch author email address > BaseTools/PatchCheck.py: Check the committer email address >=20 > BaseTools/Scripts/PatchCheck.py | 99 +++++++++++++++++++++++---------- > 1 file changed, 69 insertions(+), 30 deletions(-)