Re: [edk2-devel] Build fails with VS2012

["Laszlo Ersek" <lersek@redhat.com>]

Hi Rebecca

+Tom

On 05/08/21 21:47, Rebecca Cran wrote:
> I'm setting up a new Jenkins server to do Bhyve builds and run on
> platforms that aren't currently tested with the GitHub/Azure system.
> 
> Since VS2012 appears to be a supported toolchain, I tried building
> OvmfPkgX64 with it (I'm also planning on testing VS2013, VS2015, VS2017
> and VS2019), but it fails with:
> 
> 
> Building ...
> c:\users\administrator\src\edk2\NetworkPkg\Library\DxeUdpIoLib\DxeUdpIoLib.inf
> [X64]
> c:\users\administrator\src\edk2\UefiCpuPkg\Library\MpInitLib\MpLib.c(1268)
> : error C2220: warning treated as error - no 'object' file generated
> c:\users\administrator\src\edk2\UefiCpuPkg\Library\MpInitLib\MpLib.c(1268)
> : warning C4306: 'type cast' : conversion from 'int' to
> 'SEV_ES_AP_JMP_FAR *' of greater size

I think the compiler is justified to complain here:

7b7508ad784d1 (Tom Lendacky     2020-08-12 15:21:42 -0500 1268)   JmpFar = (SEV_ES_AP_JMP_FAR *) FixedPcdGet32 (PcdSevEsWorkAreaBase);

The proper way to spell such casts is with (UINTN) in the middle.

Can you please file a new BZ?

> I know the GitHub/Azure system only tests with VS2017 and VS2019: are
> there plans to drop the older VS versions, or should they still work?
> And would it be considered useful to _check_ that they still work, or
> should they be considered unsupported?

I'd suggest dropping them.

Earlier, Ard raised a similar question for gcc too -- IIRC, Ard suggested that GCC4* be removed. I agree with the idea.

Thanks
Laszlo