From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124])
 by mx.groups.io with SMTP id smtpd.web12.30828.1620647790052463714
 for <devel@edk2.groups.io>;
 Mon, 10 May 2021 04:56:30 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=enLcdK5o;
 spf=pass (domain: redhat.com, ip: 216.205.24.124, mailfrom: lersek@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1620647789;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=9o5QNoBi9i2VLUscYQCRh2Jp+ynZGJ18PabAIKL4kxE=;
	b=enLcdK5oOd4642k+4HU4HL2xEE0L5S5Ije5laYzgZmXIF459Z7IrQOPYMoFS2p/Dx0kHU4
	bYr1KP3na4efb1A/0Eu+YMacrEDP32igsucbWfL8E5NPFkMofUag3Wg++Fy58/GqPqR9LV
	n4VgzRMGY2k/9XVGCrB3rhXtfTXjLTc=
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id
 us-mta-425-hTAPaevhNSufA2JPg6zHkA-1; Mon, 10 May 2021 07:56:27 -0400
X-MC-Unique: hTAPaevhNSufA2JPg6zHkA-1
Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 4593A107ACC7;
	Mon, 10 May 2021 11:56:26 +0000 (UTC)
Received: from lacos-laptop-7.usersys.redhat.com (ovpn-114-216.ams2.redhat.com [10.36.114.216])
	by smtp.corp.redhat.com (Postfix) with ESMTP id 40DF860C54;
	Mon, 10 May 2021 11:56:25 +0000 (UTC)
Subject: Re: [edk2-devel] Build fails with VS2012
To: rebecca@bsdio.com
References: <298de55b-7cbd-22be-b584-9b83ccfe2b06@bsdio.com>
From: "Laszlo Ersek" <lersek@redhat.com>
Cc: devel@edk2.groups.io, Michael D Kinney <michael.d.kinney@intel.com>,
 Tom Lendacky <thomas.lendacky@amd.com>
Message-ID: <0ef244cf-7100-4f1b-29f5-607e9e243061@redhat.com>
Date: Mon, 10 May 2021 13:56:24 +0200
MIME-Version: 1.0
In-Reply-To: <298de55b-7cbd-22be-b584-9b83ccfe2b06@bsdio.com>
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13
Authentication-Results: relay.mimecast.com;
	auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lersek@redhat.com
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit

Hi Rebecca

+Tom

On 05/08/21 21:47, Rebecca Cran wrote:
> I'm setting up a new Jenkins server to do Bhyve builds and run on
> platforms that aren't currently tested with the GitHub/Azure system.
> 
> Since VS2012 appears to be a supported toolchain, I tried building
> OvmfPkgX64 with it (I'm also planning on testing VS2013, VS2015, VS2017
> and VS2019), but it fails with:
> 
> 
> Building ...
> c:\users\administrator\src\edk2\NetworkPkg\Library\DxeUdpIoLib\DxeUdpIoLib.inf
> [X64]
> c:\users\administrator\src\edk2\UefiCpuPkg\Library\MpInitLib\MpLib.c(1268)
> : error C2220: warning treated as error - no 'object' file generated
> c:\users\administrator\src\edk2\UefiCpuPkg\Library\MpInitLib\MpLib.c(1268)
> : warning C4306: 'type cast' : conversion from 'int' to
> 'SEV_ES_AP_JMP_FAR *' of greater size

I think the compiler is justified to complain here:

7b7508ad784d1 (Tom Lendacky     2020-08-12 15:21:42 -0500 1268)   JmpFar = (SEV_ES_AP_JMP_FAR *) FixedPcdGet32 (PcdSevEsWorkAreaBase);

The proper way to spell such casts is with (UINTN) in the middle.

Can you please file a new BZ?

> I know the GitHub/Azure system only tests with VS2017 and VS2019: are
> there plans to drop the older VS versions, or should they still work?
> And would it be considered useful to _check_ that they still work, or
> should they be considered unsupported?

I'd suggest dropping them.

Earlier, Ard raised a similar question for gcc too -- IIRC, Ard suggested that GCC4* be removed. I agree with the idea.

Thanks
Laszlo