Re: [edk2-devel] [PATCH v3 03/11] MdePkg/Acpi65: Add _PSD/_CPC/State Coordination Types macros

["PierreGondois" <pierre.gondois@arm.com>]

Hello Ray,
Is the patch acceptable as it is ? Or is there something to modify
before I send a new version ?

Regards,
Pierre

On 11/22/23 08:54, Pierre Gondois wrote:
> Hello Ray,
> 
> On 11/22/23 01:03, Ni, Ray wrote:
>> These ACPI methods were there since long ago.
>> Why do you only add the related definitions to 65.h?
> 
> I have only added the definitions to the latest ACPI definition file
> (i.e. 6.5) because:
> - as it was not defined before, I assumed it was not used previously
>     in edk2 and definitions for older ACPI spec versions might not be
>     necessary (i.e. no need to use EFI_ACPI_6_4_xxx definition if
>     EFI_ACPI_6_5_xxx is available)
> - this present patch-set only requires the latest definitions
> 
> Do you want to have definitions for all spec. versions ?
> 
>>
>>> Cf. s8.3 Power, Performance, and Throttling State Dependencies
>>
>> What does "Cf. s8.3" mean?
> 
> I used s8.3 for 'section 8.3' (in the ACPI 6.5 spec),
> 
>>
>> Thanks,
>> Ray
>>> -----Original Message-----
>>> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of
>>> PierreGondois
>>> Sent: Wednesday, November 22, 2023 12:50 AM
>>> To: devel@edk2.groups.io
>>> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>; Leif Lindholm
>>> <quic_llindhol@quicinc.com>; Sami Mujawar <sami.mujawar@arm.com>;
>>> Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming
>>> <gaoliming@byosoft.com.cn>
>>> Subject: [edk2-devel] [PATCH v3 03/11] MdePkg/Acpi65: Add
>>> _PSD/_CPC/State Coordination Types macros
>>>
>>> Add macros for:
>>> - _PSD version
>>> - _CPC version
>>> - C-state/T-state/P-state Coordination Types
>>>
>>> These objects were present in previous ACPI specification version,
>>> but are only added to the latest availbable version (6.5).
>>>
>>> Signed-off-by: Pierre Gondois <pierre.gondois@arm.com>
>>> ---
>>>    MdePkg/Include/IndustryStandard/Acpi65.h | 23
>>> +++++++++++++++++++++++
>>>    1 file changed, 23 insertions(+)
>>>
>>> diff --git a/MdePkg/Include/IndustryStandard/Acpi65.h
>>> b/MdePkg/Include/IndustryStandard/Acpi65.h
>>> index d79d0b2b5f9c..ec7c34e8e190 100644
>>> --- a/MdePkg/Include/IndustryStandard/Acpi65.h
>>> +++ b/MdePkg/Include/IndustryStandard/Acpi65.h
>>> @@ -18,6 +18,29 @@
>>>    //
>>>
>>>    #pragma pack(1)
>>>
>>>
>>>
>>> +///
>>>
>>> +/// C-state/T-state/P-state Coordination Types
>>>
>>> +/// Cf. s8.3 Power, Performance, and Throttling State Dependencies
>>>
>>> +///
>>>
>>> +#define EFI_ACPI_6_5_AML_STATE_COORD_TYPE_SW_ALL  0xFC
>>>
>>> +#define EFI_ACPI_6_5_AML_STATE_COORD_TYPE_SW_ANY  0xFD
>>>
>>> +#define EFI_ACPI_6_5_AML_STATE_COORD_TYPE_HW_ALL  0xFE
>>>
>>> +
>>>
>>> +///
>>>
>>> +/// _PSD Revision
>>>
>>> +/// Cf. s8.4.5.5 _PSD (P-State Dependency)
>>>
>>> +///
>>>
>>> +#define EFI_ACPI_6_5_AML_PSD_REVISION_V0  0
>>>
>>> +
>>>
>>> +///
>>>
>>> +/// _CPC Revision
>>>
>>> +/// Cf. s8.4.6.1 _CPC (Continuous Performance Control)
>>>
>>> +///
>>>
>>> +#define EFI_ACPI_6_5_AML_CPC_REVISION_V0  0
>>>
>>> +#define EFI_ACPI_6_5_AML_CPC_REVISION_V1  1
>>>
>>> +#define EFI_ACPI_6_5_AML_CPC_REVISION_V2  2
>>>
>>> +#define EFI_ACPI_6_5_AML_CPC_REVISION_V3  3
> 
> Also a personal note, I realize this doesn't really make sense to define
> versions like this, as there is only one revision for ACPI 6.5. This should
> be instead:
> 
> #define EFI_ACPI_6_5_AML_CPC_REVISION  3
> 
> (same comment for EFI_ACPI_6_5_AML_PSD_REVISION_V0 above)
> 
> Regards,
> Pierre


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#111732): https://edk2.groups.io/g/devel/message/111732
Mute This Topic: https://groups.io/mt/102732018/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-