From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f41.google.com (mail-ot1-f41.google.com [209.85.210.41]) by mx.groups.io with SMTP id smtpd.web10.4811.1687410450950924265 for ; Wed, 21 Jun 2023 22:07:31 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="signature has expired" header.i=@gmail.com header.s=20221208 header.b=NjQJYxPB; spf=pass (domain: gmail.com, ip: 209.85.210.41, mailfrom: kuqin12@gmail.com) Received: by mail-ot1-f41.google.com with SMTP id 46e09a7af769-6b46e61638eso4086425a34.0 for ; Wed, 21 Jun 2023 22:07:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1687410450; x=1690002450; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=LY98IJISAwSz0qNlJPvUedxANvfWkuf/J8vp689+aX0=; b=NjQJYxPB+1kzmUohG8iUWeoy1cfzd7kCJbdugVz1utJcBHPQOGCSkyRbZMBZkCAYq8 bPWg57ss86083ZSD7LBxYTfsgFQVKn2isWa2SovkMKQHvPNz6MbkR9PoGbFJIVwLw1YY k+Rhoeb1O9e6BtRbB6wbIAiJdbejk0YtOkLeBZshzDXpgqTW/vjc6uFVOPTAKKBAgFFi K/W3Cay63qRlIEKeLrPurOdOKMEbCICXLaB5/56ze6ENk1AgUR6CkGfnsUwIUBBn629j qWI0NrdSF3rQ1ZYXxSfGMKq5gogvDuTh1MOuRwLlCZKuUZeogWaLe8zwGiJ7EuDnlmWL fP6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687410450; x=1690002450; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=LY98IJISAwSz0qNlJPvUedxANvfWkuf/J8vp689+aX0=; b=k+YX82T8Fpmt8XP3Fvm0tFr3nSQ0g9Y/A0/Wd7TqTQptYr5ROnkDcI1VlNxkYuqQKo JJWCjQ3RuUdw2gcumL9MfkBpdrVmaxgjuIi5ryrLQbMv1NGlJcMECBGoESzQzPuZqgms r+XXMcGueHcXdaP0hjsEeNulJVAxbI603tw3cq5cURodbqJB2fhepW7uKnfX5D7bikor W1xBZQ6qqCnau2LdMY5SBNDQkAdBpPXMJA30rNwJc2iunISKN/8Dir8t/RxsI/af5UOp mGk7fJfqCHKeubMrPKjF3I5/e1nspesmZdHFTKHStGDXl+C0Y5Hd6dl4ZHswPbhIv/fa Ti9Q== X-Gm-Message-State: AC+VfDz4iWpB04ztHFIOFvop8632HxH8qMLKgX/dW1EHS0RR1Jj8G80d 93cK8XhKbEaP3Wwuly9gWDR59Xdr8d8= X-Google-Smtp-Source: ACHHUZ7jprck2qPCpggwD8gTDVNT3E77MibiQk56+Jvxn2HZ1wqAM8AEJntA3x1MWfdmnUpBSLYABg== X-Received: by 2002:a05:6358:511c:b0:130:de8c:8e9a with SMTP id 28-20020a056358511c00b00130de8c8e9amr6831092rwi.3.1687410449879; Wed, 21 Jun 2023 22:07:29 -0700 (PDT) Return-Path: Received: from ?IPV6:2001:4898:d8:33:2dbe:4ad1:373:a9f6? ([2001:4898:80e8:a:add6:4ad1:373:a9f6]) by smtp.gmail.com with ESMTPSA id g11-20020aa7818b000000b0064fd4a6b306sm3688813pfi.76.2023.06.21.22.07.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 21 Jun 2023 22:07:29 -0700 (PDT) Message-ID: <0f438eff-000e-0407-1fcc-a0b94b1ead82@gmail.com> Date: Wed, 21 Jun 2023 22:07:28 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [edk2-devel] [PATCH v1 0/2] Support MM based variable services in PEI for ARM To: devel@edk2.groups.io Cc: Hao A Wu , Liming Gao , Jian J Wang , Leif Lindholm , Ard Biesheuvel , Sami Mujawar References: <1766C9E1207ACAEE.10073@groups.io> From: "Kun Qin" In-Reply-To: <1766C9E1207ACAEE.10073@groups.io> Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Arm and MdeModule package maintainers, This patch series has been sent out for almost 2 weeks without any reviews. Could you please provide feedback on the change when you have a chance? Any input is appreciated. Regards, Kun On 6/8/2023 1:44 PM, Kun Qin via groups.io wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4464 > > As of today, there has been a void in the variable service in PEI phase > on ARM systems that support PEI phase and standalone MM hosted variable > service. > > This change adds the support through: > 1. Add MM communication services in PEI phase for ARM platforms. This > module is based on SMC calls to standalone MM environments, similar to > "ArmPkg/Drivers/MmCommunicationDxe". > > 2. A service module that installs `gEfiPeiReadOnlyVariable2PpiGuid` based > on step 1. Note that this driver will not have special dependency on ARM > specific code, thus will be ideally added to MdeModulePkg. > > Patch v1 branch: https://github.com/kuqin12/edk2/tree/arm_var_pei_v1 > > Cc: Hao A Wu > Cc: Liming Gao > Cc: Jian J Wang > Cc: Leif Lindholm > Cc: Ard Biesheuvel > Cc: Sami Mujawar > > Kun Qin (2): > ArmPkg: MmCommunicationPei: Introduce MM communicate in PEI > MdeModulePkg: Variable: Introduce MM based variable read service in > PEI > > ArmPkg/Drivers/MmCommunicationPei/MmCommunicationPei.c | 178 +++++++++ > MdeModulePkg/Universal/Variable/MmVariablePei/MmVariablePei.c | 381 ++++++++++++++++++++ > ArmPkg/ArmPkg.dsc | 2 + > ArmPkg/Drivers/MmCommunicationPei/MmCommunicationPei.h | 76 ++++ > ArmPkg/Drivers/MmCommunicationPei/MmCommunicationPei.inf | 41 +++ > MdeModulePkg/MdeModulePkg.dsc | 1 + > MdeModulePkg/Universal/Variable/MmVariablePei/MmVariablePei.h | 134 +++++++ > MdeModulePkg/Universal/Variable/MmVariablePei/MmVariablePei.inf | 43 +++ > 8 files changed, 856 insertions(+) > create mode 100644 ArmPkg/Drivers/MmCommunicationPei/MmCommunicationPei.c > create mode 100644 MdeModulePkg/Universal/Variable/MmVariablePei/MmVariablePei.c > create mode 100644 ArmPkg/Drivers/MmCommunicationPei/MmCommunicationPei.h > create mode 100644 ArmPkg/Drivers/MmCommunicationPei/MmCommunicationPei.inf > create mode 100644 MdeModulePkg/Universal/Variable/MmVariablePei/MmVariablePei.h > create mode 100644 MdeModulePkg/Universal/Variable/MmVariablePei/MmVariablePei.inf >